These badges do not work as they should for the following reasons:
1. If the message contains commits from multiple authors, commits count
per author is not available.
2. Even if commit count per author was available, there is no way to
evaluate the criteria separately for each author.
3. Rebasing in forks leads to the same commits being counted more than
once, without the badge recipient actually doing anything themself.
Item 1 could be solved by simple extension of schema so that Pagure
would include the count per author. If it was the only problem, there
would be no need to retire these rules.
Item 2 has the worst effect by far. It has lead to many users having the
highest level badge only because they happened to appear as an author in
a message that also included a prominent committed. Fixing it would
require extension of the rules language in fedbadges backend. It is
unclear how difficult that would be.
Item 3 would require more changes to messages emitted by Pagure. A way
to distinguish between original work and it being reapplied by others
would be needed. Perhaps comparing 'agent' and 'author' would work. But
it is unclear if fedbadges backend allows such expressions.
All in all, the rules for Pagure badges are specified in a way that is
difficult to implement correctly. Since currently badges are awarded to
users that have not earned them and nobody seems to be willing to put
effort to fix the situation, it is the best to simply retire the rules.
2021-03-23 22:19:59 +02:00
Renamed from rules/pagure-long-life-50.yml (Browse further)