package-review bot improperly resets reviews

ppisar commented

2023-04-11 07:41:24 +00:00

I noticed a package review https://bugzilla.redhat.com/show_bug.cgi?id=2060983 classified as in inconsistent state https://fedoraproject.org/PackageReviewStatus/inconsistent.html. The reason is that package-review@lists.fedoraproject.org user "reset" the approved review after 13 days of no activity by changing status to ASSIGNED and unsetting package-review flag https://bugzilla.redhat.com/show_activity.cgi?id=2060983.

This way of resetting a review breaks the consistency of the review request. Please change the bot to either:

Move the status to ASSIGNED and set package-review flag to "?" value.
Or completely unset the flag, an assignee, and move the status to NEW,
Or follow FE-DEADREVIEW https://docs.fedoraproject.org/en-US/package-maintainers/Package_Review_Process/#special_blocker_tickets approach. I.e. setting a blocker on FE-DEADREVIEW and moving the status to CLOSED.

(This ticket was copied from https://pagure.io/releng/issue/11377.)

I noticed a package review https://bugzilla.redhat.com/show_bug.cgi?id=2060983 classified as in inconsistent state https://fedoraproject.org/PackageReviewStatus/inconsistent.html. The reason is that package-review@lists.fedoraproject.org user "reset" the approved review after 13 days of no activity by changing status to ASSIGNED and unsetting package-review flag https://bugzilla.redhat.com/show_activity.cgi?id=2060983. This way of resetting a review breaks the consistency of the review request. Please change the bot to either: * Move the status to ASSIGNED and set package-review flag to "?" value. * Or completely unset the flag, an assignee, and move the status to NEW, * Or follow FE-DEADREVIEW https://docs.fedoraproject.org/en-US/package-maintainers/Package_Review_Process/#special_blocker_tickets approach. I.e. setting a blocker on FE-DEADREVIEW and moving the status to CLOSED. (This ticket was copied from <https://pagure.io/releng/issue/11377>.)

mattia commented

2023-04-11 16:54:45 +00:00

Owner

This wasn't done by review-stats bot, it was done by me and I apologize for that.

Tickets that have fedora-flag set to "+" are ignored by the bot. However, I usually look at those over one year older and manually run a script to either reset the status or close them if the package was imported in repositories and the submitter didn't close the ticket.

In this specific case, the ticket has been inactive for 1 year and 13 days and I've reset the status since a fresh new positive review is required to request a new repository, but I forgot to reset the assignee and move the status to NEW.

This wasn't done by review-stats bot, it was done by me and I apologize for that. Tickets that have fedora-flag set to "+" are ignored by the bot. However, I usually look at those over one year older and manually run a script to either reset the status or close them if the package was imported in repositories and the submitter didn't close the ticket. In this specific case, the ticket has been inactive for 1 year and 13 days and I've reset the status since a fresh new positive review is required to request a new repository, but I forgot to reset the assignee and move the status to NEW.

ppisar commented

2023-04-11 17:01:49 +00:00

Author

I see. I also did a mistake. I misread the dates in the history (2022 year as 2023 year). I completely reset the review now, based on your explanation.

ppisar commented

2023-04-11 17:01:50 +00:00

Author

Metadata Update from @ppisar:

Issue status updated to: Closed (was: Open)

**Metadata Update from @ppisar**: - Issue status updated to: Closed (was: Open)

Rows
Columns

package-review bot improperly resets reviews #17