Dockerfile always pip install from master branch #7
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Review-stats is not working since few days. The cause is the dockerfile always install from the master branch instead of from the appropriate branch (prod or stg).
I tried to fix it with 5b59075 but it doesn't work. Is there any way to use the prod/stg environment value while building the image?
Huh, it should use the branch for the Dockerfile too...
Thats in ansible:
https://pagure.io/fedora-infra/ansible/blob/master/f/roles/openshift-apps/review-stats/templates/buildconfig.yml#_14
We define 'env_short' as 'prod' in production and 'stg' in stg.
Yes, it uses the Dockerfile from the appropriate branch. But in the dockerfile there's the command:
pip install git+https://pagure.io/Fedora-Infra/review_stats.gitwhich means it installs review-stats from the master branch, both for prod and stg.
I could hardcode the command and have two different dockerfiles for the two branches:
pip install git+https://pagure.io/Fedora-Infra/review_stats.git@prodand
pip install git+https://pagure.io/Fedora-Infra/review_stats.git@stgbut I would like to know if an env variable exists so that I can avoid having two separate dockerfiles, like I tried in my previous commit.
Never mind, I was trying to do stupid things.
I only had to make the command in the dockerfile to install the already downloaded git source... hopefully the script should start running again with the next run.
Metadata Update from @mattia: