Handle tickets with disabled accounts #8

New issue

Closed

opened 2020-07-10 05:56:13 +00:00 by mattia · 2 comments

mattia commented

2020-07-10 05:56:13 +00:00

Owner

Several errors like this from the log:

2020-07-10 01:03:52,372 review_stats.py DEBUG    Setting NEEDINFO from submitter for 849496.
2020-07-10 01:03:52,853 review_stats.py ERROR    Setting NEEDINFO on bug 849496 failed: 
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/review_stats/utils.py", line 275, in set_needinfo
    bz.update_bugs([tk.bug.id], update)
  File "/usr/lib/python3.7/site-packages/bugzilla/base.py", line 1326, in update_bugs
    return self._proxy.Bug.update(tmp)
  File "/usr/lib64/python3.7/xmlrpc/client.py", line 1112, in __call__
    return self.__send(self.__name, args)
  File "/usr/lib/python3.7/site-packages/bugzilla/transport.py", line 104, in _ServerProxy__request
    self)._ServerProxy__request(methodname, params)
  File "/usr/lib64/python3.7/xmlrpc/client.py", line 1452, in __request
    verbose=self.__verbose
  File "/usr/lib/python3.7/site-packages/bugzilla/transport.py", line 202, in request
    return self._request_helper(url, request_body)
  File "/usr/lib/python3.7/site-packages/bugzilla/transport.py", line 180, in _request_helper
    return self.parse_response(response)
  File "/usr/lib/python3.7/site-packages/bugzilla/transport.py", line 154, in parse_response
    return unmarshaller.close()
  File "/usr/lib64/python3.7/xmlrpc/client.py", line 656, in close
    raise Fault(**self._stack[0])
xmlrpc.client.Fault: <Fault 32000: "You can't ask Dan Callaghan <dcallagh@redhat.com> because that account is disabled.">

We must catch these errors and close the review as DEADREVIEW if the submitter account is no more active (or reset the assignee if the needinfo request is against reviewer).

Several errors like this from the log: ``` 2020-07-10 01:03:52,372 review_stats.py DEBUG Setting NEEDINFO from submitter for 849496. 2020-07-10 01:03:52,853 review_stats.py ERROR Setting NEEDINFO on bug 849496 failed: Traceback (most recent call last): File "/usr/local/lib/python3.7/site-packages/review_stats/utils.py", line 275, in set_needinfo bz.update_bugs([tk.bug.id], update) File "/usr/lib/python3.7/site-packages/bugzilla/base.py", line 1326, in update_bugs return self._proxy.Bug.update(tmp) File "/usr/lib64/python3.7/xmlrpc/client.py", line 1112, in __call__ return self.__send(self.__name, args) File "/usr/lib/python3.7/site-packages/bugzilla/transport.py", line 104, in _ServerProxy__request self)._ServerProxy__request(methodname, params) File "/usr/lib64/python3.7/xmlrpc/client.py", line 1452, in __request verbose=self.__verbose File "/usr/lib/python3.7/site-packages/bugzilla/transport.py", line 202, in request return self._request_helper(url, request_body) File "/usr/lib/python3.7/site-packages/bugzilla/transport.py", line 180, in _request_helper return self.parse_response(response) File "/usr/lib/python3.7/site-packages/bugzilla/transport.py", line 154, in parse_response return unmarshaller.close() File "/usr/lib64/python3.7/xmlrpc/client.py", line 656, in close raise Fault(**self._stack[0]) xmlrpc.client.Fault: <Fault 32000: "You can't ask Dan Callaghan <dcallagh@redhat.com> because that account is disabled."> ``` We must catch these errors and close the review as DEADREVIEW if the submitter account is no more active (or reset the assignee if the needinfo request is against reviewer).

mattia commented

2020-07-11 08:26:36 +00:00

Author

Owner

Fixed in prod

mattia commented

2020-07-11 08:26:36 +00:00

Author

Owner

Metadata Update from @mattia:

Issue status updated to: Closed (was: Open)

**Metadata Update from @mattia**: - Issue status updated to: Closed (was: Open)

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

apps/review_stats#8

No description provided.

Rows
Columns