scm_request - migrate ticket handling to Fedora Forge #429
Labels
No labels
cle
EasyFix
Backlog Status
Needs Review
Backlog Status
Ready
chore
documentation
points
01
points
02
points
03
points
05
points
08
points
13
Priority
High
Priority
Low
Priority
Medium
Sprint Status
Blocked
Sprint Status
Done
Sprint Status
In Progress
Sprint Status
Review
Sprint Status
To Do
Technical Debt
Work Item
Bug
Work Item
Epic
Work Item
Spike
Work Item
Task
Work Item
User Story
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
apps/toddlers!429
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "jnsamyak/toddlers:migrate_scm_requests"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Please check issue for more details: releng/tickets#13370 (comment)
WIP: scm_request - migrate ticket handling to Fedora Forgeto scm_request - migrate ticket handling to Fedora Forge6bbae261e7e9478125ccAdded a set of more tests to make CI happy, and had some formatting issues.
I think for reviews, the tests/ can be ignored for now, and we can jump back on the actual code to see if I'm missing any race conditions.
But this change is to wait for fedpkg changes happening at releng/tickets#13369, I want to make sure to have things ready so we can test it out once we have fedpkg changes in.
Merging #430 for Anton, I think this PR will grow because I haven't accounted for unretirement toddler changes also, but I'll let it sit for one set of review.
I pushed changes for unretirement toddler as well, so unretirement tickets on releng/fedora-scm-requests are handled via Forgejo (forgejo.issues) instead of pagure.io. Dist-git, koji, and bodhi are unchanged. @amedvede would be nice if you could take a look at it.
304bd230ecb76f19fb00Added a test, and cosmetic changes to make CI green, let's see
I went through the changes and they look good to me.
Thanks, I'll merge this up. @zlopez should I just cherry-pick these to staging and production directly or open PRs?
Also just merge this, or squash out the commits?
@jnsamyak wrote in #429 (comment):
I think that the staging and production branch should now be at the same head as master, so there should be no need for cherry pick.
@jnsamyak wrote in #429 (comment):
Let me just merge this.