Allow turning off (globally?) the rpmlint spelling checks #591
Labels
No labels
area/installability
area/jenkins
area/rpmdeplint
area/rpminspect
area/STI
area/STI-compat
area/Testing Farm
area/tmt
area/Zuul CI
blocked
bug
discussion
feature
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Type
Help
Type
Incident
UX
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Status/Blocked
Status/Discuss
Type
Bug
Type
Feature
Type
Task
No milestone
No project
No assignees
6 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
ci/tickets#591
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Test name
rpmlint
Affected package(s)
all packages
Where it happens
dist-git PR
Example failure
https://src.fedoraproject.org/rpms/image-builder/pull-request/256
More information
The
rpmlintCI test fails very often, often times on useful things, but also often times on a bunch of spelling errors (e.g. it keeps correctingosbuildtobuild, the former is the name of a package and project).It might be nice to turn off spellchecking globally, and/or provide a mechanism (if one doesn't exist yet) to turn off certain checks after maintainers have verified that they're OK.
There is a mechanism to turn certain checks (well, rather reports) off. See, for example, https://src.fedoraproject.org/rpms/python-pip/pull-request/181 or https://src.fedoraproject.org/rpms/python-setuptools/pull-request/149
It is regex-based, so if you indeed want to turn the entire spell check off, you have the ability.
Yes, but users all across are saying that this check is usesless so I think we should add it globally in the
fedora.tomland fedora-ci's configuration https://src.fedoraproject.org/rpms/rpmlint/blob/rawhide/f/fedora.toml#_65. I'll also try to check with upstream if there are plans to change to a different spell-check provider.Having everyone include their check skip, is also an option.
Or maybe we can downgrade the error to a warning in the toml config?
Making it a warning makes sense. We could also keep improving https://src.fedoraproject.org/rpms/rpmlint/blob/rawhide/f/fedora.toml#_306 for common terms. Disabling it entirely is not perfect. I actually found a typo in the description of a python3.15 subpackage thanks to this check 🤷
Making it a warning sounds good and adding more common technical terms. Just opened one to fix some issues in cockpit
If anyone want to check it: https://github.com/packit/tmt-plans/pull/45. Can run it via
And downstream rpmlint pr is https://src.fedoraproject.org/rpms/rpmlint/pull-request/61
+1; I support turning spelling errors to warnings.
+1 for making it a warning.
https://github.com/packit/tmt-plans/pull/45 is merged, let's see how it goes