Allow turning off (globally?) the rpmlint spelling checks #591

Closed
opened 2026-09-16 07:26:49 +00:00 by supakeen · 8 comments

Test name

rpmlint

Affected package(s)

all packages

Where it happens

dist-git PR

Example failure

https://src.fedoraproject.org/rpms/image-builder/pull-request/256

More information

The rpmlint CI test fails very often, often times on useful things, but also often times on a bunch of spelling errors (e.g. it keeps correcting osbuild to build, the former is the name of a package and project).

It might be nice to turn off spellchecking globally, and/or provide a mechanism (if one doesn't exist yet) to turn off certain checks after maintainers have verified that they're OK.

### Test name rpmlint ### Affected package(s) all packages ### Where it happens dist-git PR ### Example failure https://src.fedoraproject.org/rpms/image-builder/pull-request/256 ### More information The `rpmlint` CI test fails very often, often times on useful things, but also often times on a bunch of spelling errors (e.g. it keeps correcting `osbuild` to `build`, the former is the name of a package and project). It might be nice to turn off spellchecking globally, and/or provide a mechanism (if one doesn't exist yet) to turn off certain checks after maintainers have verified that they're OK.
lecris added this to the Board project 2026-09-16 07:57:37 +00:00

There is a mechanism to turn certain checks (well, rather reports) off. See, for example, https://src.fedoraproject.org/rpms/python-pip/pull-request/181 or https://src.fedoraproject.org/rpms/python-setuptools/pull-request/149

It is regex-based, so if you indeed want to turn the entire spell check off, you have the ability.

addFilter(r"[EW]: spelling-error .*")
There is a mechanism to turn certain checks (well, rather reports) off. See, for example, https://src.fedoraproject.org/rpms/python-pip/pull-request/181 or https://src.fedoraproject.org/rpms/python-setuptools/pull-request/149 It is regex-based, so if you indeed want to turn the entire spell check off, you have the ability. ``` addFilter(r"[EW]: spelling-error .*") ```
Owner

Yes, but users all across are saying that this check is usesless so I think we should add it globally in the fedora.toml and fedora-ci's configuration https://src.fedoraproject.org/rpms/rpmlint/blob/rawhide/f/fedora.toml#_65. I'll also try to check with upstream if there are plans to change to a different spell-check provider.

Having everyone include their check skip, is also an option.

Or maybe we can downgrade the error to a warning in the toml config?

Yes, but users all across are saying that this check is usesless so I think we should add it globally in the `fedora.toml` and fedora-ci's configuration https://src.fedoraproject.org/rpms/rpmlint/blob/rawhide/f/fedora.toml#_65. I'll also try to check with upstream if there are plans to change to a different spell-check provider. Having everyone include their check skip, is also an option. Or maybe we can downgrade the error to a warning in the toml config?

Making it a warning makes sense. We could also keep improving https://src.fedoraproject.org/rpms/rpmlint/blob/rawhide/f/fedora.toml#_306 for common terms. Disabling it entirely is not perfect. I actually found a typo in the description of a python3.15 subpackage thanks to this check 🤷

Making it a warning makes sense. We could also keep improving https://src.fedoraproject.org/rpms/rpmlint/blob/rawhide/f/fedora.toml#_306 for common terms. Disabling it entirely is not perfect. I actually found a typo in the description of a python3.15 subpackage thanks to this check 🤷

Making it a warning sounds good and adding more common technical terms. Just opened one to fix some issues in cockpit

Making it a warning sounds good and adding more common technical terms. Just opened one to fix some issues in [cockpit](https://src.fedoraproject.org/rpms/rpmlint/pull-request/60)
Owner

If anyone want to check it: https://github.com/packit/tmt-plans/pull/45. Can run it via

$ testing-farm request --git-url https://github.com/LecrisUT/tmt-plans --git-ref rpmlint/lower-spellcheck -e KOJI_TASK_ID=XXX -c initiator=fedora-ci -c trigger=commit --plan /plans/rpmlint

And downstream rpmlint pr is https://src.fedoraproject.org/rpms/rpmlint/pull-request/61

If anyone want to check it: https://github.com/packit/tmt-plans/pull/45. Can run it via ```console $ testing-farm request --git-url https://github.com/LecrisUT/tmt-plans --git-ref rpmlint/lower-spellcheck -e KOJI_TASK_ID=XXX -c initiator=fedora-ci -c trigger=commit --plan /plans/rpmlint ``` And downstream rpmlint pr is https://src.fedoraproject.org/rpms/rpmlint/pull-request/61

+1; I support turning spelling errors to warnings.

+1; I support turning spelling errors to warnings.
Owner

+1 for making it a warning.

+1 for making it a warning.
Owner

https://github.com/packit/tmt-plans/pull/45 is merged, let's see how it goes

https://github.com/packit/tmt-plans/pull/45 is merged, let's see how it goes
Sign in to join this conversation.
No milestone
No project
No assignees
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ci/tickets#591
No description provided.