Update most Pagure links to Forge #287

Merged
pbokoc merged 2 commits from mwinters/council-docs:forge into main 2026-05-21 16:46:54 +00:00
Contributor

Notable exceptions:

  • CoC doesn't have any public Forge repos
  • fedora-badges doesn't exist on Forge
  • Certain links so old that I can't figure out where they went
Notable exceptions: - CoC doesn't have any public Forge repos - fedora-badges doesn't exist on Forge - Certain links so old that I can't figure out where they went
Notable exceptions:
- CoC doesn't have any public Forge repos
- fedora-badges doesn't exist on Forge
- Certain links so old that I can't figure out where they went
jflory7 2026-05-07 14:54:30 +00:00
Owner

Thanks for fixing this, @mwinters! This change updates some attributes, so I want to give this a more thoughtful review when I have time to check it. Alternatively, if @pbokoc beats me to it, that also works.

Thanks for fixing this, @mwinters! This change updates some attributes, so I want to give this a more thoughtful review when I have time to check it. Alternatively, if @pbokoc beats me to it, that also works.
Author
Contributor

No worries! Would be nice if we could get this merged before it has conflicts but otherwise no rush.

No worries! Would be nice if we could get this merged before it has conflicts but otherwise no rush.
Owner

@mwinters I'll try to get to it before Wednesday. I noticed you GPG-signed your commits. Do you want to rebase on latest changes on main to preserve your GPG signatures? Otherwise, I can rebase for you.

@mwinters I'll try to get to it before Wednesday. I noticed you GPG-signed your commits. Do you want to rebase on latest changes on `main` to preserve your GPG signatures? Otherwise, I can rebase for you.
@ -1,16 +1,18 @@
include::ROOT:partial$attributes.adoc[]
:url_badges_issues: https://pagure.io/fedora-badges/issues
:url_design_issues: https://forge.fedoraproject.org/design/tickets
Owner

I'd move these into partials/attributes.adoc in case someone wants to reuse them elsewhere.

I'd move these into `partials/attributes.adoc` in case someone wants to reuse them elsewhere.
Author
Contributor

Personally I disagree. I don't want to pollute the global space unless they're actually needed at global scope.

Personally I disagree. I don't want to pollute the global space unless they're actually needed at global scope.
Owner

We definitely prefer putting all attributes into the global attributes.adoc in docs. These attributes aren't really discoverable on their own, and having them in one place helps with that at least a little bit.

We definitely prefer putting all attributes into the global attributes.adoc in docs. These attributes aren't really discoverable on their own, and having them in one place helps with that at least a little bit.
Owner

Agree with @pbokoc, please keep these in the global attributes.adoc file so we can have a single place to maintain them.

Agree with @pbokoc, please keep these in the global `attributes.adoc` file so we can have a single place to maintain them.
mwinters marked this conversation as resolved
@ -44,3 +44,3 @@
== Communication
The {team_name} is working on improving some of our communication methods. We are tracking this work in [https://pagure.io/Fedora-Council/tickets/issue/536 ticekt #536] and will update our docs page with a new process once complete.
The {team_name} is working on improving some of our communication methods. We are tracking this work in [https://forge.fedoraproject.org/council/tickets/issues/536 ticket #536] and will update our docs page with a new process once complete.
Owner

This should be [https://forge.fedoraproject.org/council/tickets/issues/536](ticket #536)

This should be `[https://forge.fedoraproject.org/council/tickets/issues/536](ticket #536)`
Author
Contributor

Do we have an "asciidoc style guide" somewhere that outlines this preference? I was maintaining the existing syntax.

Do we have an "asciidoc style guide" somewhere that outlines this preference? I was maintaining the existing syntax.
Owner

Late edit: Ahhhh, jeez, I'm sorry, I was distracted when I originally wrote this, I was writing a forum post earlier and my brain was in Markdown mode. The correct format is link:https://forge.fedoraproject.org/council/tickets/issues/536[ticket #536]. Apologies for the confusion :)


We do, here, but it's not all that great. We're currently rewriting the whole contributor docs.

But this isn't a style preference thing - the old version is simply broken. It renders as We are tracking this work in [https://pagure.io/Fedora-Council/tickets/issue/536 ticekt #536], with the brackets and everything (and your fix does the same except with a link to forgejo and the typo is fixed :)). See here: https://docs.fedoraproject.org/en-US/council/procedures/welcome/#communication

Late edit: Ahhhh, jeez, I'm sorry, I was distracted when I originally wrote this, I was writing a forum post earlier and my brain was in Markdown mode. The correct format is `link:https://forge.fedoraproject.org/council/tickets/issues/536[ticket #536]`. Apologies for the confusion :) ----- We do, [here](https://docs.fedoraproject.org/en-US/fedora-docs/contributing-docs/style-guide/), but it's not all that great. We're currently rewriting the whole contributor docs. But this isn't a style preference thing - the old version is simply broken. It renders as `We are tracking this work in [https://pagure.io/Fedora-Council/tickets/issue/536 ticekt #536]`, with the brackets and everything (and your fix does the same except with a link to forgejo and the typo is fixed :)). See here: https://docs.fedoraproject.org/en-US/council/procedures/welcome/#communication
mwinters marked this conversation as resolved
Owner

@mwinters Other than the two comments above, I also went through the rest of the doc and tried to hunt down the links you weren't able to find replacements for:

As for the remaining pagure references:

council/modules/ROOT/pages/policy/event-location-policy.adoc
line 111: I guess just drop that, the issue wasn't migrated anywhere AFAICT, so it'll go 404 once Pagure goes down. Or maybe use an archive.org link?
line 113: replace link with dei/tickets#34

council/modules/ROOT/pages/procedures/team_directory.adoc
line 29: replace link with https://forge.fedoraproject.org/council/docs/raw/branch/main/project/modules/ROOT/partials/TEMPLATE_team_info.adoc
line 72: same as above

council/modules/ROOT/pages/procedures/tickets.adoc
line 12: I don't think we have a new CoC tracker yet, so this will have to stay until we do.

council/modules/ROOT/pages/procedures/how-to.adoc
line 2: badges aren't migrated yet
line 56: ditto
line 79: replace link with https://gitlab.com/fedora/websites-apps/fedora-websites/fedora-websites-3.0/-/work_items

project/modules/code-of-conduct/pages/index.adoc
line 94: no new CoC tracker yet
line 97: ditto

project/modules/ROOT/pages/objectives/minimization-phase-2.adoc
line 116: probably just drop the whole line because I don't think this will be migrated at all. Maybe replace with an archive.org link?

@mwinters Other than the two comments above, I also went through the rest of the doc and tried to hunt down the links you weren't able to find replacements for: As for the remaining pagure references: `council/modules/ROOT/pages/policy/event-location-policy.adoc` line 111: I guess just drop that, the issue wasn't migrated anywhere AFAICT, so it'll go 404 once Pagure goes down. Or maybe use an archive.org link? line 113: replace link with https://forge.fedoraproject.org/dei/tickets/issues/34 `council/modules/ROOT/pages/procedures/team_directory.adoc` line 29: replace link with https://forge.fedoraproject.org/council/docs/raw/branch/main/project/modules/ROOT/partials/TEMPLATE_team_info.adoc line 72: same as above `council/modules/ROOT/pages/procedures/tickets.adoc` line 12: I don't think we have a new CoC tracker yet, so this will have to stay until we do. `council/modules/ROOT/pages/procedures/how-to.adoc` line 2: badges aren't migrated yet line 56: ditto line 79: replace link with https://gitlab.com/fedora/websites-apps/fedora-websites/fedora-websites-3.0/-/work_items `project/modules/code-of-conduct/pages/index.adoc` line 94: no new CoC tracker yet line 97: ditto `project/modules/ROOT/pages/objectives/minimization-phase-2.adoc` line 116: probably just drop the whole line because I don't think this will be migrated at all. Maybe replace with an archive.org link?
@ -165,3 +165,3 @@
Elections are held once per year, in concert with the joint Fedora election cycle.
Two seats are selected at the even-numbered release election, e.g F40, F42, etc, and each position has a two-election (approximately one year) term. This change came into effect from the F40 election, following a council vote on [https://pagure.io/Fedora-Council/tickets/issue/470 this ticket] at the 2024 council hackfest.
Two seats are selected at the even-numbered release election, e.g F40, F42, etc, and each position has a two-election (approximately one year) term. This change came into effect from the F40 election, following a council vote on [https://forge.fedoraproject.org/council/tickets/issues/470 this ticket] at the 2024 council hackfest.
Owner

Should be link:https://forge.fedoraproject.org/council/tickets/issues/470[this ticket].

Should be `link:https://forge.fedoraproject.org/council/tickets/issues/470[this ticket]`.
mwinters marked this conversation as resolved
@ -45,3 +45,3 @@
These are weekly posts with status updates, schedule info, etc..
The Fedora Pagure source control repository allows posting of https://pagure.io/Fedora-Council/council-docs/issues[issues] which can be discussed, assigned and remediated.
The Fedora {team_issue_tracker_name} source control repository allows posting of link:{team_issue_tracker}[issues] which can be discussed, assigned and remediated.
Owner

These don't actually work, it renders as The Fedora {team_issue_tracker_name} source control and the link has an empty target - because the attributes file isn't included. Put this on line 1 of the file:

include::ROOT:partial$attributes.adoc[]

These don't actually work, it renders as `The Fedora {team_issue_tracker_name} source control` and the link has an empty target - because the attributes file isn't included. Put this on line 1 of the file: `include::ROOT:partial$attributes.adoc[]`
mwinters marked this conversation as resolved
pbokoc requested changes 2026-05-11 15:48:42 +00:00
Dismissed
pbokoc left a comment

Okay, I'm done for real now. :)

Okay, I'm done for real now. :)
Owner

Thanks @pbokoc for the review!

Thanks @pbokoc for the review!
Author
Contributor

@pbokoc @jflory7 I think I addressed all feedback in the 2nd commit. If this all looks good I can squash, or you can -- I don't require my shiny badge on every commit :).

@pbokoc @jflory7 I think I addressed all feedback in the 2nd commit. If this all looks good I can squash, or you can -- I don't require my shiny badge on every commit :).
pbokoc approved these changes 2026-05-21 16:46:12 +00:00
pbokoc merged commit 1ce607e7a2 into main 2026-05-21 16:46:54 +00:00
Owner

Cool, thank you!

Cool, thank you!
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
council/docs!287
No description provided.