Update most Pagure links to Forge #287
Labels
No labels
type
dev tools
type
existing docs
type
new docs
good first issue
help wanted
needs
changes
needs
reporter feedback
needs
triage
needs
vote
role
engineering
role
fca
role
foa
role
fpl
role
initiative lead
role
mindshare
scope
bug
scope
improvement
scope
new
state
approved
state
blocked
state
duplicate
state
invalid
state
wontfix
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Blocks
#285 Replace pagure links with forge links
council/docs
Reference
council/docs!287
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "mwinters/council-docs:forge"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Notable exceptions:
Thanks for fixing this, @mwinters! This change updates some attributes, so I want to give this a more thoughtful review when I have time to check it. Alternatively, if @pbokoc beats me to it, that also works.
No worries! Would be nice if we could get this merged before it has conflicts but otherwise no rush.
@mwinters I'll try to get to it before Wednesday. I noticed you GPG-signed your commits. Do you want to rebase on latest changes on
mainto preserve your GPG signatures? Otherwise, I can rebase for you.@ -1,16 +1,18 @@include::ROOT:partial$attributes.adoc[]:url_badges_issues: https://pagure.io/fedora-badges/issues:url_design_issues: https://forge.fedoraproject.org/design/ticketsI'd move these into
partials/attributes.adocin case someone wants to reuse them elsewhere.Personally I disagree. I don't want to pollute the global space unless they're actually needed at global scope.
We definitely prefer putting all attributes into the global attributes.adoc in docs. These attributes aren't really discoverable on their own, and having them in one place helps with that at least a little bit.
Agree with @pbokoc, please keep these in the global
attributes.adocfile so we can have a single place to maintain them.@ -44,3 +44,3 @@== CommunicationThe {team_name} is working on improving some of our communication methods. We are tracking this work in [https://pagure.io/Fedora-Council/tickets/issue/536 ticekt #536] and will update our docs page with a new process once complete.The {team_name} is working on improving some of our communication methods. We are tracking this work in [https://forge.fedoraproject.org/council/tickets/issues/536 ticket #536] and will update our docs page with a new process once complete.This should be
[https://forge.fedoraproject.org/council/tickets/issues/536](ticket #536)Do we have an "asciidoc style guide" somewhere that outlines this preference? I was maintaining the existing syntax.
Late edit: Ahhhh, jeez, I'm sorry, I was distracted when I originally wrote this, I was writing a forum post earlier and my brain was in Markdown mode. The correct format is
link:https://forge.fedoraproject.org/council/tickets/issues/536[ticket #536]. Apologies for the confusion :)We do, here, but it's not all that great. We're currently rewriting the whole contributor docs.
But this isn't a style preference thing - the old version is simply broken. It renders as
We are tracking this work in [https://pagure.io/Fedora-Council/tickets/issue/536 ticekt #536], with the brackets and everything (and your fix does the same except with a link to forgejo and the typo is fixed :)). See here: https://docs.fedoraproject.org/en-US/council/procedures/welcome/#communication@mwinters Other than the two comments above, I also went through the rest of the doc and tried to hunt down the links you weren't able to find replacements for:
As for the remaining pagure references:
council/modules/ROOT/pages/policy/event-location-policy.adocline 111: I guess just drop that, the issue wasn't migrated anywhere AFAICT, so it'll go 404 once Pagure goes down. Or maybe use an archive.org link?
line 113: replace link with dei/tickets#34
council/modules/ROOT/pages/procedures/team_directory.adocline 29: replace link with https://forge.fedoraproject.org/council/docs/raw/branch/main/project/modules/ROOT/partials/TEMPLATE_team_info.adoc
line 72: same as above
council/modules/ROOT/pages/procedures/tickets.adocline 12: I don't think we have a new CoC tracker yet, so this will have to stay until we do.
council/modules/ROOT/pages/procedures/how-to.adocline 2: badges aren't migrated yet
line 56: ditto
line 79: replace link with https://gitlab.com/fedora/websites-apps/fedora-websites/fedora-websites-3.0/-/work_items
project/modules/code-of-conduct/pages/index.adocline 94: no new CoC tracker yet
line 97: ditto
project/modules/ROOT/pages/objectives/minimization-phase-2.adocline 116: probably just drop the whole line because I don't think this will be migrated at all. Maybe replace with an archive.org link?
@ -165,3 +165,3 @@Elections are held once per year, in concert with the joint Fedora election cycle.Two seats are selected at the even-numbered release election, e.g F40, F42, etc, and each position has a two-election (approximately one year) term. This change came into effect from the F40 election, following a council vote on [https://pagure.io/Fedora-Council/tickets/issue/470 this ticket] at the 2024 council hackfest.Two seats are selected at the even-numbered release election, e.g F40, F42, etc, and each position has a two-election (approximately one year) term. This change came into effect from the F40 election, following a council vote on [https://forge.fedoraproject.org/council/tickets/issues/470 this ticket] at the 2024 council hackfest.Should be
link:https://forge.fedoraproject.org/council/tickets/issues/470[this ticket].@ -45,3 +45,3 @@These are weekly posts with status updates, schedule info, etc..The Fedora Pagure source control repository allows posting of https://pagure.io/Fedora-Council/council-docs/issues[issues] which can be discussed, assigned and remediated.The Fedora {team_issue_tracker_name} source control repository allows posting of link:{team_issue_tracker}[issues] which can be discussed, assigned and remediated.These don't actually work, it renders as
The Fedora {team_issue_tracker_name} source controland the link has an empty target - because the attributes file isn't included. Put this on line 1 of the file:include::ROOT:partial$attributes.adoc[]Okay, I'm done for real now. :)
Thanks @pbokoc for the review!
9e90fb0360tof097e8acba@pbokoc @jflory7 I think I addressed all feedback in the 2nd commit. If this all looks good I can squash, or you can -- I don't require my shiny badge on every commit :).
f097e8acbato8576e3d0f5Cool, thank you!