Outdated docsbuilder.sh pulls Antora container w/ EOL nodejs #19
Labels
No labels
effort
high
effort
low
effort
medium
good first issue
help wanted
meeting topic
needs changes
needs reporter feedback
needs review
priority
high
priority
low
priority
medium
type/content
type/misc
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
docs/tickets#19
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Instances of docsbuilder.sh in various repos pull one of two container images, docker.io/antora/antora or registry.gitlab.com/fedora/docs/docs-website/docs-fp-o. Both images are outdated and contain numerous security issues.
The docker image uses alpine 3.18.3 from 2023-08-07 as base image and ships with nodejs 16.20.2 (EOL 2023-09-12).
The gitlab image uses fedora-minimal 42 from mid-2025 (exact date unknown) as base image and has been pushed to a registry not typically used by Fedora.
[Edited for clarity.]
I didn't find the Containerfile for the gitlab image. podman history reports
[Edited]
Discussed in 2026-05-05 Docs Team meeting.
The team briefly touched base on this ticket. It was confirmed that the primary script updates need to happen in the
docs-templaterepository first before the changes are propagated via submodules to the other repositories.Follow-up Items:
Attached the results of security scans with docker.io/anchore/grype.
[Edited]
Thanks for reporting this. We've inspected the container image and found some context:
The container image pulled by
docsbuilder.shis likely built from a similar Containerfile:https://forge.fedoraproject.org/docs/docs-fp-o/src/branch/prod/build-scripts/Dockerfile
It appears the above Containerfile is used in OpenShift to rebuild the whole site for Fedora.
We will continue to investigate the relevance of the image and the security status to address the concerns you raised.
Actually, the container image pulled by
docsbuilder.shis likely built from this Containerfile:https://forge.fedoraproject.org/docs/docs-fp-o/src/branch/prod/Dockerfile
We discussed the issue in the community meeting. We will update the container image that the script pulls in the short term. We will create a dedicated repository for the script and a new container build process in the long term.
Context on the current situation:
AIUI, the GitLab CI (
.gitlab-ci.yml) was previously building and pushing the container image to the GitLab registry. Specifically, it would:Dockerfilein theprodbranchregistry.gitlab.com/fedora/docs/docs-website/docs-fp-o:latestprodbranch when theDockerfileor.gitlab-ci.ymlchangedThe
docsbuilder.shscript pulls this image and builds the preview.Current blocker:
Following the migration to Fedora Forge, we no longer have a functional CI in place to automatically build and push updated images. We will likely need a runner for the Fedora Forge Docs org for this.
Temporary solutions:
Manual build and push: Build the image locally with an updated
Dockerfileand push it to a dedicated repo inquay.io. We will likely need this repo in the long term anyway. This is the quickest path forward but requires manual intervention each time the image needs updating.Add local build option to the script: Modify the script to support an option that builds the container image locally before running the docs module preview. This makes the workflow self-contained, though we will need to provide a Containerfile or document how to create one.
The first approach would unblock the immediate issue while we work on the permanent CI solution. The second can be implemented in the longer term.