Reaffirm provenpackager policy bounds #3687
Labels
No labels
document it
fast track
meeting
next release
nonresponsive maintainer
packager revocation
pending announcement
provenpackager
python 2 exception
self contained change
stalled
Status
Accepted
Status
Duplicate
Status
Insufficient data
Status
Invalid
Status
Rejected
system wide change
updates policy exception
vote-in-progress
No milestone
No project
No assignees
8 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
fesco/tickets#3687
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
[draft]
To be sent to devel-announce:
FESCo reaffirms that converting packages to (or from) %autochangelog and %autorelease falls are not considered "general cleanup" and provenpackagers should acquire maintainer approval before applying such a conversion, or use a pull request instead. See https://docs.fedoraproject.org/en-US/fesco/Who_is_allowed_to_modify_which_packages/#digest for the details of what changes should be done by provenpackagers without prior discussion.
I don't think pushing "general cleanup" changes as a provenpackager without prior communication or a PR is appropriate either, unless the cleanup is "urgent" or security-related or similar.
The policy allows "a general cleanup to a lot of packages". I quoted the "general cleanup" phrase, but the policy is actually narrower than that. The way I understand it, it is OK to do a sweeping cleanup across a bunch of packages without asking.
https://docs.fedoraproject.org/en-US/fesco/Mass_package_changes/ are supposed to be announced first.
Here's my stab at a more verbose version:
Subject: Reminder on scope of provenpackager changes
Provenpackgers are a group of package maintainers with access to all packages in fedora.
However, we would like to remind everyone that this access should be used only in narrow cases and
should not be used to make changes beyond the very small changes to fix immediate issues without
consulting with the package maintainer(s).
In particular provenpackagers should not convert packages to %autorelease/%autochangelog or do
large 'cleanup' changes without maintainer(s) permission.
See https://docs.fedoraproject.org/en-US/fesco/Who_is_allowed_to_modify_which_packages/ for the full policy.
Let's not use "(s)", it's a DOS-era antipatterna and doesn't actually work. The correct sentence would be "without maintainer's permission" or "without maintainers' permission", and "without maintainer permission(s)" doesn't match either. Just "without maintainer permission" is easier on the eyes and works quite well.
I don't like the proposed phrasing because it constrains what pps are allowed to do more than the official policy.
Maybe something like this:
I think "larger cleanups" is a bit of a red herring here. converting to rpmautospec is arguably not a "cleanup" but 1) bringing the package in line with SHOULD packaging guidelines but also 2) changes packager workflow. And if a package has not been converted by now, that should probably be considered a conscious packager choice, i.e. there is a reason why this SHOULD guideline is not followed, and it should not be overridden by a provenpackager without consulting the maintainer first.
New version:
I'm fine with that wording. +1
+1 too
+1
+1
+1
I don't really have any standing here, but I would like to suggest a slightly more general wording, something of the form:
PP permissions MUST NOT be used to implement SHOULD recommendations across the entire (or a significant set) of the package ecosystem (in practice turning them into effective MUSTs) without a much wider discussion and approval by FESCo.
I think that should be covered by the link to the policy about Mass Package Changes, but perhaps this could use additional clarification in the announcement.
I would also like to add a general reminder to the proposed announcement along the lines of "provenpackager members are trusted packagers that are considered examples to the rest of the Fedora packaging community and should therefore take extra care always to respectfully communicate and collaborate with other developers and closely follow the Packaging Guidelines."