Private Issues: Investigate integration tests broken in #168 #420
Labels
No labels
Backlog Status
Needs Review
Backlog Status
Ready
Chore
points
01
points
02
points
03
points
05
points
08
points
13
Priority
High
Priority
Low
Priority
Medium
Sprint Status
Blocked
Sprint Status
Done
Sprint Status
In Progress
Sprint Status
Review
Sprint Status
To Do
Technical Debt
Work Item
Bug
Work Item
Epic
Work Item
Spike
Work Item
Task
Work Item
User Story
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Blocks
#113 Private Issues
forge/forge
Reference
forge/forge#420
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Three integration tests fail with the basic private issue changes applied:
Investigate why and fix.
TestAdminModerationViewReports
TestLinksLogin
TestNotification
Acceptance Criteria
private_issuetable was added.The errors in
TestLinksLoginandTestNotificationare the same, attempting to dereference a nil pointer inNotificationList.LoadIssuePullRequests()(models/activities/notification.go:468):There’s more:
Looks like the migration has to explicitly create the
private_issuetable from a copy of thePrivateIssuestruct type.Fixed in my feature branch, in “Refactor use of issue IDs in internal APIs” (when looking up PRs which would fix issues, the code missed putting the issues in the PR struct which later was used to look up their IDs) and “feat: Private Issues: Foundational changes” (adding a private issue ID column fuzzed with the number of displayed items when dealing with abuse shadow copies, the migration script must add the
private_issuetable before it can establish FK relations in other tables).