forge/forge
14
10
Fork 8
Code Issues 108 Pull requests Projects Wiki Activity Actions

Private Issues, Web UI: Investigate and implement the milestone changes on a private issue #518

New issue
Closed
opened 2026-04-16 03:51:16 +00:00 by t0xic0der · 3 comments
t0xic0der commented 2026-04-16 03:51:16 +00:00
Member
Copy link

Summary

Private Issues, Web UI: Investigate and implement the milestone changes on a private issue

Details

Private Issues, Web UI: Investigate and implement the milestone changes on a private issue

Whenever the milestone associated to a private issue is changed, we need to see how it gets reflected on the history timeline, how it shows up under the milestone listing, who can access it from under the milestone listing and whether we inadvertently expose the private issue.

### Summary Private Issues, Web UI: Investigate and implement the milestone changes on a private issue ### Details Private Issues, Web UI: Investigate and implement the milestone changes on a private issue Whenever the milestone associated to a private issue is changed, we need to see how it gets reflected on the history timeline, how it shows up under the milestone listing, who can access it from under the milestone listing and whether we inadvertently expose the private issue.
t0xic0der added this to the (deleted) project 2026-04-16 03:51:17 +00:00
humaton modified the project from (deleted) to Backlog 2026-07-20 10:41:51 +00:00
t0xic0der modified the project from Backlog to Sprint 26 2026-07-27 10:47:39 +00:00
t0xic0der commented 2026-07-30 05:02:06 +00:00
Author
Member
Copy link

I am blocked now. Yet again. What's new in that? Here's why.

I was implementing the sidebar support for milestone changes. I found that the frontend template and router fixes (i.e. passing is_private in HTMX URLs, querying private_comment in HTMX response), made the sidebar interaction work correctly.

Screenshot From 2026-07-30 09-30-25

But the said change does not persist on refreshing frontend. It simply goes away. Now, this stupid problem is not specific to milestone changes, it seems to affect all comment types on private issues - and hence, needs to be fixed first.

Screenshot From 2026-07-30 09-54-45

FindComments always queries the comment table. It should query the private_comment table, no? I mean, CreateComment does correctly create it at the intended location so this needs to be fixed on the database backend before views.

I have a fix. I think it works. I will open up a new issue ticket for that. Once, this foundational change is introduced to the database backend, I can finally go back to fixing things on the frontend templates. Then we would have new problems.

I am blocked now. Yet again. ~~What's new in that?~~ Here's why. I was implementing the sidebar support for milestone changes. I found that the frontend template and router fixes (i.e. passing `is_private` in HTMX URLs, querying `private_comment` in HTMX response), made the sidebar interaction work correctly. ![Screenshot From 2026-07-30 09-30-25](/attachments/6e8010c2-346d-4829-8864-1b698554e5f2) But the said change does not persist on refreshing frontend. It simply goes away. Now, this stupid problem is not specific to milestone changes, it seems to affect all comment types on private issues - and hence, needs to be fixed first. ![Screenshot From 2026-07-30 09-54-45](/attachments/53a1bf95-4095-4da5-a739-724a2ff4e3cf) `FindComments` always queries the `comment` table. It should query the `private_comment` table, no? I mean, `CreateComment` does correctly create it at the intended location so this needs to be fixed on the database backend before views. I have a fix. I think it works. I will open up a new issue ticket for that. Once, this foundational change is introduced to the database backend, I can finally go back to fixing things on the frontend templates. Then we would have new problems.
Screenshot From 2026-07-30 09-30-25.png
161 KiB
Screenshot From 2026-07-30 09-54-45.png
141 KiB
t0xic0der commented 2026-07-30 05:22:23 +00:00
Author
Member
Copy link

See https://codeberg.org/fedora/forgejo/pulls/105.

Draft state. Until https://codeberg.org/fedora/forgejo/pulls/104 gets merged.

See https://codeberg.org/fedora/forgejo/pulls/105. Draft state. Until https://codeberg.org/fedora/forgejo/pulls/104 gets merged.
t0xic0der commented 2026-08-04 15:21:45 +00:00
Author
Member
Copy link

https://codeberg.org/fedora/forgejo/pulls/105 was finally merged.

Closing this!

https://codeberg.org/fedora/forgejo/pulls/105 was finally merged. Closing this!
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
test
docs
No results found.
Labels
Clear labels   
ai-review-please
label for requesting AI code review

  
Org/Team Modification

   
Private Issues
Label for tracking development on Private Issues in Forgejo

  
Runner Request
  
Backlog Status
Needs Review
 Work items that have been created or updated but need review, refinement, or approval before they can be considered ready for sprint planning.

  
Backlog Status
Ready
 Work items that have been reviewed, refined, and are ready to be committed to a sprint. These items have clear requirements and can be worked on immediately when capacity is available.

  
chore
Work that needs to be done but doesn't add new functionality or fix bugs. Maintenance tasks that keep the system running smoothly and the codebase clean.

  
documentation
Work focused on creating, updating, or improving documentation for users, developers, or system administrators.

  
points
01
 A task that is simple, small, and has very little uncertainty. It should be easy enough for any team member to pick up and complete quickly, without a lot of discussion or research.

  
points
02
 This is a task that is slightly more complex or larger than a "1." It might involve two or three simple steps, but the outcome is still very clear and there's little uncertainty.

  
points
03
 Medium-sized task with some noticeable complexity. It might require a bit more thought or collaboration. The steps are well-defined, but it's not a trivial change.

  
points
05
 A significant piece of work. It has more complexity and a higher degree of uncertainty than smaller tasks. It might require some research, a design discussion, or collaboration across multiple teams.

  
points
08
 Complex task with a lot of uncertainty. It's often the largest size that a team will consider for a single sprint. It likely requires a detailed breakdown and multiple team members to complete.

  
points
13
 Any task that feels like it's a "13" or more is considered an Epic. These are too large and uncertain to be worked on in a single sprint and should be broken down.

  
Priority
High
 This is for work that is critical and needs to be addressed in the next sprint. It's often for urgent bugs, important features, or a major piece of technical debt that is blocking other work.

  
Priority
Low
 This is for work that is good to do but not urgent. It's a candidate for being worked on when there's extra time or when it rises in importance. It can stay in the backlog for a longer period.

  
Priority
Medium
 This is for important work that should be done soon, but isn't as urgent as a high-priority item. It will likely be considered for the next 1-2 sprints.

  
Sprint Status
Blocked
 Work items that cannot progress due to external dependencies, blockers, or issues that need resolution.

  
Sprint Status
Done
 Work items that have been completed, reviewed, and integrated. No further work is needed within the current sprint.

  
Sprint Status
In Progress
 Work items currently being worked on by a team member. Active development, research, or implementation is happening.

  
Sprint Status
Review
 Work items that are complete but need review, testing, or approval before being marked as done.

  
Sprint Status
To Do
 Work items that are committed to the sprint but haven't been started yet. These items are ready to be picked up by team members.

  
Technical Debt
Work that addresses shortcuts, workarounds, or suboptimal implementations that were done previously to meet deadlines. These items improve code quality, maintainability, or performance without adding new features.

  
Work Item
Bug
 Issues where the system is not working as intended or designed. Bugs represent deviations from expected behavior.

  
Work Item
Epic
 Large initiatives that are broken down into multiple smaller work items (user stories, tasks, bugs). Epics represent significant features or projects that span multiple sprints.

  
Work Item
Spike
 Time-boxed research, investigation, or proof-of-concept work to reduce uncertainty or explore solutions. Spikes help inform future development decisions.

  
Work Item
Task
 Used to break down larger user stories into smaller, manageable implementation pieces. They focus on the specific technical steps needed to deliver the user story's value.

  
Work Item
User Story
 User-facing features or functionality that can be framed from a user perspective, describing what someone wants to accomplish and why.

No labels
ai-review-please
Org/Team Modification
Private Issues
Runner Request
Backlog Status
Needs Review
Backlog Status
Ready
chore
documentation
points
01
points
02
points
03
points
05
points
08
points
13
Priority
High
Priority
Low
Priority
Medium
Sprint Status
Blocked
Sprint Status
Done
Sprint Status
In Progress
Sprint Status
Review
Sprint Status
To Do
Technical Debt
Work Item
Bug
Work Item
Epic
Work Item
Spike
Work Item
Task
Work Item
User Story
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Sprint 26
Assignees
Clear assignees
No assignees
t0xic0der
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#673 Private Issues, Web UI: Investigate the visibility consequences
forge/forge
#710 Private Issues, Web UI: Milestone sidebar missing data-is-private
forge/forge
#711 Private Issues, Web UI: Deadline/watch/reference sidebar missing data-is-private
forge/forge
#774 Write tests for frontend changes on private issues milestones modification
forge/forge
Depends on
#695 Private Issues: Finding private issues comments unavailable functionality
forge/forge
Reference
forge/forge#518
No description provided.