infra/ansible
23
2
Fork 44
Code Pull requests 13 Activity Actions

Restore arcane breadcrumbs (broken link) #3174

Merged
kevin merged 1 commit from mwinters/infra-ansible:tahrir_breadcrumb into main 2026-03-11 21:09:38 +00:00
Conversation 10 Commits 1 Files changed 34 +52 -54
mwinters commented 2026-02-25 22:37:19 +00:00
Contributor
Copy link

I'm trying to get my head around Tahrir and just encountered this broken breadcrumb:

I'm trying to get my head around Tahrir and just encountered this broken breadcrumb: - https://github.com/fedora-infra/tahrir - -> https://tahrir.readthedocs.io/en/latest/installation.html - -> https://infrastructure.fedoraproject.org/infra/ansible/roles/openshift-apps/badges/templates/tahrir.cfg.py - -> https://forge.fedoraproject.org/infra/tickets/8689 (404)
kevin commented 2026-02-25 23:01:17 +00:00
Owner
Copy link

The link is wrong, but the new link should be:

infra/tickets#8689

so, the update commit where I tried to update pagure.io issue links to forge seems to have missed a part of the path.

The link is wrong, but the new link should be: https://forge.fedoraproject.org/infra/tickets/issues/8689 so, the update commit where I tried to update pagure.io issue links to forge seems to have missed a part of the path.
mwinters force-pushed tahrir_breadcrumb from 4542e501b6
Some checks failed
Linter / yamllint (pull_request) Has been cancelled
Details
Linter / ansible-lint (pull_request) Has been cancelled
Details
to ee88fafbeb
Some checks are pending
Linter / yamllint (pull_request) Blocked by required conditions
Details
Linter / ansible-lint (pull_request) Blocked by required conditions
Details
2026-03-02 23:11:25 +00:00 Compare
mwinters force-pushed tahrir_breadcrumb from ee88fafbeb
Some checks are pending
Linter / yamllint (pull_request) Blocked by required conditions
Details
Linter / ansible-lint (pull_request) Blocked by required conditions
Details
to 2047fc08d7
Some checks are pending
Linter / yamllint (pull_request) Blocked by required conditions
Details
Linter / ansible-lint (pull_request) Blocked by required conditions
Details
2026-03-02 23:16:02 +00:00 Compare
mwinters commented 2026-03-02 23:19:36 +00:00
Author
Contributor
Copy link

@kevin Thanks, rebased and updated.

@kevin Thanks, rebased and updated.
mwinters force-pushed tahrir_breadcrumb from a1b06af115
Some checks are pending
Linter / yamllint (pull_request) Blocked by required conditions
Details
Linter / ansible-lint (pull_request) Blocked by required conditions
Details
to 894322aa8d
Some checks failed
Linter / yamllint (pull_request) Failing after 25s
Details
Linter / ansible-lint (pull_request) Failing after 42s
Details
2026-03-02 23:55:10 +00:00 Compare
mwinters commented 2026-03-02 23:56:12 +00:00
Author
Contributor
Copy link

@kevin I added a second commit to fix all such instances. The only non-comment change was files/httpd/fedorahosted-redirects.conf -- maybe double-check that..

@kevin I added a second commit to fix all such instances. The only non-comment change was `files/httpd/fedorahosted-redirects.conf` -- maybe double-check that..
mwinters force-pushed tahrir_breadcrumb from 894322aa8d
Some checks failed
Linter / yamllint (pull_request) Failing after 25s
Details
Linter / ansible-lint (pull_request) Failing after 42s
Details
to ef010bcedb
Some checks failed
Linter / yamllint (pull_request) Successful in 26s
Details
Linter / ansible-lint (pull_request) Failing after 44s
Details
2026-03-03 21:45:38 +00:00 Compare
mwinters commented 2026-03-03 21:48:45 +00:00
Author
Contributor
Copy link

@kevin The linters are complaining about problems I didn't create :)

I added a 3rd commit, to satisfy yamllint because that was just trailing spaces. I don't know what ansible-lint wants. (No spare cycles to grok that playbook at the moment.)

Let me know if you want me to squash before merge.

@kevin The linters are complaining about problems I didn't create :) I added a 3rd commit, to satisfy yamllint because that was just trailing spaces. I don't know what ansible-lint wants. (No spare cycles to grok that playbook at the moment.) Let me know if you want me to squash before merge.
kevin requested changes 2026-03-03 23:10:57 +00:00
kevin left a comment
Owner
Copy link

Two raw links need adjustment. ;)

But this also hits frozen hosts, so it needs a freeze break or to wait until after freeze. Do you have a preference? I think it all seems reasonable (aside the two minor things), so I would +1 it (but it needs another).

yeah, don't worry about linting for now... there's a few pr's to fix things more for that but dont worry about it being a blocker for now.

Two raw links need adjustment. ;) But this also hits frozen hosts, so it needs a freeze break or to wait until after freeze. Do you have a preference? I think it all seems reasonable (aside the two minor things), so I would +1 it (but it needs another). yeah, don't worry about linting for now... there's a few pr's to fix things more for that but dont worry about it being a blocker for now.
roles/mailman3/files/top.html Outdated
@ -5,3 +5,3 @@
<div style="margin: auto" class="container">
<a href="https://fedoraproject.limequery.com/2023" target="_blank">
<img src="https://forge.fedoraproject.org/infra/tickets/raw/files/b4d328e7ce730f610530822af4c9cdab1029c47dc2bdb15648d4008e1b304e43-contributor-survey-banner.png" style="max-width: 100%">
<img src="https://forge.fedoraproject.org/infra/tickets/issues/raw/files/b4d328e7ce730f610530822af4c9cdab1029c47dc2bdb15648d4008e1b304e43-contributor-survey-banner.png" style="max-width: 100%">
kevin commented 2026-03-03 23:08:34 +00:00
Owner
Copy link

This doesn't seem quite right... at least it's 404...

This doesn't seem quite right... at least it's 404...
mwinters commented 2026-03-04 22:52:13 +00:00
Author
Contributor
Copy link

I'm not sure how to fix this. Both the original and my updated version are 404, and I have no way to know what ticket number these attachments belong to so I can't go figure out the correct URL (if there is one).

I'm not sure how to fix this. Both the original and my updated version are 404, and I have no way to know what ticket number these attachments belong to so I can't go figure out the correct URL (if there is one).
kevin commented 2026-03-04 23:17:28 +00:00
Owner
Copy link

Ah yeah, it's an attachment...

https://forge.fedoraproject.org/fedora-infrastructure/issue/raw/files/b4d328e7ce730f610530822af4c9cdab1029c47dc2bdb15648d4008e1b304e43-contributor-survey-banner.png

I think should be right? (although really it just redirects to the old pagure attachment since that url is a pagure one and attachments didn't migrate).

Ah yeah, it's an attachment... https://forge.fedoraproject.org/fedora-infrastructure/issue/raw/files/b4d328e7ce730f610530822af4c9cdab1029c47dc2bdb15648d4008e1b304e43-contributor-survey-banner.png I think should be right? (although really it just redirects to the old pagure attachment since that url is a pagure one and attachments didn't migrate).
mwinters marked this conversation as resolved
roles/openshift-apps/noggin/templates/after-navbar.html Outdated
@ -6,3 +6,3 @@
<div class="banner">
<a href="https://fedoraproject.limequery.com/2023" target="_blank">
<img src="https://forge.fedoraproject.org/infra/tickets/raw/files/b4d328e7ce730f610530822af4c9cdab1029c47dc2bdb15648d4008e1b304e43-contributor-survey-banner.png">
<img src="https://forge.fedoraproject.org/infra/tickets/issues/raw/files/b4d328e7ce730f610530822af4c9cdab1029c47dc2bdb15648d4008e1b304e43-contributor-survey-banner.png">
kevin commented 2026-03-03 23:08:57 +00:00
Owner
Copy link

Same here.

Same here.
mwinters marked this conversation as resolved
mwinters commented 2026-03-04 22:55:15 +00:00
Author
Contributor
Copy link

@nirik See my thread comment above. I'm fine with merging this after the freeze, though perhaps the broken redirect is worth the breakglass -- your call.

@nirik See my thread comment above. I'm fine with merging this after the freeze, though perhaps the broken redirect is worth the breakglass -- your call.
mwinters force-pushed tahrir_breadcrumb from ef010bcedb
Some checks failed
Linter / yamllint (pull_request) Successful in 26s
Details
Linter / ansible-lint (pull_request) Failing after 44s
Details
to d3a3c98bbf
Some checks failed
Linter / yamllint (pull_request) Successful in 27s
Details
Linter / ansible-lint (pull_request) Has been cancelled
Details
2026-03-05 15:51:13 +00:00 Compare
mwinters force-pushed tahrir_breadcrumb from d3a3c98bbf
Some checks failed
Linter / yamllint (pull_request) Successful in 27s
Details
Linter / ansible-lint (pull_request) Has been cancelled
Details
to 68c54c6832
Some checks failed
Linter / yamllint (pull_request) Successful in 27s
Details
Linter / ansible-lint (pull_request) Failing after 45s
Details
AI Code Review / ai-review (pull_request_target) Successful in 35s
Details
2026-03-05 15:52:06 +00:00 Compare
mwinters commented 2026-03-05 15:53:53 +00:00
Author
Contributor
Copy link

@nirik I corrected the attachment URLs and squashed.

@nirik I corrected the attachment URLs and squashed.
kevin commented 2026-03-05 19:57:04 +00:00
Owner
Copy link

Thanks! Lets just wait and push this next wed...

Thanks! Lets just wait and push this next wed...
❤️ 1
forgejo-actions commented 2026-03-11 21:06:24 +00:00
Copy link

AI Code Review

📋 MR Summary

Fixes broken Forge links across the repository by appending /issues/ to ticket paths and correcting raw attachment URLs. The changes predominantly affect code comments, with functional updates to an httpd redirect rule and two HTML templates.

  • Key Changes:
    • Updated functional httpd redirect in fedorahosted-redirects.conf to point legacy ticket URLs to the new /issues/ endpoint.
    • Corrected raw attachment URLs for survey banners in Mailman3 and Noggin HTML templates.
    • Performed a repository-wide search-and-replace to fix broken Forge ticket references in comments.
    • Removed trailing whitespace/newlines in a few files to resolve existing yamllint warnings.
  • Impact: httpd (redirects), mailman3 (templates), noggin (templates), ansible roles (documentation/comments)
  • Risk Level: 🟢 Low - The vast majority of changes are isolated to code comments. The functional changes (HTML templates and Apache redirects) are straightforward string replacements that have been validated against the new Forge URL structure.

Detailed Code Review

The implementation correctly aligns with the conclusions discussed during the PR review process. The broken attachment links have been successfully reconstructed using the proper fedora-infrastructure/issue/raw/files/ path format. The repository-wide updates to the documentation comments accurately implement the /issues/ path injection.

The update to files/httpd/fedorahosted-redirects.conf correctly preserves the regex capture group $1 while safely updating the destination URL. Furthermore, the minor whitespace removals nicely satisfy yamllint without bleeding into broader linting scopes, which honors the reviewer's guidance that full linting is not a blocker here.

No critical issues or bugs were identified in this review.

✅ Summary

  • Overall Assessment: The changes successfully restore the broken breadcrumbs and functional links with no identified security, performance, or logic issues.

🤖 AI Code Review | Generated with ai-code-review | Model: gemini-3.1-pro-preview

⚠️ AI-generated suggestions may be incorrect. Verify before applying. Not a replacement for human review.

## AI Code Review ### 📋 MR Summary Fixes broken Forge links across the repository by appending `/issues/` to ticket paths and correcting raw attachment URLs. The changes predominantly affect code comments, with functional updates to an httpd redirect rule and two HTML templates. - **Key Changes:** - Updated functional httpd redirect in `fedorahosted-redirects.conf` to point legacy ticket URLs to the new `/issues/` endpoint. - Corrected raw attachment URLs for survey banners in Mailman3 and Noggin HTML templates. - Performed a repository-wide search-and-replace to fix broken Forge ticket references in comments. - Removed trailing whitespace/newlines in a few files to resolve existing `yamllint` warnings. - **Impact:** httpd (redirects), mailman3 (templates), noggin (templates), ansible roles (documentation/comments) - **Risk Level:** 🟢 Low - The vast majority of changes are isolated to code comments. The functional changes (HTML templates and Apache redirects) are straightforward string replacements that have been validated against the new Forge URL structure. ### Detailed Code Review The implementation correctly aligns with the conclusions discussed during the PR review process. The broken attachment links have been successfully reconstructed using the proper `fedora-infrastructure/issue/raw/files/` path format. The repository-wide updates to the documentation comments accurately implement the `/issues/` path injection. The update to `files/httpd/fedorahosted-redirects.conf` correctly preserves the regex capture group `$1` while safely updating the destination URL. Furthermore, the minor whitespace removals nicely satisfy `yamllint` without bleeding into broader linting scopes, which honors the reviewer's guidance that full linting is not a blocker here. No critical issues or bugs were identified in this review. ### ✅ Summary - **Overall Assessment:** The changes successfully restore the broken breadcrumbs and functional links with no identified security, performance, or logic issues. --- 🤖 **AI Code Review** | Generated with [ai-code-review](https://gitlab.com/redhat/edge/ci-cd/ai-code-review) | **Model:** `gemini-3.1-pro-preview` ⚠️ *AI-generated suggestions may be incorrect. Verify before applying. Not a replacement for human review.*
kevin commented 2026-03-11 21:09:27 +00:00
Owner
Copy link

Merging this now. Thanks for the pull request!

Merging this now. Thanks for the pull request!
kevin merged commit aedf43d1f3 into main 2026-03-11 21:09:38 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
kevin
Labels
Clear labels   
ai-review-please

label for requesting AI code review

  
freeze-break-request

   
post-freeze
  
Backlog Status
Needs Review
Work items that have been created or updated but need review, refinement, or approval before they can be considered ready for sprint planning.

  
Backlog Status
Ready
Work items that have been reviewed, refined, and are ready to be committed to a sprint. These items have clear requirements and can be worked on immediately when capacity is available.

  
chore

Work that needs to be done but doesn't add new functionality or fix bugs. Maintenance tasks that keep the system running smoothly and the codebase clean.

  
documentation

Work focused on creating, updating, or improving documentation for users, developers, or system administrators.

  
points
01
A task that is simple, small, and has very little uncertainty. It should be easy enough for any team member to pick up and complete quickly, without a lot of discussion or research.

  
points
02
This is a task that is slightly more complex or larger than a "1." It might involve two or three simple steps, but the outcome is still very clear and there's little uncertainty.

  
points
03
Medium-sized task with some noticeable complexity. It might require a bit more thought or collaboration. The steps are well-defined, but it's not a trivial change.

  
points
05
A significant piece of work. It has more complexity and a higher degree of uncertainty than smaller tasks. It might require some research, a design discussion, or collaboration across multiple teams.

  
points
08
Complex task with a lot of uncertainty. It's often the largest size that a team will consider for a single sprint. It likely requires a detailed breakdown and multiple team members to complete.

  
points
13
Any task that feels like it's a "13" or more is considered an Epic. These are too large and uncertain to be worked on in a single sprint and should be broken down.

  
Priority
High
This is for work that is critical and needs to be addressed in the next sprint. It's often for urgent bugs, important features, or a major piece of technical debt that is blocking other work.

  
Priority
Low
This is for work that is good to do but not urgent. It's a candidate for being worked on when there's extra time or when it rises in importance. It can stay in the backlog for a longer period.

  
Priority
Medium
This is for important work that should be done soon, but isn't as urgent as a high-priority item. It will likely be considered for the next 1-2 sprints.

  
Sprint Status
Blocked
Work items that cannot progress due to external dependencies, blockers, or issues that need resolution.

  
Sprint Status
Done
Work items that have been completed, reviewed, and integrated. No further work is needed within the current sprint.

  
Sprint Status
In Progress
Work items currently being worked on by a team member. Active development, research, or implementation is happening.

  
Sprint Status
Review
Work items that are complete but need review, testing, or approval before being marked as done.

  
Sprint Status
To Do
Work items that are committed to the sprint but haven't been started yet. These items are ready to be picked up by team members.

  
Technical Debt

Work that addresses shortcuts, workarounds, or suboptimal implementations that were done previously to meet deadlines. These items improve code quality, maintainability, or performance without adding new features.

  
Work Item
Bug
Issues where the system is not working as intended or designed. Bugs represent deviations from expected behavior.

  
Work Item
Epic
Large initiatives that are broken down into multiple smaller work items (user stories, tasks, bugs). Epics represent significant features or projects that span multiple sprints.

  
Work Item
Spike
Time-boxed research, investigation, or proof-of-concept work to reduce uncertainty or explore solutions. Spikes help inform future development decisions.

  
Work Item
Task
Used to break down larger user stories into smaller, manageable implementation pieces. They focus on the specific technical steps needed to deliver the user story's value.

  
Work Item
User Story
User-facing features or functionality that can be framed from a user perspective, describing what someone wants to accomplish and why.

No labels
ai-review-please
freeze-break-request
post-freeze
Backlog Status
Needs Review
Backlog Status
Ready
chore
documentation
points
01
points
02
points
03
points
05
points
08
points
13
Priority
High
Priority
Low
Priority
Medium
Sprint Status
Blocked
Sprint Status
Done
Sprint Status
In Progress
Sprint Status
Review
Sprint Status
To Do
Technical Debt
Work Item
Bug
Work Item
Epic
Work Item
Spike
Work Item
Task
Work Item
User Story
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
infra/ansible!3174
No description provided.