Forge staging: Add 'fedora' label to all fedora-N runners #3386

Open
adamwill wants to merge 1 commit from adamwill/ansible:forge-stg-runners-label-fedora into main
Member

There are six global 'fedora' runners in staging forgejo, each with a
different label. This makes it awkward to create workflows as you have to
arbitrarily tie them to a single runner for no very good reason. If we
give them all the 'fedora' label you can just set your workflow to run on
'fedora' and it will run on any available runner.

Also, at least for the quality org, our prod runners have the 'fedora' label,
so if the global staging runners have the same label, we can reuse workflows
between staging and prod.

Signed-off-by: Adam Williamson awilliam@redhat.com

There are six global 'fedora' runners in staging forgejo, each with a different label. This makes it awkward to create workflows as you have to arbitrarily tie them to a single runner for no very good reason. If we give them all the 'fedora' label you can just set your workflow to run on 'fedora' and it will run on any available runner. Also, at least for the quality org, our prod runners have the 'fedora' label, so if the global staging runners have the same label, we can reuse workflows between staging and prod. Signed-off-by: Adam Williamson <awilliam@redhat.com>
Forge staging: Add 'fedora' label to all fedora-N runners
All checks were successful
Linter / yamllint (pull_request) Successful in 27s
Linter / ansible-lint (pull_request) Successful in 1m4s
ef3f2deca7
There are six global 'fedora' runners in staging forgejo, each with a
different label. This makes it awkward to create workflows as you have to
arbitrarily tie them to a single runner for no very good reason. If we
give them all the 'fedora' label you can just set your workflow to run on
'fedora' and it will run on any available runner.

Also, at least for the quality org, our prod runners have the 'fedora' label,
so if the global staging runners have the same label, we can reuse workflows
between staging and prod.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
@ -4,3 +4,4 @@
labels:
- fedora-1
- fedora
image: code.forgejo.org/forgejo/runner:11
Contributor

Does this mean we're getting Debian 11 by default? Could we also change this to receive the latest stable Fedora image by default? It would make sense to have the label fedora mean we're getting a Fedora container...

Does this mean we're getting Debian 11 by default? Could we also change this to receive the latest stable Fedora image by default? It would make sense to have the label `fedora` mean we're getting a Fedora container...
Contributor

Note that this has scope: global, so these 6 runners are shared across the whole staging Forge (I finally understand the setup!). If Infra really wants to default to Debian for some reason, perhaps we could get a scope: quality host with a Fedora container instead?

Note that this has `scope: global`, so these 6 runners are shared across the whole staging Forge (I finally understand the setup!). If Infra really wants to default to Debian for some reason, perhaps we could get a `scope: quality` host with a Fedora container instead?
Author
Member

@kparal wrote in #3386 (comment):

Does this mean we're getting Debian 11 by default?

Yes.

Could we also change this to receive the latest stable Fedora image by default? It would make sense to have the label fedora mean we're getting a Fedora container...

See forge/forge#332 . We at least need an image that has nodejs in it, or else the checkout action (used by the vast majority of workflows) doesn't work. That makes it more complicated.

@kparal wrote in https://forge.fedoraproject.org/infra/ansible/pulls/3386#issuecomment-794971: > Does this mean we're getting Debian 11 by default? Yes. > Could we also change this to receive the latest stable Fedora image by default? It would make sense to have the label `fedora` mean we're getting a Fedora container... See https://forge.fedoraproject.org/forge/forge/issues/332 . We at least need an image that has nodejs in it, or else the checkout action (used by the vast majority of workflows) doesn't work. That makes it more complicated.
All checks were successful
Linter / yamllint (pull_request) Successful in 27s
Linter / ansible-lint (pull_request) Successful in 1m4s
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u forge-stg-runners-label-fedora:adamwill-forge-stg-runners-label-fedora
git switch adamwill-forge-stg-runners-label-fedora

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff adamwill-forge-stg-runners-label-fedora
git switch adamwill-forge-stg-runners-label-fedora
git rebase main
git switch main
git merge --ff-only adamwill-forge-stg-runners-label-fedora
git switch adamwill-forge-stg-runners-label-fedora
git rebase main
git switch main
git merge --no-ff adamwill-forge-stg-runners-label-fedora
git switch main
git merge --squash adamwill-forge-stg-runners-label-fedora
git switch main
git merge --ff-only adamwill-forge-stg-runners-label-fedora
git switch main
git merge adamwill-forge-stg-runners-label-fedora
git push origin main
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
infra/ansible!3386
No description provided.