infra/ansible
23
8
Fork 60
Code Pull requests 17 Activity Actions 6

Forge staging: Add 'fedora' label to all fedora-N runners #3386

Merged
adamwill merged 1 commit from adamwill/ansible:forge-stg-runners-label-fedora into main 2026-06-23 11:38:30 +00:00
Conversation 3 Commits 1 Files changed 6 +6
adamwill commented 2026-06-02 16:35:17 +00:00
Member
Copy link

There are six global 'fedora' runners in staging forgejo, each with a
different label. This makes it awkward to create workflows as you have to
arbitrarily tie them to a single runner for no very good reason. If we
give them all the 'fedora' label you can just set your workflow to run on
'fedora' and it will run on any available runner.

Also, at least for the quality org, our prod runners have the 'fedora' label,
so if the global staging runners have the same label, we can reuse workflows
between staging and prod.

Signed-off-by: Adam Williamson awilliam@redhat.com

There are six global 'fedora' runners in staging forgejo, each with a different label. This makes it awkward to create workflows as you have to arbitrarily tie them to a single runner for no very good reason. If we give them all the 'fedora' label you can just set your workflow to run on 'fedora' and it will run on any available runner. Also, at least for the quality org, our prod runners have the 'fedora' label, so if the global staging runners have the same label, we can reuse workflows between staging and prod. Signed-off-by: Adam Williamson <awilliam@redhat.com>
Forge staging: Add 'fedora' label to all fedora-N runners
All checks were successful
Linter / yamllint (pull_request) Successful in 27s
Details
Linter / ansible-lint (pull_request) Successful in 1m4s
Details
ef3f2deca7 
There are six global 'fedora' runners in staging forgejo, each with a
different label. This makes it awkward to create workflows as you have to
arbitrarily tie them to a single runner for no very good reason. If we
give them all the 'fedora' label you can just set your workflow to run on
'fedora' and it will run on any available runner.

Also, at least for the quality org, our prod runners have the 'fedora' label,
so if the global staging runners have the same label, we can reuse workflows
between staging and prod.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
kparal reviewed 2026-06-03 08:00:40 +00:00
roles/openshift-apps/forgejo/runners/staging/fedora-1.yml
@ -4,3 +4,4 @@
labels:
- fedora-1
- fedora
image: code.forgejo.org/forgejo/runner:11
kparal commented 2026-06-03 08:00:40 +00:00
Contributor
Copy link

Does this mean we're getting Debian 11 by default? Could we also change this to receive the latest stable Fedora image by default? It would make sense to have the label fedora mean we're getting a Fedora container...

Does this mean we're getting Debian 11 by default? Could we also change this to receive the latest stable Fedora image by default? It would make sense to have the label `fedora` mean we're getting a Fedora container...
kparal commented 2026-06-03 08:06:41 +00:00
Contributor
Copy link

Note that this has scope: global, so these 6 runners are shared across the whole staging Forge (I finally understand the setup!). If Infra really wants to default to Debian for some reason, perhaps we could get a scope: quality host with a Fedora container instead?

Note that this has `scope: global`, so these 6 runners are shared across the whole staging Forge (I finally understand the setup!). If Infra really wants to default to Debian for some reason, perhaps we could get a `scope: quality` host with a Fedora container instead?
adamwill commented 2026-06-03 18:15:05 +00:00
Author
Member
Copy link

@kparal wrote in #3386 (comment):

Does this mean we're getting Debian 11 by default?

Yes.

Could we also change this to receive the latest stable Fedora image by default? It would make sense to have the label fedora mean we're getting a Fedora container...

See forge/forge#332 . We at least need an image that has nodejs in it, or else the checkout action (used by the vast majority of workflows) doesn't work. That makes it more complicated.

@kparal wrote in https://forge.fedoraproject.org/infra/ansible/pulls/3386#issuecomment-794971: > Does this mean we're getting Debian 11 by default? Yes. > Could we also change this to receive the latest stable Fedora image by default? It would make sense to have the label `fedora` mean we're getting a Fedora container... See https://forge.fedoraproject.org/forge/forge/issues/332 . We at least need an image that has nodejs in it, or else the checkout action (used by the vast majority of workflows) doesn't work. That makes it more complicated.
lenkaseg commented 2026-06-21 23:27:53 +00:00
Member
Copy link

The nodejs can be also installed by the action itself, if you insist on using use fedora based container.

@adamwill wrote in #3386 (comment):

Does this mean we're getting Debian 11 by default?

You're getting node:22-bookworm as a default, so Debiain 12. The runner:11 refers to the base forgejo runner itself, not to the runtime image.

The nodejs can be also installed by the action itself, if you insist on using use fedora based container. @adamwill wrote in https://forge.fedoraproject.org/infra/ansible/pulls/3386#issuecomment-795163: > Does this mean we're getting Debian 11 by default? You're getting `node:22-bookworm` as a default, so Debiain 12. The `runner:11` refers to the base forgejo runner itself, not to the runtime image.
adamwill commented 2026-06-23 11:38:23 +00:00
Author
Member
Copy link

The nodejs can be also installed by the action itself, if you insist on using use fedora based container.

Sure, but it seemed wildly inefficient to me at the time. Still, with the caching stuff they added in v14 or whatever, it might not be too bad?

> The nodejs can be also installed by the action itself, if you insist on using use fedora based container. Sure, but it seemed wildly inefficient to me at the time. Still, with the caching stuff they added in v14 or whatever, it might not be too bad?
lenkaseg commented 2026-06-21 23:44:39 +00:00
Member
Copy link

LGTM, I see no reason why to not have them under one label, except perhaps for debugging. Staging is meant for testing stuff and searching for logs across 6 different services might be harder.

CC @humaton

LGTM, I see no reason why to not have them under one label, except perhaps for debugging. Staging is meant for testing stuff and searching for logs across 6 different services might be harder. CC @humaton
lenkaseg approved these changes 2026-06-22 15:24:23 +00:00
adamwill deleted branch forge-stg-runners-label-fedora 2026-06-23 11:38:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
lenkaseg
Labels
Clear labels   
ai-review-please
label for requesting AI code review

  
freeze-break-request

   
post-freeze
  
Backlog Status
Needs Review
 Work items that have been created or updated but need review, refinement, or approval before they can be considered ready for sprint planning.

  
Backlog Status
Ready
 Work items that have been reviewed, refined, and are ready to be committed to a sprint. These items have clear requirements and can be worked on immediately when capacity is available.

  
chore
Work that needs to be done but doesn't add new functionality or fix bugs. Maintenance tasks that keep the system running smoothly and the codebase clean.

  
documentation
Work focused on creating, updating, or improving documentation for users, developers, or system administrators.

  
points
01
 A task that is simple, small, and has very little uncertainty. It should be easy enough for any team member to pick up and complete quickly, without a lot of discussion or research.

  
points
02
 This is a task that is slightly more complex or larger than a "1." It might involve two or three simple steps, but the outcome is still very clear and there's little uncertainty.

  
points
03
 Medium-sized task with some noticeable complexity. It might require a bit more thought or collaboration. The steps are well-defined, but it's not a trivial change.

  
points
05
 A significant piece of work. It has more complexity and a higher degree of uncertainty than smaller tasks. It might require some research, a design discussion, or collaboration across multiple teams.

  
points
08
 Complex task with a lot of uncertainty. It's often the largest size that a team will consider for a single sprint. It likely requires a detailed breakdown and multiple team members to complete.

  
points
13
 Any task that feels like it's a "13" or more is considered an Epic. These are too large and uncertain to be worked on in a single sprint and should be broken down.

  
Priority
High
 This is for work that is critical and needs to be addressed in the next sprint. It's often for urgent bugs, important features, or a major piece of technical debt that is blocking other work.

  
Priority
Low
 This is for work that is good to do but not urgent. It's a candidate for being worked on when there's extra time or when it rises in importance. It can stay in the backlog for a longer period.

  
Priority
Medium
 This is for important work that should be done soon, but isn't as urgent as a high-priority item. It will likely be considered for the next 1-2 sprints.

  
Sprint Status
Blocked
 Work items that cannot progress due to external dependencies, blockers, or issues that need resolution.

  
Sprint Status
Done
 Work items that have been completed, reviewed, and integrated. No further work is needed within the current sprint.

  
Sprint Status
In Progress
 Work items currently being worked on by a team member. Active development, research, or implementation is happening.

  
Sprint Status
Review
 Work items that are complete but need review, testing, or approval before being marked as done.

  
Sprint Status
To Do
 Work items that are committed to the sprint but haven't been started yet. These items are ready to be picked up by team members.

  
Technical Debt
Work that addresses shortcuts, workarounds, or suboptimal implementations that were done previously to meet deadlines. These items improve code quality, maintainability, or performance without adding new features.

  
Work Item
Bug
 Issues where the system is not working as intended or designed. Bugs represent deviations from expected behavior.

  
Work Item
Epic
 Large initiatives that are broken down into multiple smaller work items (user stories, tasks, bugs). Epics represent significant features or projects that span multiple sprints.

  
Work Item
Spike
 Time-boxed research, investigation, or proof-of-concept work to reduce uncertainty or explore solutions. Spikes help inform future development decisions.

  
Work Item
Task
 Used to break down larger user stories into smaller, manageable implementation pieces. They focus on the specific technical steps needed to deliver the user story's value.

  
Work Item
User Story
 User-facing features or functionality that can be framed from a user perspective, describing what someone wants to accomplish and why.

No labels
ai-review-please
freeze-break-request
post-freeze
Backlog Status
Needs Review
Backlog Status
Ready
chore
documentation
points
01
points
02
points
03
points
05
points
08
points
13
Priority
High
Priority
Low
Priority
Medium
Sprint Status
Blocked
Sprint Status
Done
Sprint Status
In Progress
Sprint Status
Review
Sprint Status
To Do
Technical Debt
Work Item
Bug
Work Item
Epic
Work Item
Spike
Work Item
Task
Work Item
User Story
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
infra/ansible!3386
No description provided.