infra/ansible
23
7
Fork 53
Code Pull requests 11 Activity Actions

pagure-stg-ro01: add new instance for readonly pagure in stg ( ticket 13351 ) #3388

Merged
kevin merged 1 commit from kevin/ansible:pagure-stg-ro01 into main 2026-06-03 19:55:24 +00:00
Conversation 2 Commits 1 Files changed 4 +113
kevin commented 2026-06-03 00:23:55 +00:00
Owner
Copy link

For infra/tickets#13351
This makes a staging rhel10 vm thats just the same size / place
as pagure-stg01.

It still needs external ip's and nat in from those, but this should be
enough to install it and start setting things up.

Signed-off-by: Kevin Fenzi kevin@scrye.com

For https://forge.fedoraproject.org/infra/tickets/issues/13351 This makes a staging rhel10 vm thats just the same size / place as pagure-stg01. It still needs external ip's and nat in from those, but this should be enough to install it and start setting things up. Signed-off-by: Kevin Fenzi <kevin@scrye.com>
pagure-stg-ro01: add new instance for readonly pagure in stg ( ticket 13351 )
Some checks failed
Linter / yamllint (pull_request) Successful in 26s
Details
Linter / ansible-lint (pull_request) Failing after 1m1s
Details
AI Code Review / ai-review (pull_request_target) Successful in 21s
Details
d2b6e0f58b 
For infra/tickets#13351
This makes a staging rhel10 vm thats just the same size / place
as pagure-stg01.

It still needs external ip's and nat in from those, but this should be
enough to install it and start setting things up.

Signed-off-by: Kevin Fenzi <kevin@scrye.com>
forgejo-actions commented 2026-06-03 00:25:44 +00:00
Copy link

AI Code Review

Detailed Code Review

The setup looks well-structured and aligns with standard provisioning patterns for staging environments. However, there is a critical undefined variable bug in the host variables file related to the network configuration that will cause the Ansible playbook to fail during templating.

📂 File Reviews

📄 `inventory/host_vars/pagure-stg-ro01.fedoraproject.org` - Adds host-specific configuration including networking and Postgres DB sizing.
  • Critical [Bug]: The variable eth0_ipv4_nm is used in the network_connections template but is never defined. Instead, eth0_nm is defined with a dotted decimal subnet mask (255.255.255.0). The template expects a CIDR notation variable (eth0_ipv4_nm) to construct the IP/Mask string 10.16.179.80/24. This will cause a templating failure.
    • Suggestion: Rename eth0_nm to eth0_ipv4_nm and change its value to the CIDR prefix length 24 instead of 255.255.255.0.
--- a/inventory/host_vars/pagure-stg-ro01.fedoraproject.org
+++ b/inventory/host_vars/pagure-stg-ro01.fedoraproject.org
@@ -12,7 +12,7 @@
 eth0_ipv6_gw: "2620:52:6:1161::1"
 eth0_ipv6_ip: "2620:52:6:1161::33"
 eth0_ipv6_nm: 64
-eth0_nm: 255.255.255.0
+eth0_ipv4_nm: 24
 has_ipv6: yes

✅ Summary

  • Overall Assessment: The network configuration contains an undefined variable bug that will block deployment and must be fixed.
  • Priority Issues:
    • Fix undefined eth0_ipv4_nm variable and replace eth0_nm with CIDR notation in host_vars.

🤖 AI Code Review | Generated with ai-code-review | Model: gemini-3.1-pro-preview

⚠️ AI-generated suggestions may be incorrect. Verify before applying. Not a replacement for human review.

## AI Code Review ### Detailed Code Review The setup looks well-structured and aligns with standard provisioning patterns for staging environments. However, there is a critical undefined variable bug in the host variables file related to the network configuration that will cause the Ansible playbook to fail during templating. #### 📂 File Reviews <details> <summary><strong>📄 `inventory/host_vars/pagure-stg-ro01.fedoraproject.org`</strong> - Adds host-specific configuration including networking and Postgres DB sizing.</summary> - **Critical** [Bug]: The variable `eth0_ipv4_nm` is used in the `network_connections` template but is never defined. Instead, `eth0_nm` is defined with a dotted decimal subnet mask (`255.255.255.0`). The template expects a CIDR notation variable (`eth0_ipv4_nm`) to construct the IP/Mask string `10.16.179.80/24`. This will cause a templating failure. - *Suggestion:* Rename `eth0_nm` to `eth0_ipv4_nm` and change its value to the CIDR prefix length `24` instead of `255.255.255.0`. ```` --- a/inventory/host_vars/pagure-stg-ro01.fedoraproject.org +++ b/inventory/host_vars/pagure-stg-ro01.fedoraproject.org @@ -12,7 +12,7 @@ eth0_ipv6_gw: "2620:52:6:1161::1" eth0_ipv6_ip: "2620:52:6:1161::33" eth0_ipv6_nm: 64 -eth0_nm: 255.255.255.0 +eth0_ipv4_nm: 24 has_ipv6: yes ```` </details> ### ✅ Summary - **Overall Assessment:** The network configuration contains an undefined variable bug that will block deployment and must be fixed. - **Priority Issues:** - Fix undefined `eth0_ipv4_nm` variable and replace `eth0_nm` with CIDR notation in host_vars. --- 🤖 **AI Code Review** | Generated with [ai-code-review](https://gitlab.com/redhat/edge/ci-cd/ai-code-review) | **Model:** `gemini-3.1-pro-preview` ⚠️ *AI-generated suggestions may be incorrect. Verify before applying. Not a replacement for human review.*
kevin commented 2026-06-03 00:30:03 +00:00
Author
Owner
Copy link

eth0_ipv4_nm is defined in inventory/group_vars/all to a default of 24. ;)

eth0_ipv4_nm is defined in inventory/group_vars/all to a default of 24. ;)
kevin merged commit 52ac6c7ec6 into main 2026-06-03 19:55:24 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
ai-review-please
label for requesting AI code review

  
freeze-break-request

   
post-freeze
  
Backlog Status
Needs Review
 Work items that have been created or updated but need review, refinement, or approval before they can be considered ready for sprint planning.

  
Backlog Status
Ready
 Work items that have been reviewed, refined, and are ready to be committed to a sprint. These items have clear requirements and can be worked on immediately when capacity is available.

  
chore
Work that needs to be done but doesn't add new functionality or fix bugs. Maintenance tasks that keep the system running smoothly and the codebase clean.

  
documentation
Work focused on creating, updating, or improving documentation for users, developers, or system administrators.

  
points
01
 A task that is simple, small, and has very little uncertainty. It should be easy enough for any team member to pick up and complete quickly, without a lot of discussion or research.

  
points
02
 This is a task that is slightly more complex or larger than a "1." It might involve two or three simple steps, but the outcome is still very clear and there's little uncertainty.

  
points
03
 Medium-sized task with some noticeable complexity. It might require a bit more thought or collaboration. The steps are well-defined, but it's not a trivial change.

  
points
05
 A significant piece of work. It has more complexity and a higher degree of uncertainty than smaller tasks. It might require some research, a design discussion, or collaboration across multiple teams.

  
points
08
 Complex task with a lot of uncertainty. It's often the largest size that a team will consider for a single sprint. It likely requires a detailed breakdown and multiple team members to complete.

  
points
13
 Any task that feels like it's a "13" or more is considered an Epic. These are too large and uncertain to be worked on in a single sprint and should be broken down.

  
Priority
High
 This is for work that is critical and needs to be addressed in the next sprint. It's often for urgent bugs, important features, or a major piece of technical debt that is blocking other work.

  
Priority
Low
 This is for work that is good to do but not urgent. It's a candidate for being worked on when there's extra time or when it rises in importance. It can stay in the backlog for a longer period.

  
Priority
Medium
 This is for important work that should be done soon, but isn't as urgent as a high-priority item. It will likely be considered for the next 1-2 sprints.

  
Sprint Status
Blocked
 Work items that cannot progress due to external dependencies, blockers, or issues that need resolution.

  
Sprint Status
Done
 Work items that have been completed, reviewed, and integrated. No further work is needed within the current sprint.

  
Sprint Status
In Progress
 Work items currently being worked on by a team member. Active development, research, or implementation is happening.

  
Sprint Status
Review
 Work items that are complete but need review, testing, or approval before being marked as done.

  
Sprint Status
To Do
 Work items that are committed to the sprint but haven't been started yet. These items are ready to be picked up by team members.

  
Technical Debt
Work that addresses shortcuts, workarounds, or suboptimal implementations that were done previously to meet deadlines. These items improve code quality, maintainability, or performance without adding new features.

  
Work Item
Bug
 Issues where the system is not working as intended or designed. Bugs represent deviations from expected behavior.

  
Work Item
Epic
 Large initiatives that are broken down into multiple smaller work items (user stories, tasks, bugs). Epics represent significant features or projects that span multiple sprints.

  
Work Item
Spike
 Time-boxed research, investigation, or proof-of-concept work to reduce uncertainty or explore solutions. Spikes help inform future development decisions.

  
Work Item
Task
 Used to break down larger user stories into smaller, manageable implementation pieces. They focus on the specific technical steps needed to deliver the user story's value.

  
Work Item
User Story
 User-facing features or functionality that can be framed from a user perspective, describing what someone wants to accomplish and why.

No labels
ai-review-please
freeze-break-request
post-freeze
Backlog Status
Needs Review
Backlog Status
Ready
chore
documentation
points
01
points
02
points
03
points
05
points
08
points
13
Priority
High
Priority
Low
Priority
Medium
Sprint Status
Blocked
Sprint Status
Done
Sprint Status
In Progress
Sprint Status
Review
Sprint Status
To Do
Technical Debt
Work Item
Bug
Work Item
Epic
Work Item
Spike
Work Item
Task
Work Item
User Story
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
infra/ansible!3388
No description provided.