infra/ansible
22
8
Fork 57
Code Pull requests 7 Activity Actions

feat(openshift): add restart for openscanhub + reusable role #3429

Merged
kevin merged 3 commits from smoliicek/ansible:add-restart-osh into main 2026-06-23 19:30:23 +00:00
Conversation 2 Commits 3 Files changed 3 +59 -2
smoliicek commented 2026-06-19 07:07:42 +00:00
Member
Copy link

this commit adds a reusable role for restarting / rebuilding ocp stuff.
currently added this to playbooks/openshift-apps/openscanhub.yml, since it was referenced in infra/tickets#11884

not sure if i should add it to the other playbooks too, or no

Assisted-by: gpt-5.5 in Codex
Signed-off-by: Vít Smolík me@smoliicek.cz

this commit adds a reusable role for restarting / rebuilding ocp stuff. currently added this to playbooks/openshift-apps/openscanhub.yml, since it was referenced in https://forge.fedoraproject.org/infra/tickets/issues/11884 not sure if i should add it to the other playbooks too, or no Assisted-by: gpt-5.5 in Codex Signed-off-by: Vít Smolík <me@smoliicek.cz>
feat(openshift): add restart for openscanhub + reusable role
Some checks failed
AI Code Review / ai-review (pull_request_target) Successful in 13s
Details
Linter / yamllint (pull_request) Successful in 46s
Details
Linter / ansible-lint (pull_request) Failing after 2m10s
Details
be038d745f
 
Assisted-by: gpt-5.5 in Codex
Signed-off-by: Vít Smolík <me@smoliicek.cz>
forgejo-actions commented 2026-06-19 07:08:01 +00:00
Copy link

AI Code Review

Detailed Code Review

The changes introduce a generic OpenShift app-actions role meant to handle builds and rollouts (restarts) conditionally based on provided tags. The role uses never tags coupled with explicit build/rebuild or restart/rollout tags to only execute these actions when intentionally requested. The implementation correctly loops over defined resources and validates that app_actions_app is set before doing so. Integrating it into openscanhub.yml solves the immediate infrastructure need to cleanly restart its deployments. The code follows standard Ansible practices for include_role loops.

📂 File Reviews

📄 `roles/openshift/app-actions/tasks/main.yml` - Main tasks file for the app-actions role handling conditional builds and rollouts.
  • Minor [Suggestion]: It is good practice to provide customized failure messages for ansible.builtin.assert to make debugging easier if the role is invoked incorrectly.
    • Suggestion: Add fail_msg to the assert tasks.
  - name: Validate app_actions_app for builds
    ansible.builtin.assert:
      that:
      - app_actions_app is defined
      - app_actions_app | length > 0
      fail_msg: "app_actions_app must be defined and not empty"
      quiet: true

✅ Summary

  • Overall Assessment: No critical issues identified. The role appears to correctly implement the desired tag-driven deployment and build actions.
  • Minor Suggestions:
    • Add explicit fail_msg to assert statements for better operator experience when debugging missing variables.
    • Consider eventually applying this role to other apps if they have the same requirement to trigger manual restarts via tag.

🤖 AI Code Review | Generated with ai-code-review | Model: gemini-3.1-pro-preview

⚠️ AI-generated suggestions may be incorrect. Verify before applying. Not a replacement for human review.

## AI Code Review ### Detailed Code Review The changes introduce a generic OpenShift app-actions role meant to handle builds and rollouts (restarts) conditionally based on provided tags. The role uses `never` tags coupled with explicit `build`/`rebuild` or `restart`/`rollout` tags to only execute these actions when intentionally requested. The implementation correctly loops over defined resources and validates that `app_actions_app` is set before doing so. Integrating it into `openscanhub.yml` solves the immediate infrastructure need to cleanly restart its deployments. The code follows standard Ansible practices for include_role loops. #### 📂 File Reviews <details> <summary><strong>📄 `roles/openshift/app-actions/tasks/main.yml`</strong> - Main tasks file for the app-actions role handling conditional builds and rollouts.</summary> - **Minor** [Suggestion]: It is good practice to provide customized failure messages for `ansible.builtin.assert` to make debugging easier if the role is invoked incorrectly. - *Suggestion:* Add `fail_msg` to the assert tasks. ```` - name: Validate app_actions_app for builds ansible.builtin.assert: that: - app_actions_app is defined - app_actions_app | length > 0 fail_msg: "app_actions_app must be defined and not empty" quiet: true ```` </details> ### ✅ Summary - **Overall Assessment:** No critical issues identified. The role appears to correctly implement the desired tag-driven deployment and build actions. - **Minor Suggestions:** - Add explicit `fail_msg` to assert statements for better operator experience when debugging missing variables. - Consider eventually applying this role to other apps if they have the same requirement to trigger manual restarts via tag. --- 🤖 **AI Code Review** | Generated with [ai-code-review](https://gitlab.com/redhat/edge/ci-cd/ai-code-review) | **Model:** `gemini-3.1-pro-preview` ⚠️ *AI-generated suggestions may be incorrect. Verify before applying. Not a replacement for human review.*
fix lint errors
Some checks failed
Linter / yamllint (pull_request) Successful in 28s
Details
Linter / ansible-lint (pull_request) Failing after 1m26s
Details
51a7c692e9
 
Signed-off-by: Vít Smolík <me@smoliicek.cz>
add fail_msg to assert in roles/openshift/app-actions
Some checks failed
Linter / yamllint (pull_request) Successful in 28s
Details
Linter / ansible-lint (pull_request) Failing after 1m13s
Details
8ce1258603
 
Signed-off-by: Vít Smolík <me@smoliicek.cz>
kevin commented 2026-06-23 19:30:15 +00:00
Owner
Copy link

So, this looks fine to me. Lets merge it.

As to other apps, yes, we could convert them all... either as we do other things, or all at once. If you want to do a pr to move the rest that would be fine with me. ;)

So, this looks fine to me. Lets merge it. As to other apps, yes, we could convert them all... either as we do other things, or all at once. If you want to do a pr to move the rest that would be fine with me. ;)
kevin merged commit 6273dafdf2 into main 2026-06-23 19:30:23 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
ai-review-please
label for requesting AI code review

  
freeze-break-request

   
post-freeze
  
Backlog Status
Needs Review
 Work items that have been created or updated but need review, refinement, or approval before they can be considered ready for sprint planning.

  
Backlog Status
Ready
 Work items that have been reviewed, refined, and are ready to be committed to a sprint. These items have clear requirements and can be worked on immediately when capacity is available.

  
chore
Work that needs to be done but doesn't add new functionality or fix bugs. Maintenance tasks that keep the system running smoothly and the codebase clean.

  
documentation
Work focused on creating, updating, or improving documentation for users, developers, or system administrators.

  
points
01
 A task that is simple, small, and has very little uncertainty. It should be easy enough for any team member to pick up and complete quickly, without a lot of discussion or research.

  
points
02
 This is a task that is slightly more complex or larger than a "1." It might involve two or three simple steps, but the outcome is still very clear and there's little uncertainty.

  
points
03
 Medium-sized task with some noticeable complexity. It might require a bit more thought or collaboration. The steps are well-defined, but it's not a trivial change.

  
points
05
 A significant piece of work. It has more complexity and a higher degree of uncertainty than smaller tasks. It might require some research, a design discussion, or collaboration across multiple teams.

  
points
08
 Complex task with a lot of uncertainty. It's often the largest size that a team will consider for a single sprint. It likely requires a detailed breakdown and multiple team members to complete.

  
points
13
 Any task that feels like it's a "13" or more is considered an Epic. These are too large and uncertain to be worked on in a single sprint and should be broken down.

  
Priority
High
 This is for work that is critical and needs to be addressed in the next sprint. It's often for urgent bugs, important features, or a major piece of technical debt that is blocking other work.

  
Priority
Low
 This is for work that is good to do but not urgent. It's a candidate for being worked on when there's extra time or when it rises in importance. It can stay in the backlog for a longer period.

  
Priority
Medium
 This is for important work that should be done soon, but isn't as urgent as a high-priority item. It will likely be considered for the next 1-2 sprints.

  
Sprint Status
Blocked
 Work items that cannot progress due to external dependencies, blockers, or issues that need resolution.

  
Sprint Status
Done
 Work items that have been completed, reviewed, and integrated. No further work is needed within the current sprint.

  
Sprint Status
In Progress
 Work items currently being worked on by a team member. Active development, research, or implementation is happening.

  
Sprint Status
Review
 Work items that are complete but need review, testing, or approval before being marked as done.

  
Sprint Status
To Do
 Work items that are committed to the sprint but haven't been started yet. These items are ready to be picked up by team members.

  
Technical Debt
Work that addresses shortcuts, workarounds, or suboptimal implementations that were done previously to meet deadlines. These items improve code quality, maintainability, or performance without adding new features.

  
Work Item
Bug
 Issues where the system is not working as intended or designed. Bugs represent deviations from expected behavior.

  
Work Item
Epic
 Large initiatives that are broken down into multiple smaller work items (user stories, tasks, bugs). Epics represent significant features or projects that span multiple sprints.

  
Work Item
Spike
 Time-boxed research, investigation, or proof-of-concept work to reduce uncertainty or explore solutions. Spikes help inform future development decisions.

  
Work Item
Task
 Used to break down larger user stories into smaller, manageable implementation pieces. They focus on the specific technical steps needed to deliver the user story's value.

  
Work Item
User Story
 User-facing features or functionality that can be framed from a user perspective, describing what someone wants to accomplish and why.

No labels
ai-review-please
freeze-break-request
post-freeze
Backlog Status
Needs Review
Backlog Status
Ready
chore
documentation
points
01
points
02
points
03
points
05
points
08
points
13
Priority
High
Priority
Low
Priority
Medium
Sprint Status
Blocked
Sprint Status
Done
Sprint Status
In Progress
Sprint Status
Review
Sprint Status
To Do
Technical Debt
Work Item
Bug
Work Item
Epic
Work Item
Spike
Work Item
Task
Work Item
User Story
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
infra/ansible!3429
No description provided.