Add yselkowitz to list to notify when ELN builds fail #11833

Open
opened 2024-03-13 12:36:59 +00:00 by sgallagh · 27 comments

Describe what you would like us to do:


Please add user @yselkowitz to the list of accounts in releng/failed-composes that receive an email notification when the ELN compose fails.

When do you need this to be done by? (YYYY/MM/DD)


When convenient, but preferably by 2024-05-30

# Describe what you would like us to do: ---- Please add user @yselkowitz to the list of accounts in `releng/failed-composes` that receive an email notification when the ELN compose fails. # When do you need this to be done by? (YYYY/MM/DD) ---- When convenient, but preferably by 2024-05-30
Member

Metadata Update from @jnsamyak:

  • Issue assigned to jnsamyak
**Metadata Update from @jnsamyak**: - Issue assigned to jnsamyak
Member

Hello @sgallagh!

Thanks to Kevin of course, I got the maintainers file, where can update this so to confirm details here's the concerning PR [1] for this which adds user "Yaakov Selkowitz" with fas "yselkowitz";
Once, I have a +1 on that, we can merge it, and hopefully all good!

[1] https://pagure.io/fedora-kickstarts/pull-request/1029

Hello @sgallagh! Thanks to Kevin of course, I got the maintainers file, where can update this so to confirm details here's the concerning PR [1] for this which adds user "Yaakov Selkowitz" with fas "yselkowitz"; Once, I have a +1 on that, we can merge it, and hopefully all good! [1] https://pagure.io/fedora-kickstarts/pull-request/1029
Member

Metadata Update from @jnsamyak:

  • Issue tagged with: low-gain, low-trouble, ops
**Metadata Update from @jnsamyak**: - Issue tagged with: low-gain, low-trouble, ops
Member

Metadata Update from @jnsamyak:

  • Issue priority set to: Waiting on Reporter (was: Needs Review)
**Metadata Update from @jnsamyak**: - Issue priority set to: Waiting on Reporter (was: Needs Review)
Owner

PR merged, this should be active now. ;)

Let us know if there's any problems with it.

PR merged, this should be active now. ;) Let us know if there's any problems with it.
Owner

Metadata Update from @kevin:

  • Issue close_status updated to: Fixed
  • Issue status updated to: Closed (was: Open)
**Metadata Update from @kevin**: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)

I'm still not getting notifications.

I'm still not getting notifications.
Author

Metadata Update from @sgallagh:

  • Issue status updated to: Open (was: Closed)
**Metadata Update from @sgallagh**: - Issue status updated to: Open (was: Closed)
Owner

This appears working now?

At least I see the right stuff in https://pagure.io/releng/failed-composes/issue/6788

Please reopen if there's still anything not right here.

This appears working now? At least I see the right stuff in https://pagure.io/releng/failed-composes/issue/6788 Please reopen if there's still anything not right here.
Owner

Metadata Update from @kevin:

  • Issue close_status updated to: Fixed
  • Issue status updated to: Closed (was: Open)
**Metadata Update from @kevin**: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Author

@yselkowitz is still not getting notified when ELN composes fail. He reports that he got no email from https://pagure.io/releng/failed-composes/issue/7278

@yselkowitz is still not getting notified when ELN composes fail. He reports that he got no email from https://pagure.io/releng/failed-composes/issue/7278
Author

Metadata Update from @sgallagh:

  • Issue status updated to: Open (was: Closed)
**Metadata Update from @sgallagh**: - Issue status updated to: Open (was: Closed)
Owner

I think this might be due to eln changing it's compose id from ELN to eln.

See: https://pagure.io/releng/compose-tracker/blob/main/f/compose_tracker.py#_246

if we lower case that it migth work?

I think this might be due to eln changing it's compose id from ELN to eln. See: https://pagure.io/releng/compose-tracker/blob/main/f/compose_tracker.py#_246 if we lower case that it migth work?
Author

Composes are being detected as failed just fine (https://stg.pagure.io/releng/failed-composes/issue/4670 was opened last night for example), but @yselkowitz is not getting notified.

Composes are being detected as failed just fine (https://stg.pagure.io/releng/failed-composes/issue/4670 was opened last night for example), but @yselkowitz is not getting notified.
Owner

Ah yeah, the problem is in it's logic. It would currently only notify if there was a specific section that failed, but since thats not the case it doesn't do anything.

I'll see if I can find someone to fix it up.

Ah yeah, the problem is in it's logic. It would currently only notify if there was a specific section that failed, but since thats not the case it doesn't do anything. I'll see if I can find someone to fix it up.
Author

Ah yeah, the problem is in it's logic. It would currently only notify if there was a specific section that failed, but since thats not the case it doesn't do anything.

I'll see if I can find someone to fix it up.

This is still broken. Can we get this looked at, please? I'm going to be transitioning to a new role in the new year and Yaakov will be taking over full-time responsibility for this.

> Ah yeah, the problem is in it's logic. It would currently only notify if there was a specific section that failed, but since thats not the case it doesn't do anything. > > I'll see if I can find someone to fix it up. This is still broken. Can we get this looked at, please? I'm going to be transitioning to a new role in the new year and Yaakov will be taking over full-time responsibility for this.
Owner

I know what the problem is, happy to explain it to someone, but I don't have cycles to work on a fix right now...

will try and find someone to work on it.

I know what the problem is, happy to explain it to someone, but I don't have cycles to work on a fix right now... will try and find someone to work on it.
Member

If this works it's all Kevin's doing, if this fails blame me.

Prefixed with that, an attempt was made: https://pagure.io/releng/compose-tracker/pull-request/56

If this works it's all Kevin's doing, if this fails blame me. Prefixed with that, an attempt was made: https://pagure.io/releng/compose-tracker/pull-request/56

Unfortunately, both Fedora-eln-20241206.n.0 and Fedora-eln-20241206.n.1 failed today, but I did not receive any notification.

Unfortunately, both `Fedora-eln-20241206.n.0` and `Fedora-eln-20241206.n.1` failed today, but I did not receive any notification.

I've subscribed to the releng/failed-composes repo, so I'm getting notices (and follow-ups) to all compose failures (including ELN). A bit noisier than I would like, but nothing better seems readily available.

I've subscribed to the releng/failed-composes repo, so I'm getting notices (and follow-ups) to all compose failures (including ELN). A bit noisier than I would like, but nothing better seems readily available.
Member

One problem here is trying to test any new changes was roughly "put it in production and hope" ... Michal thinks he can help me setup a way to debug/test and we've tentatively scheduled a discussion after the holiday (in Dec.).

So, maybe will get fixed this year.

One problem here is trying to test any new changes was roughly "put it in production and hope" ... Michal thinks he can help me setup a way to debug/test and we've tentatively scheduled a discussion after the holiday (in Dec.). So, maybe will get fixed this year.
Owner

Alas, it seems not. ;(

Any further news here?

Alas, it seems not. ;( Any further news here?
Owner

So, we discussed this at the infra meeting. I think it should still be possible to do this... we just need someone with cycles to look.

@yselkowitz you still would like this? and you would like a @metion for just the eln issues right?

So, we discussed this at the infra meeting. I think it should still be possible to do this... we just need someone with cycles to look. @yselkowitz you still would like this? and you would like a @metion for just the eln issues right?
Author

I implemented functionality into the ELNBuildSync to be able to send emails when builds fail, though the production instance does not yet do this, as we need to get it migrated to Fedora Infrastructure before I can set up the SMTP to actually send them.

I implemented functionality into the ELNBuildSync to be able to [send emails when builds fail](https://gitlab.com/redhat/centos-stream/ci-cd/distrosync/distrobuildsync/-/merge_requests/114), though the production instance does not yet do this, as we need to get it [migrated to Fedora Infrastructure](https://forge.fedoraproject.org/infra/tickets/issues/13139) before I can set up the SMTP to actually send them.

@kevin wrote in #11833 (comment):

@yselkowitz you still would like this? and you would like a @metion for just the eln issues right?

Yes, that would be ideal.

@sgallagh wrote in #11833 (comment):

I implemented functionality into the ELNBuildSync to be able to send emails when builds fail

This ticket is about compose failures, not koji build failures (which that will address).

@kevin wrote in https://forge.fedoraproject.org/infra/tickets/issues/11833#issuecomment-711485: > @yselkowitz you still would like this? and you would like a @metion for just the eln issues right? Yes, that would be ideal. @sgallagh wrote in https://forge.fedoraproject.org/infra/tickets/issues/11833#issuecomment-711496: > I implemented functionality into the ELNBuildSync to be able to [send emails when builds fail](https://gitlab.com/redhat/centos-stream/ci-cd/distrosync/distrobuildsync/-/merge_requests/114) This ticket is about compose failures, not koji build failures (which that will address).
Owner

#13139 is closed as done. @yselkowitz Do you still need something from us?

https://forge.fedoraproject.org/infra/tickets/issues/13139 is closed as done. @yselkowitz Do you still need something from us?

That is about ELN build failures, this ticket (despite the title) is about ELN compose failures, iow adding my AT-name to eln-related https://forge.fedoraproject.org/releng/compose-tracker-issues/issues. There has been no progress on that.

That is about ELN *build* failures, this ticket (despite the title) is about ELN *compose* failures, iow adding my AT-name to eln-related https://forge.fedoraproject.org/releng/compose-tracker-issues/issues. There has been no progress on that.
Sign in to join this conversation.
No milestone
No project
No assignees
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
infra/tickets#11833
No description provided.