Add yselkowitz to list to notify when ELN builds fail #11833
Labels
No labels
announcement
anubis
authentication
aws
backlog
blocked
bodhi
ci
cloud
communishift
copr
database
day-to-day
dc-move
deprecated
dev
discourse
dns
downloads
easyfix
epel
firmitas
forgejo_migration
Gain
High
Gain
Low
Gain
Medium
gitlab
greenwave
hardware
help wanted
high-trouble
koji
koschei
lists
low-trouble
medium-trouble
mirrorlists
monitoring
Needs investigation
odcs
OpenShift
ops
outage
packager_workflow_blocker
pagure
permissions
Priority
Needs Review
Priority
Next Meeting
Priority
🔥 URGENT 🔥
Priority
Waiting on Assignee
Priority
Waiting on External
Priority
Waiting on Reporter
rabbitmq
release-monitoring
releng
request-for-resources
s390x
security
SMTP
sprint-0
sprint-1
src.fp.o
staging
unfreeze
waiverdb
websites-general
wiki
Backlog Status
Needs Review
Backlog Status
Ready
chore
documentation
points
01
points
02
points
03
points
05
points
08
points
13
Priority
High
Priority
Low
Priority
Medium
Sprint Status
Blocked
Sprint Status
Done
Sprint Status
In Progress
Sprint Status
Review
Sprint Status
To Do
Technical Debt
Work Item
Bug
Work Item
Epic
Work Item
Spike
Work Item
Task
Work Item
User Story
No milestone
No project
No assignees
6 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
infra/tickets#11833
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Describe what you would like us to do:
Please add user @yselkowitz to the list of accounts in
releng/failed-composesthat receive an email notification when the ELN compose fails.When do you need this to be done by? (YYYY/MM/DD)
When convenient, but preferably by 2024-05-30
Metadata Update from @jnsamyak:
Hello @sgallagh!
Thanks to Kevin of course, I got the maintainers file, where can update this so to confirm details here's the concerning PR [1] for this which adds user "Yaakov Selkowitz" with fas "yselkowitz";
Once, I have a +1 on that, we can merge it, and hopefully all good!
[1] https://pagure.io/fedora-kickstarts/pull-request/1029
Metadata Update from @jnsamyak:
Metadata Update from @jnsamyak:
PR merged, this should be active now. ;)
Let us know if there's any problems with it.
Metadata Update from @kevin:
I'm still not getting notifications.
Metadata Update from @sgallagh:
This appears working now?
At least I see the right stuff in https://pagure.io/releng/failed-composes/issue/6788
Please reopen if there's still anything not right here.
Metadata Update from @kevin:
@yselkowitz is still not getting notified when ELN composes fail. He reports that he got no email from https://pagure.io/releng/failed-composes/issue/7278
Metadata Update from @sgallagh:
I think this might be due to eln changing it's compose id from ELN to eln.
See: https://pagure.io/releng/compose-tracker/blob/main/f/compose_tracker.py#_246
if we lower case that it migth work?
Composes are being detected as failed just fine (https://stg.pagure.io/releng/failed-composes/issue/4670 was opened last night for example), but @yselkowitz is not getting notified.
Ah yeah, the problem is in it's logic. It would currently only notify if there was a specific section that failed, but since thats not the case it doesn't do anything.
I'll see if I can find someone to fix it up.
This is still broken. Can we get this looked at, please? I'm going to be transitioning to a new role in the new year and Yaakov will be taking over full-time responsibility for this.
I know what the problem is, happy to explain it to someone, but I don't have cycles to work on a fix right now...
will try and find someone to work on it.
If this works it's all Kevin's doing, if this fails blame me.
Prefixed with that, an attempt was made: https://pagure.io/releng/compose-tracker/pull-request/56
Unfortunately, both
Fedora-eln-20241206.n.0andFedora-eln-20241206.n.1failed today, but I did not receive any notification.I've subscribed to the releng/failed-composes repo, so I'm getting notices (and follow-ups) to all compose failures (including ELN). A bit noisier than I would like, but nothing better seems readily available.
One problem here is trying to test any new changes was roughly "put it in production and hope" ... Michal thinks he can help me setup a way to debug/test and we've tentatively scheduled a discussion after the holiday (in Dec.).
So, maybe will get fixed this year.
Alas, it seems not. ;(
Any further news here?
So, we discussed this at the infra meeting. I think it should still be possible to do this... we just need someone with cycles to look.
@yselkowitz you still would like this? and you would like a @metion for just the eln issues right?
I implemented functionality into the ELNBuildSync to be able to send emails when builds fail, though the production instance does not yet do this, as we need to get it migrated to Fedora Infrastructure before I can set up the SMTP to actually send them.
@kevin wrote in #11833 (comment):
Yes, that would be ideal.
@sgallagh wrote in #11833 (comment):
This ticket is about compose failures, not koji build failures (which that will address).
#13139 is closed as done. @yselkowitz Do you still need something from us?
That is about ELN build failures, this ticket (despite the title) is about ELN compose failures, iow adding my AT-name to eln-related https://forge.fedoraproject.org/releng/compose-tracker-issues/issues. There has been no progress on that.