Convert all openshift-apps to use roles/openshift/app-actions #13435

Closed
opened 2026-06-27 19:03:23 +00:00 by smoliicek · 8 comments
Member

Description of request

As said here: infra/ansible#3429 (comment)

We should convert all the openshift-apps playbooks to the role I made in said PR.

List of all openshift-apps as of writing this ticket:

  • application-monitoring.yml - infra/ansible#3455
  • asknot.yml - infra/ansible#3456
  • awx.yml - skipped for now
  • badges.yml - infra/ansible#3457
  • blockerbugs.yml - infra/ansible#3458
  • bodhi.yml - batched in infra/ansible#3459 (everything bellow this is also there)
  • bugzilla2fedmsg.yml
  • cloud-image-uploader.yml
  • compose-tracker.yml
  • coreos-cincinnati.yml - skipped, see comment bellow
  • coreos-ci.yml - skipped for now
  • coreos-koji-tagger.yml
  • custom-error-pages.yml - skipped, no deployment
  • datagrepper.yml
  • datanommer.yml
  • discourse2fedmsg.yml
  • dist-git.yml - skipped for now
  • docsbuilding.yml
  • docstranslation.yml
  • drm-panic-frontend.yml
  • elections.yml
  • elnbuildsync.yml - skipped for now
  • fasjson.yml
  • fedocal.yml
  • fedora-coreos-pipeline.yml - skipped, no deployment
  • fedora-ostree-pruner.yml
  • fedora-packages-static.yml
  • firmitas.yml - skipped for now
  • flatpak-indexer.yml
  • fmn.yml
  • forgejo.yml
  • greenwave.yml
  • jira-sync.yml
  • kanban.yml
  • kerneltest.yml
  • keycloak.yml
  • koschei.yml
  • languages.yml
  • maubot.yml
  • mdapi.yml
  • mirrormanager.yml
  • mote.yml
  • noggin-centos.yml
  • noggin.yml
  • openscanhub.yml (already did this one, as part of the original PR)
  • openvpn.yml
  • oraculum.yml
  • planet.yml
  • poddlers.yml
  • release-monitoring.yml
  • resultsdb-ci-listener.yml
  • resultsdb.yml
  • review-stats.yml
  • test-auth.yml
  • testdays.yml
  • the-new-hotness.yml
  • waiverdb.yml
  • webhook2fedmsg.yml
  • websites.yml
  • zabbix-proxy.yml
### Description of request As said here: https://forge.fedoraproject.org/infra/ansible/pulls/3429#issuecomment-826403 We should convert all the `openshift-apps` playbooks to the role I made in said PR. List of all `openshift-apps` as of writing this ticket: - [x] application-monitoring.yml - https://forge.fedoraproject.org/infra/ansible/pulls/3455 - [x] asknot.yml - https://forge.fedoraproject.org/infra/ansible/pulls/3456 - [ ] awx.yml - skipped for now - [x] badges.yml - https://forge.fedoraproject.org/infra/ansible/pulls/3457 - [x] blockerbugs.yml - https://forge.fedoraproject.org/infra/ansible/pulls/3458 - [x] bodhi.yml - batched in https://forge.fedoraproject.org/infra/ansible/pulls/3459 (everything bellow this is also there) - [x] bugzilla2fedmsg.yml - [x] cloud-image-uploader.yml - [x] compose-tracker.yml - [x] coreos-cincinnati.yml - ~skipped, see comment bellow~ - [ ] coreos-ci.yml - skipped for now - [x] coreos-koji-tagger.yml - [x] custom-error-pages.yml - skipped, no deployment - [x] datagrepper.yml - [x] datanommer.yml - [x] discourse2fedmsg.yml - [ ] dist-git.yml - skipped for now - [x] docsbuilding.yml - [x] docstranslation.yml - [x] drm-panic-frontend.yml - [x] elections.yml - [ ] elnbuildsync.yml - skipped for now - [x] fasjson.yml - [x] fedocal.yml - [x] fedora-coreos-pipeline.yml - skipped, no deployment - [x] fedora-ostree-pruner.yml - [x] fedora-packages-static.yml - [ ] firmitas.yml - skipped for now - [x] flatpak-indexer.yml - [x] fmn.yml - [ ] forgejo.yml - [x] greenwave.yml - [x] jira-sync.yml - [x] kanban.yml - [x] kerneltest.yml - [x] keycloak.yml - [x] koschei.yml - [x] languages.yml - [x] maubot.yml - [x] mdapi.yml - [x] mirrormanager.yml - [x] mote.yml - [x] noggin-centos.yml - [x] noggin.yml - [x] [openscanhub.yml (already did this one, as part of the original PR)](https://forge.fedoraproject.org/infra/ansible/pulls/3429) - [x] openvpn.yml - [x] oraculum.yml - [x] planet.yml - [x] poddlers.yml - [x] release-monitoring.yml - [x] resultsdb-ci-listener.yml - [x] resultsdb.yml - [x] review-stats.yml - [ ] test-auth.yml - [x] testdays.yml - [x] the-new-hotness.yml - [x] waiverdb.yml - [x] webhook2fedmsg.yml - [x] websites.yml - [ ] zabbix-proxy.yml
Author
Member

i want to take a look at this in the next sprint, will probably file separate PRs for every playbook, do note that this isn't a priority

i want to take a look at this in the next sprint, will probably file separate PRs for every playbook, do note that this isn't a priority
Author
Member

looking at playbooks/openshift-apps/coreos-cincinnati.yml and it seems the build runs everytime, not only when the build tag is present - do we want to keep that? or make it the same as everywhere else?

looking at `playbooks/openshift-apps/coreos-cincinnati.yml` and it seems the build runs everytime, not only when the build tag is present - do we want to keep that? or make it the same as everywhere else?
Owner

We should move it to the new pattern, IMHO.

We should move it to the new pattern, IMHO.
Author
Member

noted

noted
Author
Member

skipping elnbuildsync.yml, i need to modify the role to support the wait vars - will migrate after the fact

skipping `elnbuildsync.yml`, i need to modify the role to support the wait vars - will migrate after the fact
Author
Member

okay, all of the playbooks that that i could do should be done, skipped playbooks:

playbooks that import a role and do things there:
awx.yml
coreos-ci.yml
dist-git.yml
forgejo.yml
zabbix-proxy.yml

playbooks without deployments
custom-error-pages.yml - no deployment (no work needed)
fedora-coreos-pipeline.yml - ditto

others:
elnbuildsync.yml - waiting for the app-actions update mentioned above
test-auth.yml - can't find anything for this playbook in roles/openshift-apps

on those that need more investigation / do more changes, will file another ticket for those and complete it in the next sprint

okay, all of the playbooks that that i could do should be done, skipped playbooks: playbooks that import a role and do things there: ~**awx.yml**~ **coreos-ci.yml** **dist-git.yml** **forgejo.yml** **zabbix-proxy.yml** playbooks without deployments **custom-error-pages.yml** - no deployment (no work needed) **fedora-coreos-pipeline.yml** - ditto others: **elnbuildsync.yml** - waiting for the app-actions update mentioned above ~**test-auth.yml** - can't find anything for this playbook in `roles/openshift-apps`~ on those that need more investigation / do more changes, will file another ticket for those and complete it in the next sprint
Owner

awx can be removed.

test-auth can be removed.

For forgejo and dist-git and zabbix-proxy we can ask the forge team about it. @ryanlerch @dkirwan @lenkaseg

For coreos-ci we could ask @dustymabe

awx can be removed. test-auth can be removed. For forgejo and dist-git and zabbix-proxy we can ask the forge team about it. @ryanlerch @dkirwan @lenkaseg For coreos-ci we could ask @dustymabe
Author
Member

after a discussion with the Forge team, I will leave forgejo, dist-git and zabbix-proxy as is.

i will also let coreos-ci be, we can migrate that, if wanted, later.

after a discussion with the Forge team, I will leave forgejo, dist-git and zabbix-proxy as is. i will also let coreos-ci be, we can migrate that, if wanted, later.
Sign in to join this conversation.
No milestone
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
infra/tickets#13435
No description provided.