infra/tickets

Fork 2

fedorapeople: default user index page improvements #1590

New issue

Closed

opened 2009-08-07 19:42:45 +00:00 by till · 13 comments

till commented

2009-08-07 19:42:45 +00:00

Also a link to the overview of all fedorapeople links and maybe every other personal webpage for a maintainer would be helpful (bodhi, fas, packagedb, community portal, blog, ...). If you point me to the source, I might provide a patch.

Currently the default index page for fedorapeople only contains a directory listing and a link called "home, that leads to the public_html root dir. It would be nice to have also a listing of the user's public git repositories their. Ideally everyone, but for the beginning a link to the appropriate page on gitweb (if there ise one) would help, too. Also a link to the overview of all fedorapeople links and maybe every other personal webpage for a maintainer would be helpful (bodhi, fas, packagedb, community portal, blog, ...). If you point me to the source, I might provide a patch.

mmcgrath commented

2009-08-07 20:27:15 +00:00

I think everything you want is in:

git://git.fedorahosted.org/git/fedora-web.git/

If that template is missing or anything let me know, we likely just never copied it over from the puppet repo.

I think everything you want is in: git://git.fedorahosted.org/git/fedora-web.git/ If that template is missing or anything let me know, we likely just never copied it over from the puppet repo.

tmz commented

2009-08-07 20:48:13 +00:00

Script for creating/updating gitweb repo list on fedorapeople
make-people-git.sh

Script for creating/updating gitweb repo list on fedorapeople [make-people-git.sh](/fedora-infrastructure/issue/raw/files/1f61d225edf894c596a87053c43a1d90e8fe3600f348e6021339ac9890725405-make-people-git.sh)

tmz commented

2009-08-07 20:49:31 +00:00

Till,

In case it helps, I've attached the script used for creating/updating the gitweb repo list on fedorapeople. It's short and simple, but it might save you a few minutes and some keystrokes.

Till, In case it helps, I've attached the script used for creating/updating the gitweb repo list on fedorapeople. It's short and simple, but it might save you a few minutes and some keystrokes.

till commented

2009-10-15 20:34:35 +00:00

Author

Btw. my initial idea was to have user specific git links in /srv/people/site/userdefs/HEADER.html, so this would need to have some more autogenerated magic.

kevin commented

2015-08-28 00:31:19 +00:00

Owner

https://git.fedorahosted.org/cgit/fedora-web.git/tree/fedorapeople.org/make-people-page.sh is the current script.

Can someone rebase the desired changes on this and I can get it pushed?

https://git.fedorahosted.org/cgit/fedora-web.git/tree/fedorapeople.org/make-people-page.sh is the current script. Can someone rebase the desired changes on this and I can get it pushed?

vkaigoro commented

2015-08-28 02:32:32 +00:00

attachment
0001-Trac-1590-fedorapeople-default-user-index-page-impro.patch

attachment [0001-Trac-1590-fedorapeople-default-user-index-page-impro.patch](/fedora-infrastructure/issue/raw/files/7d26cee87eef71c46075790df843feb86b47eb5c82d8da751a11cc712bb8c166-0001-Trac-1590-fedorapeople-default-user-index-page-impro.patch)

vkaigoro commented

2015-08-28 02:33:02 +00:00

And here we go. Can someone please review?

Thanks.

And here we go. Can someone please review? Thanks. -- vk

kevin commented

2015-08-28 03:02:55 +00:00

Owner

Re-set it up and folded your changes into it...

However, then I ran into some issues:

/usr/local/bin/make-people-page.sh: line 95: syntax error near unexpected token fi' /usr/local/bin/make-people-page.sh: line 95: fi'

Looks like there's some syntax issues around if and fi and such. Can you recheck?

I went to go apply it to fedora-web, but then I realized that the copy there was just a copy, and we had somehow dropped this script/cron job on the actual server since we moved it from puppet to ansible. ;( Re-set it up and folded your changes into it... However, then I ran into some issues: /usr/local/bin/make-people-page.sh: line 95: syntax error near unexpected token `fi' /usr/local/bin/make-people-page.sh: line 95: ` fi' Looks like there's some syntax issues around if and fi and such. Can you recheck?

vkaigoro commented

2015-08-28 19:12:07 +00:00

Replying to [comment:7 kevin]:

I went to go apply it to fedora-web, but then I realized that the copy there was just a copy, and we had somehow dropped this script/cron job on the actual server since we moved it from puppet to ansible. ;(

Re-set it up and folded your changes into it...

However, then I ran into some issues:

/usr/local/bin/make-people-page.sh: line 95: syntax error near unexpected token fi' /usr/local/bin/make-people-page.sh: line 95: fi'

Looks like there's some syntax issues around if and fi and such. Can you recheck?

Hi Kevin,

Thanks for looking in to this.
Err, yeah - just remove that "fi" from line 95, that should fix the issue.

Thanks.

Replying to [comment:7 kevin]: > > > I went to go apply it to fedora-web, but then I realized that the copy there was just a copy, and we had somehow dropped this script/cron job on the actual server since we moved it from puppet to ansible. ;( > > Re-set it up and folded your changes into it... > > However, then I ran into some issues: > > /usr/local/bin/make-people-page.sh: line 95: syntax error near unexpected token `fi' > /usr/local/bin/make-people-page.sh: line 95: ` fi' > > Looks like there's some syntax issues around if and fi and such. Can you recheck? > Hi Kevin, Thanks for looking in to this. Err, yeah - just remove that "fi" from line 95, that should fix the issue. Thanks. -- vk

kevin commented

2015-08-28 22:30:09 +00:00

Owner

nope. :)

Removing the fi on line 95 leads to:

{{{
make-people-page.sh: line 82: [: too many arguments
make-people-page.sh: line 88: [: too many arguments
make-people-page.sh: line 89: [: too many arguments
make-people-page.sh: line 82: [: too many arguments
make-people-page.sh: line 88: [: too many arguments
make-people-page.sh: line 89: [: too many arguments
make-people-page.sh: line 90: [: too many arguments
}}}

Please test.

nope. :) Removing the fi on line 95 leads to: {{{ make-people-page.sh: line 82: [: too many arguments make-people-page.sh: line 88: [: too many arguments make-people-page.sh: line 89: [: too many arguments make-people-page.sh: line 82: [: too many arguments make-people-page.sh: line 88: [: too many arguments make-people-page.sh: line 89: [: too many arguments make-people-page.sh: line 90: [: too many arguments }}} Please test.

vkaigoro commented

2015-08-29 01:22:44 +00:00

Heh.
I have to print this and pin it on the wall in fornt of my desk:

{{{
I will always quote string variables in Bash
I will always quote string variables in Bash
I will always quote string variables in Bash
I will always quote string variables in Bash
I will always quote string variables in Bash
}}}

Attaching another patch.
Tested on fedorapeople.org with a huge oneliner, here is the output (just the table, wthout styles and stuff): https://vkaigoro.fedorapeople.org/fp_page.html

Heh. I have to print this and pin it on the wall in fornt of my desk: {{{ I will always quote string variables in Bash I will always quote string variables in Bash I will always quote string variables in Bash I will always quote string variables in Bash I will always quote string variables in Bash }}} Attaching another patch. Tested on fedorapeople.org with a huge oneliner, here is the output (just the table, wthout styles and stuff): https://vkaigoro.fedorapeople.org/fp_page.html

vkaigoro commented

2015-08-29 01:24:11 +00:00

Final one (hopefully)
make-people-page.sh.patch

Final one (hopefully) [make-people-page.sh.patch](/fedora-infrastructure/issue/raw/files/5007495dd658290bf951cb87fbc689a22d8ace67c9177f3f75ac75dc31a02997-make-people-page.sh.patch)

kevin commented

2015-08-29 06:10:19 +00:00

Owner

looks good. Applied.

Thanks for working on this. :)

looks good. Applied. Thanks for working on this. :)