From 089ae4f7e9df3ac8bea0c6d3573b7a0894ac1ce0 Mon Sep 17 00:00:00 2001 From: Dusty Mabe Date: Wed, 23 Apr 2025 11:12:43 -0400 Subject: [PATCH 1/2] standard/coreos-user-experience: include makedumpfile, kdump-utils The comment states that we want to support kdump so we need the makedumpfile and kdump-utils RPM for that. Note here that we specify paths rather than RPM names because downstream in EL9 those subpackages were still part of the kexec-tools package and not broken out yet. --- standard/coreos-user-experience.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/standard/coreos-user-experience.yaml b/standard/coreos-user-experience.yaml index 1098094..1ca6463 100644 --- a/standard/coreos-user-experience.yaml +++ b/standard/coreos-user-experience.yaml @@ -8,7 +8,14 @@ packages: - console-login-helper-messages-profile # kdump support # https://github.com/coreos/fedora-coreos-tracker/issues/622 + # The makedumpfile and kdump-utils RPMs were broken out in + # Fedora and EL10+. To be able to use the same package list + # Across EL9 + Fedora + EL10 let's just name paths for now. + # We can go back to just specifying the RPM names when we + # no longer support EL9. - kexec-tools + - /usr/share/makedumpfile # makedumpfile RPM + - /usr/bin/kdumpctl # kdump-utils RPM # Container tooling - toolbox # nvme-cli for managing nvme disks From 40e33e055ae7e83817ee7f73349fb14c0f4ecd0c Mon Sep 17 00:00:00 2001 From: Dusty Mabe Date: Wed, 23 Apr 2025 08:54:12 -0400 Subject: [PATCH 2/2] Add riscv64 support Add a riscv64 stanza for the bootloader so we can build images for riscv64 and conditionalize kexec-tools because it's not yet built for riscv64. --- minimal/bootupd.yaml | 8 ++++++++ standard/coreos-user-experience.yaml | 27 +++++++++++++++++---------- 2 files changed, 25 insertions(+), 10 deletions(-) diff --git a/minimal/bootupd.yaml b/minimal/bootupd.yaml index 6b55aa3..2932317 100644 --- a/minimal/bootupd.yaml +++ b/minimal/bootupd.yaml @@ -8,6 +8,14 @@ packages-aarch64: - grub2-efi-aa64 efibootmgr shim packages-ppc64le: - grub2 ostree-grub2 +packages-riscv64: + - grub2-efi-riscv64 efibootmgr + # Don't specify just `shim` for now because riscv isn't built in + # main koji instance yet and thus isn't signed. Here we specify + # the path to the provided file so when we do switch to the signed + # `shim` package it will transparently happen and we can clean up + # this packagelist entry later. + - /boot/efi/EFI/fedora/shimriscv64.efi packages-s390x: # For zipl - s390utils-core diff --git a/standard/coreos-user-experience.yaml b/standard/coreos-user-experience.yaml index 1ca6463..295ea0b 100644 --- a/standard/coreos-user-experience.yaml +++ b/standard/coreos-user-experience.yaml @@ -6,19 +6,26 @@ packages: # Improved MOTD experience - console-login-helper-messages-issuegen - console-login-helper-messages-profile - # kdump support - # https://github.com/coreos/fedora-coreos-tracker/issues/622 - # The makedumpfile and kdump-utils RPMs were broken out in - # Fedora and EL10+. To be able to use the same package list - # Across EL9 + Fedora + EL10 let's just name paths for now. - # We can go back to just specifying the RPM names when we - # no longer support EL9. - - kexec-tools - - /usr/share/makedumpfile # makedumpfile RPM - - /usr/bin/kdumpctl # kdump-utils RPM # Container tooling - toolbox # nvme-cli for managing nvme disks - nvme-cli # Used by admins interactively - lsof + +conditional-include: + - if: basearch != "riscv64" + # TODO: kexec-tools isn't built for riscv yet so conditionalize these here + # https://github.com/coreos/fedora-coreos-tracker/issues/1931 + include: + packages: + # kdump support + # https://github.com/coreos/fedora-coreos-tracker/issues/622 + # The makedumpfile and kdump-utils RPMs were broken out in + # Fedora and EL10+. To be able to use the same package list + # Across EL9 + Fedora + EL10 let's just name paths for now. + # We can go back to just specifying the RPM names when we + # no longer support EL9. + - kexec-tools + - /usr/share/makedumpfile # makedumpfile RPM + - /usr/bin/kdumpctl # kdump-utils RPM