-
Joined on
2025-08-13 -
-
compose-x86-01.stg.rdu3.fedoraproject.org.
I can ssh to the machine, but had problems with sudo. Turns out, I was trying prod password, not the staging one 🤦
The same combination of type=vhd-compressed with format=vhd.xz is already used in kiwibuild, except the file extension there is .vhdfixed.xz. That is obviously not happening in the linked…
boot_iso phase that runs in essentials to allow boot.iso production with image-builder
This comment is kinda misleading. At least in modern configuration createiso phase creates the big ISO/DVD with xorriso by adding files to the boot.iso and doesn't need the unpacked files.
boot_iso phase that runs in essentials to allow boot.iso production with image-builder
Should this also check for boot_iso_skip?
boot_iso phase that runs in essentials to allow boot.iso production with image-builder
The old buildinstall doesn't need to enumerate all files, lorax creates the structure that can then be copied as-is. Where the old code iterates over files, it is to support various tweaks and…
boot_iso phase that runs in essentials to allow boot.iso production with image-builder
I'm not seeing anything incorrect in the diagram. The colors shifted, so that makes comparing very difficult for me, but I think the ordering is correct.
boot_iso phase that runs in essentials to allow boot.iso production with image-builder
Fixup commits are okay for now, there might be a few of them, so let's not complicate it too much. Once ready to merge, the history can be tweaked to be nice and readable again.
boot_iso phase that runs in essentials to allow boot.iso production with image-builder
Both backends have identical __init__/get_repo/get_iso_path/get_config_block. Maybe a base class would be warranted here?
boot_iso phase that runs in essentials to allow boot.iso production with image-builder
Why the inline import? Should this be at top level instead?
boot_iso phase that runs in essentials to allow boot.iso production with image-builder
This could also use compose.mkdtemp() to put the temporary files under <compose>/work. With the same filesystem the files could be moved or hardlinked, which could be faster than a copy. But…
boot_iso phase that runs in essentials to allow boot.iso production with image-builder
This method could just always return False.
boot_iso phase that runs in essentials to allow boot.iso production with image-builder
Are these three entries sufficient to cover all architectures?
boot_iso phase that runs in essentials to allow boot.iso production with image-builder
Do you think "build it everywhere by default" is a good choice still? As this is new code, it could be changed to an explicit opt-in list instead. The boot_iso_* option could include architecture…
boot_iso phase that runs in essentials to allow boot.iso production with image-builder
This pattern of active_bi is repeated multiple times across the change, but I don't see a nice way to simplify that. So just a note here.
boot_iso phase that runs in essentials to allow boot.iso production with image-builder
This should also check for the specific config.