packaging/guidelines
6
2
Fork 16
Code Issues 112 Pull requests 28 Projects Releases Packages Wiki Activity Actions

Remove MPI_SUFFIX requirement from MPI guidelines #1335

Open
lecris wants to merge 3 commits from guidelines/mpi into main
pull from: guidelines/mpi
merge into: packaging:main
Conversation 0 Commits 3 Files changed 1 +71 -46
lecris commented 2024-02-23 15:17:25 +00:00
Member
Copy link

Closes #1320

There are a few issues with that guideline:

  • Using program-serial is not guaranteed to work as expected after a module load mpi, e.g. due to the use of LD_LIBRARY_PATH
  • This creates a burden on the upstream project to support this packaging decisions. E.g. a Fortran gem that I was shown: github.com/cp2k/cp2k@39fc2feded/src/start/cp2k.F (L155-L159), where the suffix of the executable is used in the execution of the code
  • It is a non-standard implementation which can affect other tools that try to find the executable through PATH

I also wanted to add the trick with %global _vpath_builddir %{_vendor}-%{_target_os}-build${MPI_SUFFIX:-_serial}, but I need to look at %configure macro to figure out how to make that work. I know for CMake, we can basically use the approach here.

While at it, I have also refactored the document a bit. I am not familiar with ASCIIIDOC, so I am not sure what is a proper way to write these.

Closes #1320 There are a few issues with that guideline: - Using `program-serial` is not guaranteed to work as expected after a `module load mpi`, e.g. due to the use of `LD_LIBRARY_PATH` - This creates a burden on the upstream project to support this packaging decisions. E.g. a Fortran gem that I was shown: https://github.com/cp2k/cp2k/blob/39fc2feded38fb50f7b1c74dba66523010dcedba/src/start/cp2k.F#L155-L159, where the suffix of the executable is used in the execution of the code - It is a non-standard implementation which can affect other tools that try to find the executable through `PATH` I also wanted to add the trick with `%global _vpath_builddir %{_vendor}-%{_target_os}-build${MPI_SUFFIX:-_serial}`, but I need to look at `%configure` macro to figure out how to make that work. I know for CMake, we can basically use the approach [here](https://github.com/wannier-developers/wannier90/pull/444). --- While at it, I have also refactored the document a bit. I am not familiar with ASCIIIDOC, so I am not sure what is a proper way to write these.
This pull request is broken due to missing fork information.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin guidelines/mpi:guidelines/mpi
git switch guidelines/mpi

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff guidelines/mpi
git switch guidelines/mpi
git rebase main
git switch main
git merge --ff-only guidelines/mpi
git switch guidelines/mpi
git rebase main
git switch main
git merge --no-ff guidelines/mpi
git switch main
git merge --squash guidelines/mpi
git switch main
git merge --ff-only guidelines/mpi
git switch main
git merge guidelines/mpi
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
announce
Approved and written up change to be announced

  
bootstrap
Bootstrapping exception

  
Closed As
accepted
 Closed with the reason of accepted

  
Closed As
duplicate
 Closed with the reason of duplicate

  
Closed As
exceptionexpired
 Closed with the reason of exceptionexpired

  
Closed As
fixed
 Closed with the reason of fixed

  
Closed As
invalid
 Closed with the reason of invalid

  
Closed As
nothingtodo
 Closed with the reason of nothingtodo

  
Closed As
permanentexception
 Closed with the reason of permanentexception

  
Closed As
rejected
 Closed with the reason of rejected

  
Closed As
temporaryexception
 Closed with the reason of temporaryexception

  
Closed As
wontfix
 Closed with the reason of wontfix

  
cmake

   
committee
Waiting on work by a committee member

  
draftneeded
Someone needs to write a draft before this can proceed

  
hasdraft
A draft has been provided

  
meeting
Needs meeting discussion

  
meson

   
needinfo
Needs additional info from the submitter

  
Priority
In Committee
 Priority of In Committee

  
Priority
Needs Review
 Priority of Needs Review

  
Priority
Waiting For Reporter
 Priority of Waiting For Reporter

  
rust

   
writeup
Approved change to be written into the guidelines

No labels
announce
bootstrap
Closed As
accepted
Closed As
duplicate
Closed As
exceptionexpired
Closed As
fixed
Closed As
invalid
Closed As
nothingtodo
Closed As
permanentexception
Closed As
rejected
Closed As
temporaryexception
Closed As
wontfix
cmake
committee
draftneeded
hasdraft
meeting
meson
needinfo
Priority
In Committee
Priority
Needs Review
Priority
Waiting For Reporter
rust
writeup
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
packaging/guidelines!1335
No description provided.