packaging/guidelines
6
2
Fork 17
Code Issues 112 Pull requests 30 Projects Releases Packages Wiki Activity Actions

Add links to KDE SIG wiki and RPM macros page #1453

Open
herzenschein wants to merge 1 commit from kde-guidelines-links into main
pull from: kde-guidelines-links
merge into: packaging:main
Conversation 3 Commits 1 Files changed 1 +2 -2
herzenschein commented 2025-04-10 21:21:46 +00:00
First-time contributor
Copy link
No description provided.
decathorpe commented 2025-04-10 21:29:50 +00:00
Owner
Copy link

I'm not sure this is an improvement? These macros can obviously be used by non-KDE-SIG members too, so saying they're only for the KDE SIG is a bit strange. And the link to the RPMMacros page seems unnecessary - it's not a page that describes what RPM Macros are, but documents some commonly used ones.

I'm not sure this is an improvement? These macros can obviously be used by non-KDE-SIG members too, so saying they're only for the KDE SIG is a bit strange. And the link to the RPMMacros page seems unnecessary - it's not a page that describes what RPM Macros are, but documents some commonly used ones.
herzenschein commented 2025-04-10 22:04:15 +00:00
Author
First-time contributor
Copy link

These macros can obviously be used by non-KDE-SIG members too, so saying they're only for the KDE SIG is a bit strange.

Sure, the important thing is that the page links to the KDE SIG page somewhere. I can find another way to phrase this.

And the link to the RPMMacros page seems unnecessary - it's not a page that describes what RPM Macros are, but documents some commonly used ones.

What would be a better choice here?

> These macros can obviously be used by non-KDE-SIG members too, so saying they're only for the KDE SIG is a bit strange. Sure, the important thing is that the page links to the KDE SIG page somewhere. I can find another way to phrase this. > And the link to the RPMMacros page seems unnecessary - it's not a page that describes what RPM Macros are, but documents some commonly used ones. What would be a better choice here?
james commented 2025-05-01 16:33:39 +00:00
Owner
Copy link

We discussed this in this weeks meeting and the consensus was that adding links were fine, but the text should be explicit that non-KDE SIG packages can use them.

We discussed this in this weeks meeting and the consensus was that adding links were fine, but the text should be explicit that non-KDE SIG packages can use them.
This pull request is broken due to missing fork information.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin kde-guidelines-links:kde-guidelines-links
git switch kde-guidelines-links

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff kde-guidelines-links
git switch kde-guidelines-links
git rebase main
git switch main
git merge --ff-only kde-guidelines-links
git switch kde-guidelines-links
git rebase main
git switch main
git merge --no-ff kde-guidelines-links
git switch main
git merge --squash kde-guidelines-links
git switch main
git merge --ff-only kde-guidelines-links
git switch main
git merge kde-guidelines-links
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
announce
Approved and written up change to be announced

  
bootstrap
Bootstrapping exception

  
Closed As
accepted
 Closed with the reason of accepted

  
Closed As
duplicate
 Closed with the reason of duplicate

  
Closed As
exceptionexpired
 Closed with the reason of exceptionexpired

  
Closed As
fixed
 Closed with the reason of fixed

  
Closed As
invalid
 Closed with the reason of invalid

  
Closed As
nothingtodo
 Closed with the reason of nothingtodo

  
Closed As
permanentexception
 Closed with the reason of permanentexception

  
Closed As
rejected
 Closed with the reason of rejected

  
Closed As
temporaryexception
 Closed with the reason of temporaryexception

  
Closed As
wontfix
 Closed with the reason of wontfix

  
cmake

   
committee
Waiting on work by a committee member

  
draftneeded
Someone needs to write a draft before this can proceed

  
hasdraft
A draft has been provided

  
meeting
Needs meeting discussion

  
meson

   
needinfo
Needs additional info from the submitter

  
Priority
In Committee
 Priority of In Committee

  
Priority
Needs Review
 Priority of Needs Review

  
Priority
Waiting For Reporter
 Priority of Waiting For Reporter

  
rust

   
writeup
Approved change to be written into the guidelines

No labels
announce
bootstrap
Closed As
accepted
Closed As
duplicate
Closed As
exceptionexpired
Closed As
fixed
Closed As
invalid
Closed As
nothingtodo
Closed As
permanentexception
Closed As
rejected
Closed As
temporaryexception
Closed As
wontfix
cmake
committee
draftneeded
hasdraft
meeting
meson
needinfo
Priority
In Committee
Priority
Needs Review
Priority
Waiting For Reporter
rust
writeup
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
packaging/guidelines!1453
No description provided.