packaging/guidelines
6
2
Fork 17
Code Issues 112 Pull requests 30 Projects Releases Packages Wiki Activity Actions

[WIP] Document the %cmake_generator macro #1455

Draft
lecris wants to merge 1 commit from cmake/generator into main
pull from: cmake/generator
merge into: packaging:main
Conversation 3 Commits 1 Files changed 1 +5
lecris commented 2025-04-16 12:54:52 +00:00
Member
Copy link

Companion to https://src.fedoraproject.org/rpms/cmake/pull-request/51 change proposal

Companion to https://src.fedoraproject.org/rpms/cmake/pull-request/51 change proposal
churchyard commented 2025-04-16 17:49:06 +00:00
Owner
Copy link

So, the packagers are supposed to redefine this?

IIRC the rule of thumb (not always followed) usually is that such macros are prefixed with underscore(s).

So, the packagers are supposed to redefine this? IIRC the rule of thumb (not always followed) usually is that such macros are prefixed with underscore(s).
lecris commented 2025-04-16 17:53:14 +00:00
Author
Member
Copy link

So, the packagers are supposed to redefine this?

Yes. Technically also undefine them or add extra -G to the %cmake, but don't want to over-complicate the documentation there.

IIRC the rule of thumb (not always followed) usually is that such macros are prefixed with underscore(s).

No objection to that either. @ngompa mentioned a similar suggestion in the linked PR.

> So, the packagers are supposed to redefine this? Yes. Technically also undefine them or add extra `-G` to the `%cmake`, but don't want to over-complicate the documentation there. > IIRC the rule of thumb (not always followed) usually is that such macros are prefixed with underscore(s). No objection to that either. @ngompa mentioned a similar suggestion in the linked PR.
ngompa commented 2025-04-17 16:33:29 +00:00
Owner
Copy link

Yeah add the leading underscore and then this is good.

Yeah add the leading underscore and then this is good.
This pull request is broken due to missing fork information.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin cmake/generator:cmake/generator
git switch cmake/generator

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff cmake/generator
git switch cmake/generator
git rebase main
git switch main
git merge --ff-only cmake/generator
git switch cmake/generator
git rebase main
git switch main
git merge --no-ff cmake/generator
git switch main
git merge --squash cmake/generator
git switch main
git merge --ff-only cmake/generator
git switch main
git merge cmake/generator
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
announce
Approved and written up change to be announced

  
bootstrap
Bootstrapping exception

  
Closed As
accepted
 Closed with the reason of accepted

  
Closed As
duplicate
 Closed with the reason of duplicate

  
Closed As
exceptionexpired
 Closed with the reason of exceptionexpired

  
Closed As
fixed
 Closed with the reason of fixed

  
Closed As
invalid
 Closed with the reason of invalid

  
Closed As
nothingtodo
 Closed with the reason of nothingtodo

  
Closed As
permanentexception
 Closed with the reason of permanentexception

  
Closed As
rejected
 Closed with the reason of rejected

  
Closed As
temporaryexception
 Closed with the reason of temporaryexception

  
Closed As
wontfix
 Closed with the reason of wontfix

  
cmake

   
committee
Waiting on work by a committee member

  
draftneeded
Someone needs to write a draft before this can proceed

  
hasdraft
A draft has been provided

  
meeting
Needs meeting discussion

  
meson

   
needinfo
Needs additional info from the submitter

  
Priority
In Committee
 Priority of In Committee

  
Priority
Needs Review
 Priority of Needs Review

  
Priority
Waiting For Reporter
 Priority of Waiting For Reporter

  
rust

   
writeup
Approved change to be written into the guidelines

No labels
announce
bootstrap
Closed As
accepted
Closed As
duplicate
Closed As
exceptionexpired
Closed As
fixed
Closed As
invalid
Closed As
nothingtodo
Closed As
permanentexception
Closed As
rejected
Closed As
temporaryexception
Closed As
wontfix
cmake
committee
draftneeded
hasdraft
meeting
meson
needinfo
Priority
In Committee
Priority
Needs Review
Priority
Waiting For Reporter
rust
writeup
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
packaging/guidelines!1455
No description provided.