packaging/guidelines
6
1
Fork 8
Code Issues 104 Pull requests 27 Projects Releases Packages Wiki Activity Actions

Fix self-contradictory web assets guidelines #1539

Open
gotmax23 wants to merge 2 commits from gotmax23/packaging-guidelines:web-no-self-contradict into main
pull from: gotmax23/packaging-guidelines:web-no-self-contradict
merge into: packaging:main
Conversation 2 Commits 2 Files changed 2 +10 -16
gotmax23 commented 2026-05-18 04:56:30 +00:00
Owner
Copy link

See the two commit messages for more details. This should address the concerns about self-contradictory guidelines brought up in #1496.

(I also noticed other out-of-date stuff in the Web Assets Guidelines (guidelines about Flash and Java applets) that should be dealt with in a separate PR.)

See the two commit messages for more details. This should address the concerns about self-contradictory guidelines brought up in #1496. (I also noticed other out-of-date stuff in the Web Assets Guidelines (guidelines about Flash and Java applets) that should be dealt with in a separate PR.)
See #1496.
The current text of the Guidelines are confusing because in once
paragraph it says CSS must be re-generated and in another it says it
doesn't have to be. This clarifies the text so it is inline with
decision made in https://pagure.io/fesco/issue/3269.
See the previous commit message. The Javascript Guidelines had the same
problem, but it required more textual changes to make the document
internally consistent while still expressing (what I think is) the
intended meaning.
supakeen commented 2026-05-18 05:04:10 +00:00
Member
Copy link

Thanks @gotmax23 this reads a lot cleaner to me and makes it the initial mentioned hardship exception indeed turns the compilation at RPM build into a SHOULD 👍

Thanks @gotmax23 this reads a lot cleaner to me and makes it the initial mentioned hardship exception indeed turns the compilation at RPM build into a SHOULD 👍
churchyard approved these changes 2026-05-18 08:20:00 +00:00
guidelines/modules/ROOT/pages/JavaScript.adoc
@ -117,3 +114,2 @@
for a list of known problem areas and suggestions for workarounds.
Additionally, the uncompiled/unminified version MUST be included
Additionally, the uncompiled/unminified version SHOULD be included
churchyard commented 2026-05-18 08:19:57 +00:00
Owner
Copy link

I'm gonna note for the record that I do not understand exactly what is being asked for here. Should I ship the full-size JavaScript in the same RPM that ships the minified one? Or just include in the SRPM?

Nevertheless, this rule already existed before and now is just MUST->SHOULD, so my curiosity should not block this PR.

I'm gonna note for the record that I do not understand exactly what is being asked for here. Should I ship the full-size JavaScript in the same RPM that ships the minified one? Or just include in the SRPM? --- Nevertheless, this rule already existed before and now is just MUST->SHOULD, so my curiosity should not block this PR.
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u web-no-self-contradict:gotmax23-web-no-self-contradict
git switch gotmax23-web-no-self-contradict

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff gotmax23-web-no-self-contradict
git switch gotmax23-web-no-self-contradict
git rebase main
git switch main
git merge --ff-only gotmax23-web-no-self-contradict
git switch gotmax23-web-no-self-contradict
git rebase main
git switch main
git merge --no-ff gotmax23-web-no-self-contradict
git switch main
git merge --squash gotmax23-web-no-self-contradict
git switch main
git merge --ff-only gotmax23-web-no-self-contradict
git switch main
git merge gotmax23-web-no-self-contradict
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
churchyard
Labels
Clear labels   
announce
Approved and written up change to be announced

  
bootstrap
Bootstrapping exception

  
Closed As
accepted
 Closed with the reason of accepted

  
Closed As
duplicate
 Closed with the reason of duplicate

  
Closed As
exceptionexpired
 Closed with the reason of exceptionexpired

  
Closed As
fixed
 Closed with the reason of fixed

  
Closed As
invalid
 Closed with the reason of invalid

  
Closed As
nothingtodo
 Closed with the reason of nothingtodo

  
Closed As
permanentexception
 Closed with the reason of permanentexception

  
Closed As
rejected
 Closed with the reason of rejected

  
Closed As
temporaryexception
 Closed with the reason of temporaryexception

  
Closed As
wontfix
 Closed with the reason of wontfix

  
cmake

   
committee
Waiting on work by a committee member

  
draftneeded
Someone needs to write a draft before this can proceed

  
hasdraft
A draft has been provided

  
meeting
Needs meeting discussion

  
meson

   
needinfo
Needs additional info from the submitter

  
Priority
In Committee
 Priority of In Committee

  
Priority
Needs Review
 Priority of Needs Review

  
Priority
Waiting For Reporter
 Priority of Waiting For Reporter

  
rust

   
writeup
Approved change to be written into the guidelines

No labels
announce
bootstrap
Closed As
accepted
Closed As
duplicate
Closed As
exceptionexpired
Closed As
fixed
Closed As
invalid
Closed As
nothingtodo
Closed As
permanentexception
Closed As
rejected
Closed As
temporaryexception
Closed As
wontfix
cmake
committee
draftneeded
hasdraft
meeting
meson
needinfo
Priority
In Committee
Priority
Needs Review
Priority
Waiting For Reporter
rust
writeup
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
packaging/guidelines!1539
No description provided.