packaging/guidelines
6
2
Fork 17
Code Issues 112 Pull requests 30 Projects Releases Packages Wiki Activity Actions

[WIP] Update Node.js guidelines, replacing nodejs-packaging-bundler with npm2rpm #1553

Draft
gordonmessmer wants to merge 2 commits from gordonmessmer/guidelines:nodejs into main
pull from: gordonmessmer/guidelines:nodejs
merge into: packaging:main
Conversation 4 Commits 2 Files changed 1 +55 -110
gordonmessmer commented 2026-06-28 05:47:57 +00:00
Member
Copy link

This change describes a change of tools that I will discuss with the Node.js SIG.

This change describes a change of tools that I will discuss with the Node.js SIG.
gordonmessmer changed title from WIP Update Node.js guidelines, replacing nodejs-packaging-bundler with npm2rpm to [WIP] Update Node.js guidelines, replacing nodejs-packaging-bundler with npm2rpm 2026-06-28 05:48:53 +00:00
vondruch reviewed 2026-06-29 16:15:07 +00:00
guidelines/modules/ROOT/pages/Node.js.adoc Outdated
@ -311,4 +257,0 @@
URL: https://github.com/substack/tape
Source0: https://registry.npmjs.org/%{npm_name}/-/%{npm_name}-%{version}.tgz
Source1: %{npm_name}-%{version}-nm-prod.tgz
Source2: %{npm_name}-%{version}-nm-dev.tgz
vondruch commented 2026-06-29 16:14:51 +00:00
Member
Copy link

Running test suite is important IMHO. Why is the example removed?

Running test suite is important IMHO. Why is the example removed?
guidelines/modules/ROOT/pages/Node.js.adoc Outdated
@ -367,2 +312,3 @@
./node_modules/.bin/tap test/*.js
%clean
rm -rf %{buildroot} %{npm_cache_dir}
vondruch commented 2026-06-29 16:14:21 +00:00
Member
Copy link

Is this required? Isn't the %clean section discouraged these days?

Is this required? Isn't the `%clean` section discouraged these days?
gordonmessmer commented 2026-06-29 16:38:52 +00:00
Author
Member
Copy link

Thanks for taking a look. I cleaned up the spec example a little bit.

Thanks for taking a look. I cleaned up the spec example a little bit.
👍 1
james commented 2026-07-23 17:02:28 +00:00
Owner
Copy link

Is this ready for FPC to take a final look at and merge? If so can you remove the WIP prefix?

Is this ready for FPC to take a final look at and merge? If so can you remove the WIP prefix?
gordonmessmer commented 2026-07-23 17:22:44 +00:00
Author
Member
Copy link

No, not ready yet. This change illustrates what the guidelines might look like if Fedora adopted npm2rpm instead of its current tooling. Before this can be merged, the Node.JS SIG really needs to evaluate that tool, and work with the upstream project to determine whether they'd carry changes that it would require to be suitable for Fedora.

No, not ready yet. This change illustrates what the guidelines might look like if Fedora adopted npm2rpm instead of its current tooling. Before this can be merged, the Node.JS SIG really needs to evaluate that tool, and work with the upstream project to determine whether they'd carry changes that it would require to be suitable for Fedora.
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u nodejs:gordonmessmer-nodejs
git switch gordonmessmer-nodejs

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff gordonmessmer-nodejs
git switch gordonmessmer-nodejs
git rebase main
git switch main
git merge --ff-only gordonmessmer-nodejs
git switch gordonmessmer-nodejs
git rebase main
git switch main
git merge --no-ff gordonmessmer-nodejs
git switch main
git merge --squash gordonmessmer-nodejs
git switch main
git merge --ff-only gordonmessmer-nodejs
git switch main
git merge gordonmessmer-nodejs
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
announce
Approved and written up change to be announced

  
bootstrap
Bootstrapping exception

  
Closed As
accepted
 Closed with the reason of accepted

  
Closed As
duplicate
 Closed with the reason of duplicate

  
Closed As
exceptionexpired
 Closed with the reason of exceptionexpired

  
Closed As
fixed
 Closed with the reason of fixed

  
Closed As
invalid
 Closed with the reason of invalid

  
Closed As
nothingtodo
 Closed with the reason of nothingtodo

  
Closed As
permanentexception
 Closed with the reason of permanentexception

  
Closed As
rejected
 Closed with the reason of rejected

  
Closed As
temporaryexception
 Closed with the reason of temporaryexception

  
Closed As
wontfix
 Closed with the reason of wontfix

  
cmake

   
committee
Waiting on work by a committee member

  
draftneeded
Someone needs to write a draft before this can proceed

  
hasdraft
A draft has been provided

  
meeting
Needs meeting discussion

  
meson

   
needinfo
Needs additional info from the submitter

  
Priority
In Committee
 Priority of In Committee

  
Priority
Needs Review
 Priority of Needs Review

  
Priority
Waiting For Reporter
 Priority of Waiting For Reporter

  
rust

   
writeup
Approved change to be written into the guidelines

No labels
announce
bootstrap
Closed As
accepted
Closed As
duplicate
Closed As
exceptionexpired
Closed As
fixed
Closed As
invalid
Closed As
nothingtodo
Closed As
permanentexception
Closed As
rejected
Closed As
temporaryexception
Closed As
wontfix
cmake
committee
draftneeded
hasdraft
meeting
meson
needinfo
Priority
In Committee
Priority
Needs Review
Priority
Waiting For Reporter
rust
writeup
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
packaging/guidelines!1553
No description provided.