Can't link a Bugzilla account with BBA #230
Labels
No labels
Closed As
Duplicate
Closed As
Fixed
Closed As
Invalid
discussions
easyfix
enhancement
task
ai-review-please
Backlog Status
Needs Review
Backlog Status
Ready
chore
documentation
points
01
points
02
points
03
points
05
points
08
points
13
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Sprint Status
Blocked
Sprint Status
Done
Sprint Status
In Progress
Sprint Status
Review
Sprint Status
To Do
Technical Debt
Work Item
Bug
Work Item
Epic
Work Item
Spike
Work Item
Task
Work Item
User Story
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
quality/blockerbugs#230
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
When I try to link my bugzilla account to BBA, I get the following error:
This might be caused by bugzilla auth changes:
https://listman.redhat.com/archives/bugzilla-announce-list/2022-February/msg00000.html
This might also be further complicated by the fact, that redhatters can no longer login using username+password only. When I try to do that in bugzilla, I get an error:
When I log in using username+pin+token directly in bugzilla, it works fine. But it doesn't work in BBA, same error.
So, we need to fix account linking, and in case of redhatters, we possibly need to tell them to use pin+token instead of a password (needs verification).
Issue tagged with: next
Metadata Update from @kparal:
After debugging, this is not for all redhatters, just those with certain (not sure which) permissions. I have those, Frantisek doesn't (and he can log in just using username+password).
Metadata Update from @kparal:
Issue tagged with: next
So, the current approach of verifying the user bz account with login and password is doomed, because bugzilla will no longer support this kind of authentication. Using bz api keys is also a non-starter, because it's several extra steps for the user, and I haven't found a way to actually figure out the user login (email) when using the api key. And we need the login to add the user to CC. So, bummer.
Please note that the whole point of verifying a user's login/email seems to be to then add him/her to CC. We already have the user logged in through FAS, so that serves as a spam protection. If we don't know users' bz login, we can't add them to CC, but that's the only loss, it seems.
Solution 1: Don't verify bz login, make the user CC manually
The simplest. Just thank the user after the proposal and ask her to CC manually.
Solution 2: Use fasjson service to get rhbz_email from FAS
Users can set "RHBZ email" value in FAS. It doesn't verify it against BZ, but it does verify that you own that email, so that seems good enough. If the user doesn't have it set, we can ask him to set it and then refresh our proposal page.
However, we don't get the
rhbz_emailvalue throughflask_fas_openidmodule that we use in BBA. After talking to Fedora AAA folks, there is https://github.com/fedora-infra/fasjson project for querying FAS, which seems to be a bit early in development, but I tested it and it works (interactive api docs). However,rhbz_emailvalue is not exposed currently, but should be once this PR is merged and deployed:https://github.com/fedora-infra/fasjson/pull/298
The downside is that the service requires a Fedora Kerberos ticket, so we'd need to configure it on our server and also in the devel environment. Also, it's a one more service to depend on (and we'd need to handle the case when it's down).
Solution 3: Ask python-fedora to expose rhbz_email in flask_fas_openid
This would be ideal for us, we'd get that value when the user gets logged in. I'm not sure they'll want to forward it, though. I filed a ticket here:
https://github.com/fedora-infra/python-fedora/issues/230
I think I'll start with Solution 1, because the deadline is approaching (Feb 28th). And we'll then determine if we want to improve it and how.
PR for Solution 1 is in #234.
Commit 665875e7 relates to this ticket
Solution 1 is now deployed to production. The other approaches are not even possible yet (the tickets are still open), so I'll put this ticket on ice and re-evaluate it after a while. It would be nice to CC the user automatically, but it's not highly important, rather a nice-to-have feature.
Metadata Update from @kparal:
A note for future self: If we move to OIDC, which is planned in #230, that might also change this problem (perhaps
rhbz_emailwill be accessible that way).Metadata Update from @kparal: