quality/blockerbugs
7
0
Fork 0
Code Issues 32 Pull requests 2 Projects 1 Releases Activity Actions

Fix release field missing on admin interface #316

Merged
jgroman merged 4 commits from fix/279-release-input into develop 2026-06-22 13:42:31 +00:00
Conversation 9 Commits 4 Files changed 2 +70
jgroman commented 2026-06-08 12:52:22 +00:00
Owner
Copy link

Restores release field in admin interface form

  • Force SQLAlcheny relationships init before rendering the form
  • Add tests covering this problem

Fixes 279

Assisted-by: Claude Code

Restores release field in admin interface form - Force SQLAlcheny relationships init before rendering the form - Add tests covering this problem Fixes 279 Assisted-by: Claude Code
jgroman self-assigned this 2026-06-08 12:52:22 +00:00 
- Force SQLAlcheny relationships init before rendering the form
- Add tests covering this problem

Fixes 279

Assisted-by: Claude Code
Remove redundant test
Some checks failed
Run tests and linters / test (pull_request) Successful in 2m48s
Details
Run tests and linters / lint (pull_request) Failing after 2s
Details
AI Code Review / ai-review (pull_request_target) Successful in 13s
Details
926b60ab01
jgroman commented 2026-06-08 14:44:47 +00:00
Author
Owner
Copy link

image

![image](/attachments/b929fadb-119b-43a5-9f84-2f7a7871b7f0)
image.png
39 KiB
jgroman changed title from WIP: Fix release field missing on admin interface to Fix release field missing on admin interface 2026-06-09 09:52:33 +00:00
forgejo-actions commented 2026-06-09 09:52:53 +00:00
Copy link

AI Code Review

📋 MR Summary

Fixes a bug where the release field was missing from the admin interface by forcing SQLAlchemy relationship initialization.

  • Key Changes:
    • Added configure_mappers() call before Flask-Admin view registration to ensure relationships are initialized.
    • Added new test suite TestMilestoneAdminForm and TestReleaseAdminForm to verify admin form fields.
  • Impact: blockerbugs/controllers/admin/init.py, testing/unit/test_admin.py
  • Risk Level: 🟢 Low - The fix is a standard SQLAlchemy lifecycle adjustment with low risk of negative side effects, well isolated to admin setup.

Detailed Code Review

The solution properly addresses the missing field issue caused by deferred relationship initialization in SQLAlchemy 2.0. The placement of configure_mappers() is appropriate. The added tests are excellent for preventing future regressions.

✅ Summary

  • Overall Assessment: The changes are solid and correctly resolve the missing field issue while adding robust regression testing.

🤖 AI Code Review | Generated with ai-code-review | Model: gemini-3.1-pro-preview

⚠️ AI-generated suggestions may be incorrect. Verify before applying. Not a replacement for human review.

## AI Code Review ### 📋 MR Summary Fixes a bug where the `release` field was missing from the admin interface by forcing SQLAlchemy relationship initialization. - **Key Changes:** - Added `configure_mappers()` call before Flask-Admin view registration to ensure relationships are initialized. - Added new test suite `TestMilestoneAdminForm` and `TestReleaseAdminForm` to verify admin form fields. - **Impact:** blockerbugs/controllers/admin/__init__.py, testing/unit/test_admin.py - **Risk Level:** 🟢 Low - The fix is a standard SQLAlchemy lifecycle adjustment with low risk of negative side effects, well isolated to admin setup. ### Detailed Code Review The solution properly addresses the missing field issue caused by deferred relationship initialization in SQLAlchemy 2.0. The placement of `configure_mappers()` is appropriate. The added tests are excellent for preventing future regressions. ### ✅ Summary - **Overall Assessment:** The changes are solid and correctly resolve the missing field issue while adding robust regression testing. --- 🤖 **AI Code Review** | Generated with [ai-code-review](https://gitlab.com/redhat/edge/ci-cd/ai-code-review) | **Model:** `gemini-3.1-pro-preview` ⚠️ *AI-generated suggestions may be incorrect. Verify before applying. Not a replacement for human review.*
jgroman requested review from kparal 2026-06-09 09:54:22 +00:00
jgroman commented 2026-06-09 09:54:42 +00:00
Author
Owner
Copy link

Ready for review

Ready for review
adamwill commented 2026-06-09 21:56:39 +00:00
Owner
Copy link

There's a lot of repetition in the tests. Can we factor that out? I like using pytest parametrize, but however you want to do it...it'd just be nice not to repeat 99% of the code.

There's a lot of repetition in the tests. Can we factor that out? I like using pytest parametrize, but however you want to do it...it'd just be nice not to repeat 99% of the code.
kparal reviewed 2026-06-10 06:15:41 +00:00
kparal left a comment
Copy link

The initial commit misses # on the Fixes line. Please correct that in the final commit, thanks!

The initial commit misses `#` on the `Fixes` line. Please correct that in the final commit, thanks!
blockerbugs/controllers/admin/__init__.py Outdated
@ -92,2 +93,4 @@
# Force SQLAlchemy to initialize relationship metadata before Flask-Admin introspects
# models to scaffold forms.
kparal commented 2026-06-10 06:13:11 +00:00
Owner
Copy link

For those of us not so strong in SQLAlchemy, can this also explain why? 🙂️

For those of us not so strong in SQLAlchemy, can this also explain _why_? 🙂️
jgroman commented 2026-06-10 10:00:25 +00:00
Author
Owner
Copy link

Expanded the comment.

Expanded the comment.
jgroman marked this conversation as resolved
kparal commented 2026-06-10 06:31:14 +00:00
Owner
Copy link

I tested the code and it works. Surprisingly it adds more fields to the Milestone and Release forms, like Bugs, Updates and Succeeds. I don't know if they were a part of it originally or not, but it doesn't matter, we don't need to touch them. Most importantly, new releases and milestones can now be added directly from the admin UI.

I tested the code and it works. Surprisingly it adds more fields to the Milestone and Release forms, like Bugs, Updates and Succeeds. I don't know if they were a part of it originally or not, but it doesn't matter, we don't need to touch them. Most importantly, new releases and milestones can now be added directly from the admin UI.
kparal commented 2026-06-10 06:40:02 +00:00
Owner
Copy link

@adamwill wrote in #316 (comment):

There's a lot of repetition in the tests. Can we factor that out? I like using pytest parametrize, but however you want to do it...it'd just be nice not to repeat 99% of the code.

I don't have a strong opinion on this. I myself repeat code a lot in tests. While it can be often abstracted, it then hurts readability. Depends on a particular case. Here it's just two tests, not ten, so I don't really mind.

@adamwill wrote in https://forge.fedoraproject.org/quality/blockerbugs/pulls/316#issuecomment-819174: > There's a lot of repetition in the tests. Can we factor that out? I like using pytest parametrize, but however you want to do it...it'd just be nice not to repeat 99% of the code. I don't have a strong opinion on this. I myself repeat code a lot in tests. While it can be often abstracted, it then hurts readability. Depends on a particular case. Here it's just two tests, not ten, so I don't really mind.
Fix review findings: expand comment, rework tests
Some checks failed
Run tests and linters / test (pull_request) Successful in 2m50s
Details
Run tests and linters / lint (pull_request) Failing after 2s
Details
c73654e934
jgroman commented 2026-06-10 10:03:12 +00:00
Author
Owner
Copy link

Ready for review

Ready for review
jgroman force-pushed fix/279-release-input from c73654e934
Some checks failed
Run tests and linters / test (pull_request) Successful in 2m50s
Details
Run tests and linters / lint (pull_request) Failing after 2s
Details
to d4beae03cb
Some checks failed
Run tests and linters / test (pull_request) Failing after 2m44s
Details
2026-06-22 13:24:55 +00:00 Compare
kparal approved these changes 2026-06-22 13:30:56 +00:00
Reformat test_admin.py for format check
All checks were successful
Run tests and linters / test (pull_request) Successful in 2m40s
Details
9392572d0d
jgroman merged commit 9392572d0d into develop 2026-06-22 13:42:31 +00:00
jgroman deleted branch fix/279-release-input 2026-06-22 13:42:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
kparal
Labels
Clear labels   
Closed As
Duplicate
 Closed with the reason of Duplicate

  
Closed As
Fixed
 Closed with the reason of Fixed

  
Closed As
Invalid
 Closed with the reason of Invalid

  
discussions
issues related to the blocker discussion system in pagure

  
easyfix

   
enhancement
a request for or implementation of an enhancement (not a bug fix)

  
task
issue that isn't a bug fix or enhancement but some kind of admin task

  
ai-review-please
Request AI review for a pull request

  
Backlog Status
Needs Review
 Work items that have been created or updated but need review, refinement, or approval before they can be considered ready for sprint planning.

  
Backlog Status
Ready
 Work items that have been reviewed, refined, and are ready to be committed to a sprint. These items have clear requirements and can be worked on immediately when capacity is available.

  
chore
Work that needs to be done but doesn't add new functionality or fix bugs. Maintenance tasks that keep the system running smoothly and the codebase clean.

  
documentation
Work focused on creating, updating, or improving documentation for users, developers, or system administrators.

  
points
01
 A task that is simple, small, and has very little uncertainty. It should be easy enough for any team member to pick up and complete quickly, without a lot of discussion or research.

  
points
02
 This is a task that is slightly more complex or larger than a "1." It might involve two or three simple steps, but the outcome is still very clear and there's little uncertainty.

  
points
03
 Medium-sized task with some noticeable complexity. It might require a bit more thought or collaboration. The steps are well-defined, but it's not a trivial change.

  
points
05
 A significant piece of work. It has more complexity and a higher degree of uncertainty than smaller tasks. It might require some research, a design discussion, or collaboration across multiple teams.

  
points
08
 Complex task with a lot of uncertainty. It's often the largest size that a team will consider for a single sprint. It likely requires a detailed breakdown and multiple team members to complete.

  
points
13
 Any task that feels like it's a "13" or more is considered an Epic. These are too large and uncertain to be worked on in a single sprint and should be broken down.

  
pr2jira
Sync this pull request to Jira for Agility tracking. Only use for PRs without a corresponding ticket.

  
Priority
Critical
 This is for work that is urgent and of critical importance and so and must be addressed immediately with a higher priority than all other work, even if not originally planned for the current sprint.

  
Priority
High
 This is for work that is critical and needs to be addressed in the next sprint. It's often for urgent bugs, important features, or a major piece of technical debt that is blocking other work.

  
Priority
Low
 This is for work that is good to do but not urgent. It's a candidate for being worked on when there's extra time or when it rises in importance. It can stay in the backlog for a longer period.

  
Priority
Medium
 This is for important work that should be done soon, but isn't as urgent as a high-priority item. It will likely be considered for the next 1-2 sprints.

  
Sprint Status
Blocked
 Work items that cannot progress due to external dependencies, blockers, or issues that need resolution.

  
Sprint Status
Done
 Work items that have been completed, reviewed, and integrated. No further work is needed within the current sprint.

  
Sprint Status
In Progress
 Work items currently being worked on by a team member. Active development, research, or implementation is happening.

  
Sprint Status
Review
 Work items that are complete but need review, testing, or approval before being marked as done.

  
Sprint Status
To Do
 Work items that are committed to the sprint but haven't been started yet. These items are ready to be picked up by team members.

  
Technical Debt
Work that addresses shortcuts, workarounds, or suboptimal implementations that were done previously to meet deadlines. These items improve code quality, maintainability, or performance without adding new features.

  
Work Item
Bug
 Issues where the system is not working as intended or designed. Bugs represent deviations from expected behavior.

  
Work Item
Epic
 Large initiatives that are broken down into multiple smaller work items (user stories, tasks, bugs). Epics represent significant features or projects that span multiple sprints.

  
Work Item
Spike
 Time-boxed research, investigation, or proof-of-concept work to reduce uncertainty or explore solutions. Spikes help inform future development decisions.

  
Work Item
Task
 Used to break down larger user stories into smaller, manageable implementation pieces. They focus on the specific technical steps needed to deliver the user story's value.

  
Work Item
User Story
 User-facing features or functionality that can be framed from a user perspective, describing what someone wants to accomplish and why.

No labels
Closed As
Duplicate
Closed As
Fixed
Closed As
Invalid
discussions
easyfix
enhancement
task
ai-review-please
Backlog Status
Needs Review
Backlog Status
Ready
chore
documentation
points
01
points
02
points
03
points
05
points
08
points
13
pr2jira
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Sprint Status
Blocked
Sprint Status
Done
Sprint Status
In Progress
Sprint Status
Review
Sprint Status
To Do
Technical Debt
Work Item
Bug
Work Item
Epic
Work Item
Spike
Work Item
Task
Work Item
User Story
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
jgroman
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#279 Can't create milestones because there is nowhere to input the release
quality/blockerbugs
Reference
quality/blockerbugs!316
No description provided.