quality/fedora-nightlies

Fork 0

Can we have publicly accessible nightlies.json? #10

New issue

Closed

opened 2021-05-07 12:29:42 +00:00 by frantisekz · 8 comments

frantisekz commented

2021-05-07 12:29:42 +00:00

I'd like to consume data about the latest compose in testcloud and oraculum, would it be possible to make nightlies.json publicly accessible next to https://openqa.fedoraproject.org/nightlies.html ?

Thanks!

I'd like to consume data about the latest compose in testcloud and oraculum, would it be possible to make nightlies.json publicly accessible next to https://openqa.fedoraproject.org/nightlies.html ? Thanks!

kparal commented

2021-05-07 13:32:49 +00:00

Owner

As a side remark, it might be a good idea to link the json from the html ("if you want to process this data automatically, there's a json file $here"), so that anyone looking for the same thing can find it easily.

As a side remark, it might be a good idea to link the json from the html (*"if you want to process this data automatically, there's a json file $here"*), so that anyone looking for the same thing can find it easily.

adamwill commented

2021-05-07 20:20:39 +00:00

Owner

As a side remark, it might be a good idea to link the json from the html ("if you want to process this data automatically, there's a json file $here"), so that anyone looking for the same thing can find it easily.

That's not really possible to do reliably, as the tool just generates the files. By design, serving them out can be done in any way the admin likes. So there's no reliable relationship between the public URL of one and the public URL of the other (if any).

> As a side remark, it might be a good idea to link the json from the html (*"if you want to process this data automatically, there's a json file $here"*), so that anyone looking for the same thing can find it easily. That's not really possible to do reliably, as the tool just generates the files. By design, serving them out can be done in any way the admin likes. So there's no reliable relationship between the public URL of one and the public URL of the other (if any).

lruzicka commented

2021-05-08 17:44:41 +00:00

Owner

If the json file would not be written out to /var/lib/fedora-nightlies but to the /var/www/ similarly to the http file (or copied to that location via cron for instance) would that not be enough for @frantisekz to be able to download it and utilize it?

If the json file would not be written out to `/var/lib/fedora-nightlies` but to the `/var/www/` similarly to the *http* file (or copied to that location via cron for instance) would that not be enough for @frantisekz to be able to download it and utilize it?

kparal commented

2021-05-10 13:31:28 +00:00

Owner

That's not really possible to do reliably, as the tool just generates the files. By design, serving them out can be done in any way the admin likes. So there's no reliable relationship between the public URL of one and the public URL of the other (if any).

Well, there's the proper way - add a config file where you can set up the location (supporting relative paths as well) and fall back to a default value if the config option is not set.

Or there's the quick way - just hardcode it to ./nightlies.json, because we're the only users of this tool, and if we ever want to change it, we can do it instantly. In the very unlikely case where someone else wants to use it differently, we'll happily accept a PR from them.

I'm a fan of the second one 😉

> That's not really possible to do reliably, as the tool just generates the files. By design, serving them out can be done in any way the admin likes. So there's no reliable relationship between the public URL of one and the public URL of the other (if any). Well, there's the proper way - add a config file where you can set up the location (supporting relative paths as well) and fall back to a default value if the config option is not set. Or there's the quick way - just hardcode it to `./nightlies.json`, because we're the only users of this tool, and if we ever want to change it, we can do it instantly. In the very unlikely case where someone else wants to use it differently, we'll happily accept a PR from them. I'm a fan of the second one :wink:

frantisekz commented

2021-05-10 14:42:36 +00:00

Author

If the json file would not be written out to /var/lib/fedora-nightlies but to the /var/www/ similarly to the http file (or copied to that location via cron for instance) would that not be enough for @frantisekz to be able to download it and utilize it?

Yeah, just having access to the json form is more than enough for me :)

> If the json file would not be written out to `/var/lib/fedora-nightlies` but to the `/var/www/` similarly to the *http* file (or copied to that location via cron for instance) would that not be enough for @frantisekz to be able to download it and utilize it? Yeah, just having access to the json form is more than enough for me :)

adamwill commented

2021-05-10 20:31:20 +00:00

Owner

yeah, I was planning to look at the initial request, just not the link thing.

I'm trying to remember my initial plan about this sort of thing. I think I didn't really intend for the JSON to be a 'public interface', I didn't want to commit to the format not changing etc. But for quick and dirty purposes I guess we can tweak the deployment to make it available.

yeah, I was planning to look at the initial request, just not the link thing. I'm trying to remember my initial plan about this sort of thing. I think I didn't really intend for the JSON to be a 'public interface', I didn't want to commit to the format not changing etc. But for quick and dirty purposes I guess we can tweak the deployment to make it available.

adamwill commented

2021-05-27 22:16:55 +00:00

Owner

okay, sure.
That should stay up to date now. Yell if it doesn't. I changed the upstream default too, though that's not what we actually use in the infra deployment, we set it via config.

okay, [sure](https://openqa.fedoraproject.org/nightlies.json). That should stay up to date now. Yell if it doesn't. I [changed the upstream default too](https://pagure.io/fedora_nightlies/c/6bd1b85732da6e25aa68d5e4bb8766d3a94ced52?branch=master), though that's not what we actually use in the infra deployment, we set it via config.

adamwill commented

2021-05-27 22:16:56 +00:00

Owner

Metadata Update from @adamwill: