quality/fedora_openqa
5
0
Fork 0
Code Issues 10 Pull requests 1 Projects Releases Packages Activity Actions

Add wiki reporting for partial kickstart install test #135

Merged
adamwill merged 1 commit from partial-kickstart into main 2026-04-21 01:14:57 +00:00
Conversation 2 Commits 1 Files changed 1 +25 -19
adamwill commented 2026-04-20 23:54:47 +00:00
Owner
Copy link

Also move the kickstart test case entries around so they're all
together, and drop some erroneous reporting lines (kickstart
tests shouldn't report results for interactive user/root test).

Goes with
quality/os-autoinst-distri-fedora#522

Signed-off-by: Adam Williamson awilliam@redhat.com

Also move the kickstart test case entries around so they're all together, and drop some erroneous reporting lines (kickstart tests shouldn't report results for interactive user/root test). Goes with https://forge.fedoraproject.org/quality/os-autoinst-distri-fedora/pulls/522 Signed-off-by: Adam Williamson <awilliam@redhat.com>
Add wiki reporting for partial kickstart install test
All checks were successful
CI via Tox / tox (pull_request) Successful in 2m3s
Details
CI via Tox / checkwiki (pull_request) Successful in 49s
Details
AI Code Review / ai-review (pull_request_target) Successful in 20s
Details
7064fe1fd7 
Also move the kickstart test case entries around so they're all
together, and drop some erroneous reporting lines (kickstart
tests shouldn't report results for interactive user/root test).

Goes with
quality/os-autoinst-distri-fedora#522

Signed-off-by: Adam Williamson <awilliam@redhat.com>
forgejo-actions commented 2026-04-21 00:06:09 +00:00
Copy link

AI Code Review

📋 MR Summary

Adds wiki reporting for the partial kickstart install test and reorganizes kickstart test cases in the configuration.

  • Key Changes:
    • Adds QA:Testcase_kickstart_partial to TESTCASES and an associated suite install_kickstart_partial.
    • Groups all Kickstart-related test cases together in the TESTCASES dictionary.
    • Removes QA:Testcase_Anaconda_user_creation from kickstart test suites, as kickstart tests should not report results for interactive user/root tests.
  • Impact: src/fedora_openqa/conf_test_suites.py
  • Risk Level: 🟢 Low - The changes consist solely of dictionary reorganizations and minor logic adjustments to test configurations. There is no impact on production application logic.

Detailed Code Review

The changes directly align with the stated intent in the merge request description. Moving the kickstart configurations to be grouped together improves readability and maintainability. Dropping the erroneous user creation lines accurately reflects the test flow expectations. The dictionary definitions are structurally correct and safely implemented.

✅ Summary

  • Overall Assessment: The changes are straightforward, syntactically valid, and align with the PR description. No critical issues or bugs were identified.

🤖 AI Code Review | Generated with ai-code-review | Model: gemini-3.1-pro-preview

⚠️ AI-generated suggestions may be incorrect. Verify before applying. Not a replacement for human review.

## AI Code Review ### 📋 MR Summary Adds wiki reporting for the partial kickstart install test and reorganizes kickstart test cases in the configuration. - **Key Changes:** - Adds `QA:Testcase_kickstart_partial` to `TESTCASES` and an associated suite `install_kickstart_partial`. - Groups all Kickstart-related test cases together in the `TESTCASES` dictionary. - Removes `QA:Testcase_Anaconda_user_creation` from kickstart test suites, as kickstart tests should not report results for interactive user/root tests. - **Impact:** src/fedora_openqa/conf_test_suites.py - **Risk Level:** 🟢 Low - The changes consist solely of dictionary reorganizations and minor logic adjustments to test configurations. There is no impact on production application logic. ### Detailed Code Review The changes directly align with the stated intent in the merge request description. Moving the kickstart configurations to be grouped together improves readability and maintainability. Dropping the erroneous user creation lines accurately reflects the test flow expectations. The dictionary definitions are structurally correct and safely implemented. ### ✅ Summary - **Overall Assessment:** The changes are straightforward, syntactically valid, and align with the PR description. No critical issues or bugs were identified. --- 🤖 **AI Code Review** | Generated with [ai-code-review](https://gitlab.com/redhat/edge/ci-cd/ai-code-review) | **Model:** `gemini-3.1-pro-preview` ⚠️ *AI-generated suggestions may be incorrect. Verify before applying. Not a replacement for human review.*
adamwill commented 2026-04-21 01:14:51 +00:00
Author
Owner
Copy link

Test PR merged, merging this.

Test PR merged, merging this.
adamwill deleted branch partial-kickstart 2026-04-21 01:14:57 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Closed As
Duplicate
 Closed with the reason of Duplicate

  
Closed As
Fixed
 Closed with the reason of Fixed

  
Closed As
Invalid
 Closed with the reason of Invalid

  
easyfix

   
enhancement
  
ai-review-please
Request AI review for a pull request

  
Backlog Status
Needs Review
 Work items that have been created or updated but need review, refinement, or approval before they can be considered ready for sprint planning.

  
Backlog Status
Ready
 Work items that have been reviewed, refined, and are ready to be committed to a sprint. These items have clear requirements and can be worked on immediately when capacity is available.

  
chore
Work that needs to be done but doesn't add new functionality or fix bugs. Maintenance tasks that keep the system running smoothly and the codebase clean.

  
documentation
Work focused on creating, updating, or improving documentation for users, developers, or system administrators.

  
points
01
 A task that is simple, small, and has very little uncertainty. It should be easy enough for any team member to pick up and complete quickly, without a lot of discussion or research.

  
points
02
 This is a task that is slightly more complex or larger than a "1." It might involve two or three simple steps, but the outcome is still very clear and there's little uncertainty.

  
points
03
 Medium-sized task with some noticeable complexity. It might require a bit more thought or collaboration. The steps are well-defined, but it's not a trivial change.

  
points
05
 A significant piece of work. It has more complexity and a higher degree of uncertainty than smaller tasks. It might require some research, a design discussion, or collaboration across multiple teams.

  
points
08
 Complex task with a lot of uncertainty. It's often the largest size that a team will consider for a single sprint. It likely requires a detailed breakdown and multiple team members to complete.

  
points
13
 Any task that feels like it's a "13" or more is considered an Epic. These are too large and uncertain to be worked on in a single sprint and should be broken down.

  
Priority
Critical
 This is for work that is urgent and of critical importance and so and must be addressed immediately with a higher priority than all other work, even if not originally planned for the current sprint.

  
Priority
High
 This is for work that is critical and needs to be addressed in the next sprint. It's often for urgent bugs, important features, or a major piece of technical debt that is blocking other work.

  
Priority
Low
 This is for work that is good to do but not urgent. It's a candidate for being worked on when there's extra time or when it rises in importance. It can stay in the backlog for a longer period.

  
Priority
Medium
 This is for important work that should be done soon, but isn't as urgent as a high-priority item. It will likely be considered for the next 1-2 sprints.

  
Sprint Status
Blocked
 Work items that cannot progress due to external dependencies, blockers, or issues that need resolution.

  
Sprint Status
Done
 Work items that have been completed, reviewed, and integrated. No further work is needed within the current sprint.

  
Sprint Status
In Progress
 Work items currently being worked on by a team member. Active development, research, or implementation is happening.

  
Sprint Status
Review
 Work items that are complete but need review, testing, or approval before being marked as done.

  
Sprint Status
To Do
 Work items that are committed to the sprint but haven't been started yet. These items are ready to be picked up by team members.

  
Technical Debt
Work that addresses shortcuts, workarounds, or suboptimal implementations that were done previously to meet deadlines. These items improve code quality, maintainability, or performance without adding new features.

  
Work Item
Bug
 Issues where the system is not working as intended or designed. Bugs represent deviations from expected behavior.

  
Work Item
Epic
 Large initiatives that are broken down into multiple smaller work items (user stories, tasks, bugs). Epics represent significant features or projects that span multiple sprints.

  
Work Item
Spike
 Time-boxed research, investigation, or proof-of-concept work to reduce uncertainty or explore solutions. Spikes help inform future development decisions.

  
Work Item
Task
 Used to break down larger user stories into smaller, manageable implementation pieces. They focus on the specific technical steps needed to deliver the user story's value.

  
Work Item
User Story
 User-facing features or functionality that can be framed from a user perspective, describing what someone wants to accomplish and why.

No labels
Closed As
Duplicate
Closed As
Fixed
Closed As
Invalid
easyfix
enhancement
ai-review-please
Backlog Status
Needs Review
Backlog Status
Ready
chore
documentation
points
01
points
02
points
03
points
05
points
08
points
13
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Sprint Status
Blocked
Sprint Status
Done
Sprint Status
In Progress
Sprint Status
Review
Sprint Status
To Do
Technical Debt
Work Item
Bug
Work Item
Epic
Work Item
Spike
Work Item
Task
Work Item
User Story
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
quality/fedora_openqa!135
No description provided.