quality/issuebot
quality/issuebot
7
0
Fork 0
Code Issues 9 Pull requests Projects Activity Actions

Add stage/prod support, test suite, and fix issues #14 and #18 #20

Closed
psklenar wants to merge 6 commits from feature/stage-prod-support into main
pull from: feature/stage-prod-support
merge into: quality:main
Conversation 4 Commits 6 Files changed 14 +924 -63
psklenar commented 2026-05-25 10:47:16 +00:00
Owner
Copy link

Summary

Add multi-environment support and comprehensive test suite for IssueBot.

Changes

Features

  • Environment-based configuration via BUGZILLA_URL, DISCOURSE_URL env vars
  • Complete test suite with 2 tests (test-find-updates, test-clean-declined)
  • Whiteboard update retry logic with verification (3 attempts)
  • HIDE_CLOSED_DAYS override for testing (default: 7)
  • Comprehensive documentation in docs/

Bug Fixes

  • Fix #14: Handle Bodhi updates with package lists (pkg1, pkg2, and N more)
  • Fix #18: Use correct URLs in stage environment

Files

  • Added: test/ (8 files), docs/ (3 files)
  • Modified: issuebot.py (180 insertions, 63 deletions)

Testing

export BUGZILLA_URL="bugzilla.stage.redhat.com"
export DISCOURSE_URL="discussion.stg.fedoraproject.org"
export UPDATEINFO_USER="psklenar" # user with rights to edit whiteboard, user issuebot hasnt now
export FORCE_VERSIONS="40" # current fedora version in stage bugzilla
export BUGZILLA_API_STG_KEY='api key to stage bz with rights to edit whiteboard (issuebot api key hasnt)'
export DISCOURSE_API_STG_KEY='issuebot api key'

bash test/test-find-updates.sh

Fixes #14, #18

## Summary Add multi-environment support and comprehensive test suite for IssueBot. ## Changes ### Features - Environment-based configuration via `BUGZILLA_URL`, `DISCOURSE_URL` env vars - Complete test suite with 2 tests (`test-find-updates`, `test-clean-declined`) - Whiteboard update retry logic with verification (3 attempts) - `HIDE_CLOSED_DAYS` override for testing (default: 7) - Comprehensive documentation in `docs/` ### Bug Fixes - Fix #14: Handle Bodhi updates with package lists `(pkg1, pkg2, and N more)` - Fix #18: Use correct URLs in stage environment ### Files - Added: `test/` (8 files), `docs/` (3 files) - Modified: `issuebot.py` (180 insertions, 63 deletions) ## Testing ```bash export BUGZILLA_URL="bugzilla.stage.redhat.com" export DISCOURSE_URL="discussion.stg.fedoraproject.org" export UPDATEINFO_USER="psklenar" # user with rights to edit whiteboard, user issuebot hasnt now export FORCE_VERSIONS="40" # current fedora version in stage bugzilla export BUGZILLA_API_STG_KEY='api key to stage bz with rights to edit whiteboard (issuebot api key hasnt)' export DISCOURSE_API_STG_KEY='issuebot api key' bash test/test-find-updates.sh ``` Fixes #14, #18 
- Add environment-based configuration (BUGZILLA_URL, DISCOURSE_URL)
- Fix issue #14: Handle Bodhi updates with package lists
- Fix issue #18: Use correct URLs in stage environment
- Add complete test suite (test-find-updates, test-clean-declined)
- Add whiteboard update retry logic with verification
- Add HIDE_CLOSED_DAYS environment variable for testing
- Add comprehensive documentation (docs/)
- Add TODO for CommonBugs keyword removal in clean_declined

Fixes: #14, #18
Replace unsupported 'note' syntax with state descriptions
kparal commented 2026-05-27 11:58:35 +00:00
Owner
Copy link

Thanks for the PR! There are lots of generated changes, and we'll need to split this into separate PRs in order keep our sanity 🙂️

Please cancel this PR and instead create individual PRs for:

  1. Adding generated docs. @adamwill @jgroman Should there be some central AGENTS.md that AI agents read by default? And perhaps links to other files if the agent needs some special knowledge? Or is it OK as it is?
  2. The actual fix for #14 . Please keep the changes minimal.
  3. The actual fix for #18 . Please keep the changes minimal.
  4. Adding tests. (It would be nice to see a standard test suite that mocks Bugzilla rather than/in addition to scripts that do real stuff. But I understand you don't have experience with it and it can be a gradual process).
  5. Any other improvements that you'd like to see in the code.

It might be better to go one-by-one instead of creating all the PRs simultaneously, I think. Otherwise there might be lots of refactoring, when code changes in one PRs, and affects all the other PRs.

Thanks for the PR! There are lots of generated changes, and we'll need to split this into separate PRs in order keep our sanity 🙂️ Please cancel this PR and instead create individual PRs for: 1. **Adding generated docs**. @adamwill @jgroman Should there be some central AGENTS.md that AI agents read by default? And perhaps links to other files if the agent needs some special knowledge? Or is it OK as it is? 2. **The actual fix for #14** . Please keep the changes minimal. 3. **The actual fix for #18** . Please keep the changes minimal. 4. **Adding tests**. (It would be nice to see a standard test suite that mocks Bugzilla rather than/in addition to scripts that do real stuff. But I understand you don't have experience with it and it can be a gradual process). 5. **Any other improvements that you'd like to see in the code.** It might be better to go one-by-one instead of creating all the PRs simultaneously, I think. Otherwise there might be lots of refactoring, when code changes in one PRs, and affects all the other PRs.
jgroman commented 2026-05-27 12:20:38 +00:00
Owner
Copy link

@kparal wrote in #20 (comment):

Should there be some central AGENTS.md that AI agents read by default? And perhaps links to other files if the agent needs some special knowledge? Or is it OK as it is?

I think this would be very useful as AGENTS.md is autodiscovered by AI and it would definitely save some tokens otherwise spent on scanning the project over and over again. Apparently it is also possible to have such file in any subfolder or add any links to it to feed AI more info as necessary.

brb, adding AGENTS.md to my own projects.

@kparal wrote in https://forge.fedoraproject.org/quality/issuebot/pulls/20#issuecomment-760555: > Should there be some central AGENTS.md that AI agents read by default? And perhaps links to other files if the agent needs some special knowledge? Or is it OK as it is? I think this would be very useful as AGENTS.md is autodiscovered by AI and it would definitely save some tokens otherwise spent on scanning the project over and over again. Apparently it is also possible to have such file in any subfolder or add any links to it to feed AI more info as necessary. brb, adding AGENTS.md to my own projects.
kparal commented 2026-05-27 12:29:48 +00:00
Owner
Copy link

In that case, maybe we can have some common techniques shared across all our projects. For example having docs/ for human-oriented consumption (mostly handcrafted, more carefully reviewed), and docs/ai/ for AI-oriented consumption (mostly generated, frequently regenerated to be up-to-date, with just a quick skim review).

AGENTS.md can then live in docs/ai/AGENTS.md, and can instruct the AI to read everything in docs/ai/ if it needs more context (we can generate short descriptions of each file directly into AGENTS.md), or even docs/ for human-oriented instructions.

This almost feels like we'll need some central AI-skills repository soon, implementing these workflows...

In that case, maybe we can have some common techniques shared across all our projects. For example having `docs/` for human-oriented consumption (mostly handcrafted, more carefully reviewed), and `docs/ai/` for AI-oriented consumption (mostly generated, frequently regenerated to be up-to-date, with just a quick skim review). `AGENTS.md` can then live in `docs/ai/AGENTS.md`, and can instruct the AI to read everything in `docs/ai/` if it needs more context (we can generate short descriptions of each file directly into `AGENTS.md`), or even `docs/` for human-oriented instructions. This almost feels like we'll need some central **AI-skills** repository soon, implementing these workflows...
psklenar commented 2026-06-01 11:36:54 +00:00
Author
Owner
Copy link

Closing to split into more PR

Closing to split into more PR
psklenar closed this pull request 2026-06-01 11:36:54 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
  
ai-review-please
Request AI review for a pull request

  
Backlog Status
Needs Review
 Work items that have been created or updated but need review, refinement, or approval before they can be considered ready for sprint planning.

  
Backlog Status
Ready
 Work items that have been reviewed, refined, and are ready to be committed to a sprint. These items have clear requirements and can be worked on immediately when capacity is available.

  
chore
Work that needs to be done but doesn't add new functionality or fix bugs. Maintenance tasks that keep the system running smoothly and the codebase clean.

  
documentation
Work focused on creating, updating, or improving documentation for users, developers, or system administrators.

  
points
01
 A task that is simple, small, and has very little uncertainty. It should be easy enough for any team member to pick up and complete quickly, without a lot of discussion or research.

  
points
02
 This is a task that is slightly more complex or larger than a "1." It might involve two or three simple steps, but the outcome is still very clear and there's little uncertainty.

  
points
03
 Medium-sized task with some noticeable complexity. It might require a bit more thought or collaboration. The steps are well-defined, but it's not a trivial change.

  
points
05
 A significant piece of work. It has more complexity and a higher degree of uncertainty than smaller tasks. It might require some research, a design discussion, or collaboration across multiple teams.

  
points
08
 Complex task with a lot of uncertainty. It's often the largest size that a team will consider for a single sprint. It likely requires a detailed breakdown and multiple team members to complete.

  
points
13
 Any task that feels like it's a "13" or more is considered an Epic. These are too large and uncertain to be worked on in a single sprint and should be broken down.

  
Priority
Critical
 This is for work that is urgent and of critical importance and so and must be addressed immediately with a higher priority than all other work, even if not originally planned for the current sprint.

  
Priority
High
 This is for work that is critical and needs to be addressed in the next sprint. It's often for urgent bugs, important features, or a major piece of technical debt that is blocking other work.

  
Priority
Low
 This is for work that is good to do but not urgent. It's a candidate for being worked on when there's extra time or when it rises in importance. It can stay in the backlog for a longer period.

  
Priority
Medium
 This is for important work that should be done soon, but isn't as urgent as a high-priority item. It will likely be considered for the next 1-2 sprints.

  
Sprint Status
Blocked
 Work items that cannot progress due to external dependencies, blockers, or issues that need resolution.

  
Sprint Status
Done
 Work items that have been completed, reviewed, and integrated. No further work is needed within the current sprint.

  
Sprint Status
In Progress
 Work items currently being worked on by a team member. Active development, research, or implementation is happening.

  
Sprint Status
Review
 Work items that are complete but need review, testing, or approval before being marked as done.

  
Sprint Status
To Do
 Work items that are committed to the sprint but haven't been started yet. These items are ready to be picked up by team members.

  
Technical Debt
Work that addresses shortcuts, workarounds, or suboptimal implementations that were done previously to meet deadlines. These items improve code quality, maintainability, or performance without adding new features.

  
Work Item
Bug
 Issues where the system is not working as intended or designed. Bugs represent deviations from expected behavior.

  
Work Item
Epic
 Large initiatives that are broken down into multiple smaller work items (user stories, tasks, bugs). Epics represent significant features or projects that span multiple sprints.

  
Work Item
Spike
 Time-boxed research, investigation, or proof-of-concept work to reduce uncertainty or explore solutions. Spikes help inform future development decisions.

  
Work Item
Task
 Used to break down larger user stories into smaller, manageable implementation pieces. They focus on the specific technical steps needed to deliver the user story's value.

  
Work Item
User Story
 User-facing features or functionality that can be framed from a user perspective, describing what someone wants to accomplish and why.

No labels
ai-review-please
Backlog Status
Needs Review
Backlog Status
Ready
chore
documentation
points
01
points
02
points
03
points
05
points
08
points
13
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Sprint Status
Blocked
Sprint Status
Done
Sprint Status
In Progress
Sprint Status
Review
Sprint Status
To Do
Technical Debt
Work Item
Bug
Work Item
Epic
Work Item
Spike
Work Item
Task
Work Item
User Story
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
quality/issuebot!20
No description provided.