quality/os-autoinst-distri-fedora
4
0
Fork 2
Code Issues 32 Pull requests 8 Projects Releases Packages Activity Actions 1

rmdepcheck: report soft failure on pre-existing dep issue
All checks were successful
AI Code Review / ai-review (pull_request_target) Successful in 20s
Details
CI via Tox and perl / checkwiki (pull_request) Successful in 42s
Details
CI via Tox and perl / tox (pull_request) Successful in 1m32s
Details
CI via Tox and perl / perl (pull_request) Successful in 3m51s
Details

Browse source 
I changed rmdepcheck to exit 0 but print a "Warning:" if there
are pre-existing dependency issues. Let's pick that up here and
treat it as a softfail.

Technically it would be more 'correct' to parse the JSON output,
I guess, but then we have to (re-)construct the text output for
people to read...this is just easier.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
This commit is contained in:
Adam Williamson 2026-06-13 10:45:45 +02:00
commit 4fe9689c78
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
lib/rmdepcheck.pm
View file

@ -59,11 +59,14 @@ sub run_rmdepcheck {
}
$cmd .= ' > /tmp/rmdepcheck.txt';
my $res = script_run $cmd, 300;
my $message = script_output 'cat /tmp/rmdepcheck.txt';
if ($res) {
my $message = script_output 'cat /tmp/rmdepcheck.txt';
$test->record_resultfile('rmdepcheck', $message, result => 'fail');
die 'rmdepcheck failed, check previous frame for output';
}
elsif ($message =~ m/^Warning:/m) {
$test->record_resultfile('rmdepcheck', $message, result => 'softfail');
}
}
1;