quality/os-autoinst-distri-fedora
6
0
Fork 2
Code Issues 35 Pull requests 9 Projects Releases Packages Activity Actions 2

Add a test of a kickstart install with a bad package (#336) #523

Open
adamwill wants to merge 1 commit from kickstart-badpackage into main
pull from: kickstart-badpackage
merge into: quality:main
Conversation 6 Commits 1 Files changed 4 +34
adamwill commented 2026-04-21 01:17:22 +00:00
Owner
Copy link

As requested by anaconda team in #336, add a test of a kickstart
install that specifies a non-existent package. This should
trigger a non-fatal warning, shortly after installation starts,
which we can click through to complete the install.

Note this is broken in Fedora 43+
https://bugzilla.redhat.com/show_bug.cgi?id=2459944
so I created the needle manually from a Fedora 42 install with
the kickstart.

Signed-off-by: Adam Williamson awilliam@redhat.com

As requested by anaconda team in #336, add a test of a kickstart install that specifies a non-existent package. This should trigger a non-fatal warning, shortly after installation starts, which we can click through to complete the install. Note this is broken in Fedora 43+ https://bugzilla.redhat.com/show_bug.cgi?id=2459944 so I created the needle manually from a Fedora 42 install with the kickstart. Signed-off-by: Adam Williamson <awilliam@redhat.com>
Add a test of a kickstart install with a bad package (#336)
Some checks failed
CI via Tox and perl / tox (pull_request) Failing after 1m35s
Details
CI via Tox and perl / perl (pull_request) Successful in 3m50s
Details
CI via Tox and perl / checkwiki (pull_request) Failing after 35s
Details
a0eb352b58 
As requested by anaconda team in #336, add a test of a kickstart
install that specifies a non-existent package. This should
trigger a non-fatal warning, shortly after installation starts,
which we can click through to complete the install.

Note this is broken in Fedora 43+
https://bugzilla.redhat.com/show_bug.cgi?id=2459944
so I created the needle manually from a Fedora 42 install with
the kickstart.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
adamwill commented 2026-04-21 01:17:54 +00:00
Author
Owner
Copy link

Hmm, the needle isn't 1024x768, not sure if that'll cause problems. Once there's a fix for the bug I'll see if this works...if not, I'll replace the needle.

Hmm, the needle isn't 1024x768, not sure if that'll cause problems. Once there's a fix for the bug I'll see if this works...if not, I'll replace the needle.
adamwill commented 2026-04-21 01:19:24 +00:00
Author
Owner
Copy link

ah, wait, this can't work...

ah, wait, this can't work...
adamwill force-pushed kickstart-badpackage from a0eb352b58
Some checks failed
CI via Tox and perl / tox (pull_request) Failing after 1m35s
Details
CI via Tox and perl / perl (pull_request) Successful in 3m50s
Details
CI via Tox and perl / checkwiki (pull_request) Failing after 35s
Details
to 65b24d5382
All checks were successful
CI via Tox and perl / tox (pull_request) Successful in 1m29s
Details
CI via Tox and perl / perl (pull_request) Successful in 3m32s
Details
CI via Tox and perl / checkwiki (pull_request) Successful in 34s
Details
AI Code Review / ai-review (pull_request_target) Successful in 40s
Details
2026-04-21 01:27:12 +00:00 Compare
adamwill commented 2026-04-21 01:32:51 +00:00
Author
Owner
Copy link

Result report PR: quality/fedora_openqa#136

Result report PR: https://forge.fedoraproject.org/quality/fedora_openqa/pulls/136
forgejo-actions commented 2026-04-21 01:38:26 +00:00
Copy link

AI Code Review

📋 MR Summary

Adds a test case for Kickstart installations that include a non-existent package, expecting and bypassing a non-fatal warning.

  • Key Changes:
    • Added a new Kickstart test template install_kickstart_badpackage setting the BADPACKAGE variable.
    • Introduced a needle for the bad package confirmation dialog.
    • Modified the boot process to assert and click the warning dialog if BADPACKAGE is set.
  • Impact: templates, needles, tests/_boot_to_anaconda.pm
  • Risk Level: 🟢 Low - The changes introduce a new test case and isolate the interaction to when a specific variable is set, minimizing impact on other test suites.

Detailed Code Review

The implementation correctly maps the new kickstart test requirements and appropriately guards the interaction logic with the BADPACKAGE variable. The primary issue identified is a potential race condition/timeout during the assertion of the warning dialog, which could lead to test flakiness if the installer is slow to initialize.

📂 File Reviews

📄 `tests/_boot_to_anaconda.pm` - Adds an assertion to click the bad package warning dialog before waiting for the post-install bootloader.
  • Major [Testing]: Missing explicit timeout on assert_and_click. The default timeout (typically 30 seconds) might be insufficient if Anaconda takes longer to initialize, download stage2, and parse the Kickstart file before presenting the warning. This can lead to flaky test failures.
    • Suggestion: Add an explicit, generous timeout to assert_and_click to account for variable system performance during installer startup.
assert_and_click('anaconda_install_badpackage_confirm', timeout => 300) if (get_var('BADPACKAGE'));

✅ Summary

  • Overall Assessment: The logic is mostly sound, but a missing timeout on the UI interaction poses a risk of flaky test executions.
  • Priority Issues:
    • Add an explicit timeout to the assert_and_click call in _boot_to_anaconda.pm to prevent race conditions during installer startup.

🤖 AI Code Review | Generated with ai-code-review | Model: gemini-3.1-pro-preview

⚠️ AI-generated suggestions may be incorrect. Verify before applying. Not a replacement for human review.

## AI Code Review ### 📋 MR Summary Adds a test case for Kickstart installations that include a non-existent package, expecting and bypassing a non-fatal warning. - **Key Changes:** - Added a new Kickstart test template `install_kickstart_badpackage` setting the `BADPACKAGE` variable. - Introduced a needle for the bad package confirmation dialog. - Modified the boot process to assert and click the warning dialog if `BADPACKAGE` is set. - **Impact:** templates, needles, tests/_boot_to_anaconda.pm - **Risk Level:** 🟢 Low - The changes introduce a new test case and isolate the interaction to when a specific variable is set, minimizing impact on other test suites. ### Detailed Code Review The implementation correctly maps the new kickstart test requirements and appropriately guards the interaction logic with the `BADPACKAGE` variable. The primary issue identified is a potential race condition/timeout during the assertion of the warning dialog, which could lead to test flakiness if the installer is slow to initialize. #### 📂 File Reviews <details> <summary><strong>📄 `tests/_boot_to_anaconda.pm`</strong> - Adds an assertion to click the bad package warning dialog before waiting for the post-install bootloader.</summary> - **Major** [Testing]: Missing explicit timeout on `assert_and_click`. The default timeout (typically 30 seconds) might be insufficient if Anaconda takes longer to initialize, download stage2, and parse the Kickstart file before presenting the warning. This can lead to flaky test failures. - *Suggestion:* Add an explicit, generous timeout to `assert_and_click` to account for variable system performance during installer startup. ```` assert_and_click('anaconda_install_badpackage_confirm', timeout => 300) if (get_var('BADPACKAGE')); ```` </details> ### ✅ Summary - **Overall Assessment:** The logic is mostly sound, but a missing timeout on the UI interaction poses a risk of flaky test executions. - **Priority Issues:** - Add an explicit timeout to the `assert_and_click` call in `_boot_to_anaconda.pm` to prevent race conditions during installer startup. --- 🤖 **AI Code Review** | Generated with [ai-code-review](https://gitlab.com/redhat/edge/ci-cd/ai-code-review) | **Model:** `gemini-3.1-pro-preview` ⚠️ *AI-generated suggestions may be incorrect. Verify before applying. Not a replacement for human review.*
adamwill commented 2026-04-21 01:45:28 +00:00
Author
Owner
Copy link

Yeah, true. Fixing.

Yeah, true. Fixing.
adamwill force-pushed kickstart-badpackage from 65b24d5382
All checks were successful
CI via Tox and perl / tox (pull_request) Successful in 1m29s
Details
CI via Tox and perl / perl (pull_request) Successful in 3m32s
Details
CI via Tox and perl / checkwiki (pull_request) Successful in 34s
Details
AI Code Review / ai-review (pull_request_target) Successful in 40s
Details
to 67fcd650fd
All checks were successful
CI via Tox and perl / tox (pull_request) Successful in 1m27s
Details
CI via Tox and perl / perl (pull_request) Successful in 3m32s
Details
CI via Tox and perl / checkwiki (pull_request) Successful in 35s
Details
2026-04-21 01:46:06 +00:00 Compare
adamwill commented 2026-04-28 00:55:40 +00:00
Author
Owner
Copy link

Kinda blocked by https://bugzilla.redhat.com/show_bug.cgi?id=2459944 . I'd prefer the bug to be fixed before we merge the test, so we can check the test all the way, and update the needle if necessary.

Kinda blocked by https://bugzilla.redhat.com/show_bug.cgi?id=2459944 . I'd prefer the bug to be fixed before we merge the test, so we can check the test all the way, and update the needle if necessary.
All checks were successful
CI via Tox and perl / tox (pull_request) Successful in 1m27s
Details
CI via Tox and perl / perl (pull_request) Successful in 3m32s
Details
CI via Tox and perl / checkwiki (pull_request) Successful in 35s
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin kickstart-badpackage:kickstart-badpackage
git switch kickstart-badpackage

Merge

Merge the changes and update on Forgejo.
git switch main
git merge --no-ff kickstart-badpackage
git switch kickstart-badpackage
git rebase main
git switch main
git merge --ff-only kickstart-badpackage
git switch kickstart-badpackage
git rebase main
git switch main
git merge --no-ff kickstart-badpackage
git switch main
git merge --squash kickstart-badpackage
git switch main
git merge --ff-only kickstart-badpackage
git switch main
git merge kickstart-badpackage
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
ai-review-please

label for requesting AI code review

  
Closed As
Duplicate
Closed with the reason of Duplicate

  
Closed As
Fixed
Closed with the reason of Fixed

  
Closed As
Invalid
Closed with the reason of Invalid

  
easyfix

   
freeipa

issues or enhancement requests related to FreeIPA in some way

  
improvetest

some kind of improvement (but not bug fix) to an existing test

  
iot

issues relating to test enablement on Fedora IoT

  
newtest

requests for new tests

  
silverblue

issues relating to test enablement on Fedora Silverblue

  
tracker

tracker issue, only exists to track a set of related issues

  
Backlog Status
Needs Review
Work items that have been created or updated but need review, refinement, or approval before they can be considered ready for sprint planning.

  
Backlog Status
Ready
Work items that have been reviewed, refined, and are ready to be committed to a sprint. These items have clear requirements and can be worked on immediately when capacity is available.

  
chore

Work that needs to be done but doesn't add new functionality or fix bugs. Maintenance tasks that keep the system running smoothly and the codebase clean.

  
documentation

Work focused on creating, updating, or improving documentation for users, developers, or system administrators.

  
points
01
A task that is simple, small, and has very little uncertainty. It should be easy enough for any team member to pick up and complete quickly, without a lot of discussion or research.

  
points
02
This is a task that is slightly more complex or larger than a "1." It might involve two or three simple steps, but the outcome is still very clear and there's little uncertainty.

  
points
03
Medium-sized task with some noticeable complexity. It might require a bit more thought or collaboration. The steps are well-defined, but it's not a trivial change.

  
points
05
A significant piece of work. It has more complexity and a higher degree of uncertainty than smaller tasks. It might require some research, a design discussion, or collaboration across multiple teams.

  
points
08
Complex task with a lot of uncertainty. It's often the largest size that a team will consider for a single sprint. It likely requires a detailed breakdown and multiple team members to complete.

  
points
13
Any task that feels like it's a "13" or more is considered an Epic. These are too large and uncertain to be worked on in a single sprint and should be broken down.

  
Priority
Critical
This is for work that is urgent and of critical importance and so and must be addressed immediately with a higher priority than all other work, even if not originally planned for the current sprint.

  
Priority
High
This is for work that is critical and needs to be addressed in the next sprint. It's often for urgent bugs, important features, or a major piece of technical debt that is blocking other work.

  
Priority
Low
This is for work that is good to do but not urgent. It's a candidate for being worked on when there's extra time or when it rises in importance. It can stay in the backlog for a longer period.

  
Priority
Medium
This is for important work that should be done soon, but isn't as urgent as a high-priority item. It will likely be considered for the next 1-2 sprints.

  
Sprint Status
Blocked
Work items that cannot progress due to external dependencies, blockers, or issues that need resolution.

  
Sprint Status
Done
Work items that have been completed, reviewed, and integrated. No further work is needed within the current sprint.

  
Sprint Status
In Progress
Work items currently being worked on by a team member. Active development, research, or implementation is happening.

  
Sprint Status
Review
Work items that are complete but need review, testing, or approval before being marked as done.

  
Sprint Status
To Do
Work items that are committed to the sprint but haven't been started yet. These items are ready to be picked up by team members.

  
Technical Debt

Work that addresses shortcuts, workarounds, or suboptimal implementations that were done previously to meet deadlines. These items improve code quality, maintainability, or performance without adding new features.

  
Work Item
Bug
Issues where the system is not working as intended or designed. Bugs represent deviations from expected behavior.

  
Work Item
Epic
Large initiatives that are broken down into multiple smaller work items (user stories, tasks, bugs). Epics represent significant features or projects that span multiple sprints.

  
Work Item
Spike
Time-boxed research, investigation, or proof-of-concept work to reduce uncertainty or explore solutions. Spikes help inform future development decisions.

  
Work Item
Task
Used to break down larger user stories into smaller, manageable implementation pieces. They focus on the specific technical steps needed to deliver the user story's value.

  
Work Item
User Story
User-facing features or functionality that can be framed from a user perspective, describing what someone wants to accomplish and why.

No labels
ai-review-please
Closed As
Duplicate
Closed As
Fixed
Closed As
Invalid
easyfix
freeipa
improvetest
iot
newtest
silverblue
tracker
Backlog Status
Needs Review
Backlog Status
Ready
chore
documentation
points
01
points
02
points
03
points
05
points
08
points
13
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Sprint Status
Blocked
Sprint Status
Done
Sprint Status
In Progress
Sprint Status
Review
Sprint Status
To Do
Technical Debt
Work Item
Bug
Work Item
Epic
Work Item
Spike
Work Item
Task
Work Item
User Story
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
quality/os-autoinst-distri-fedora!523
No description provided.