Run the advisory_boot test on ELN updates (#538) #556

Merged

adamwill merged 1 commit from eln-advisory-boot into main 2026-05-20 01:28:04 +00:00

Conversation 3 Commits 1 Files changed 1 +31

adamwill commented 2026-05-20 00:26:55 +00:00

Owner

Copy link

Signed-off-by: Adam Williamson awilliam@redhat.com

Signed-off-by: Adam Williamson <awilliam@redhat.com>

adamwill added 1 commit 2026-05-20 00:26:55 +00:00

Run the advisory_boot test on ELN updates (#538) ... c0a1a458ce

Signed-off-by: Adam Williamson <awilliam@redhat.com>

adamwill commented 2026-05-20 00:48:30 +00:00

Author

Owner

Copy link

ah, hmm, this doesn't work because the flavor does not specify HDD_1 because it's mostly a build-and-test-an-image flavor where we don't do that. Not sure how I want to go about fixing this...

ah, hmm, this doesn't work because the flavor does not specify `HDD_1` because it's mostly a build-and-test-an-image flavor where we don't do that. Not sure how I want to go about fixing this...

adamwill force-pushed eln-advisory-boot from c0a1a458ce to 6b43a2a556 2026-05-20 00:55:56 +00:00 Compare

adamwill force-pushed eln-advisory-boot from 6b43a2a556 to d390f62567 2026-05-20 00:57:41 +00:00 Compare

adamwill referenced this pull request from quality/fedora_openqa 2026-05-20 01:07:45 +00:00

Add a minimal flavor for ELN (to run advisory_boot in) #141

adamwill commented 2026-05-20 01:07:56 +00:00

Author

Owner

Copy link

OK, tweaked it to use a new 'minimal' flavor, and added a matching scheduler PR.

OK, tweaked it to use a new 'minimal' flavor, and added a [matching scheduler PR](https://forge.fedoraproject.org/quality/fedora_openqa/pulls/141).

forgejo-actions commented 2026-05-20 01:15:06 +00:00

Copy link

AI Code Review

Detailed Code Review

The PR introduces the updates-minimal flavor to run the advisory_boot test on ELN updates. It successfully addresses the previously discussed functional blocker regarding the missing disk configuration by explicitly setting +HDD_1 and NUMDISKS in the updates-minimal flavor settings. The product and machine mappings for aarch64, 64bit, and bios are properly defined.

One detail to verify is that only the fedora-updates-minimal-x86_64-*-64bit profile has been scheduled within the ADVISORY_BOOT_TEST testsuite block. If testing on aarch64 or bios is also required, those profiles will need to be added to the profiles dictionary in that same block. The JSON syntax remains valid.

📂 File Reviews

📄 `templates-updates.fif.json` - Adds the `updates-minimal` flavor, links it to architectures/machines, and schedules the x86_64 64bit profile for the advisory_boot test.

• Minor [Suggestion]: Only the x86_64-*-64bit profile is scheduled to run the ADVISORY_BOOT_TEST. The products/machines for aarch64 and bios are defined but not added to the test scheduling.
  • Suggestion: If you intend to run the advisory boot test on aarch64 and bios as well, ensure you add them to the profiles block.

            "profiles": {
                "fedora-updates-minimal-x86_64-*-64bit": 5,
                "fedora-updates-minimal-aarch64-*-aarch64": 5,
                "fedora-updates-minimal-x86_64-*-bios": 5
            },

Questions:

• ❓ Is it intentional to only run the advisory boot test on x86_64 64bit, or should the newly defined aarch64 and bios profiles also be scheduled?

✅ Summary

• Overall Assessment: The changes successfully implement the updates-minimal flavor and address the missing disk variable block. No critical issues were identified.
• Minor Suggestions:
  • Confirm if aarch64 and bios profiles should also be scheduled for the ADVISORY_BOOT_TEST testsuite.

---

🤖 AI Code Review | Generated with ai-code-review | Model: gemini-3.1-pro-preview

⚠️ AI-generated suggestions may be incorrect. Verify before applying. Not a replacement for human review.

## AI Code Review ### Detailed Code Review The PR introduces the `updates-minimal` flavor to run the `advisory_boot` test on ELN updates. It successfully addresses the previously discussed functional blocker regarding the missing disk configuration by explicitly setting `+HDD_1` and `NUMDISKS` in the `updates-minimal` flavor settings. The product and machine mappings for `aarch64`, `64bit`, and `bios` are properly defined. One detail to verify is that only the `fedora-updates-minimal-x86_64-*-64bit` profile has been scheduled within the `ADVISORY_BOOT_TEST` testsuite block. If testing on `aarch64` or `bios` is also required, those profiles will need to be added to the `profiles` dictionary in that same block. The JSON syntax remains valid. #### 📂 File Reviews <details> <summary><strong>📄 `templates-updates.fif.json`</strong> - Adds the `updates-minimal` flavor, links it to architectures/machines, and schedules the x86_64 64bit profile for the advisory_boot test.</summary> - **Minor** [Suggestion]: Only the `x86_64-*-64bit` profile is scheduled to run the `ADVISORY_BOOT_TEST`. The products/machines for `aarch64` and `bios` are defined but not added to the test scheduling. - *Suggestion:* If you intend to run the advisory boot test on `aarch64` and `bios` as well, ensure you add them to the `profiles` block. ```` "profiles": { "fedora-updates-minimal-x86_64-*-64bit": 5, "fedora-updates-minimal-aarch64-*-aarch64": 5, "fedora-updates-minimal-x86_64-*-bios": 5 }, ```` **Questions:** - ❓ Is it intentional to only run the advisory boot test on x86_64 64bit, or should the newly defined `aarch64` and `bios` profiles also be scheduled? </details> ### ✅ Summary - **Overall Assessment:** The changes successfully implement the `updates-minimal` flavor and address the missing disk variable block. No critical issues were identified. - **Minor Suggestions:** - Confirm if `aarch64` and `bios` profiles should also be scheduled for the `ADVISORY_BOOT_TEST` testsuite. --- 🤖 **AI Code Review** | Generated with [ai-code-review](https://gitlab.com/redhat/edge/ci-cd/ai-code-review) | **Model:** `gemini-3.1-pro-preview` ⚠️ *AI-generated suggestions may be incorrect. Verify before applying. Not a replacement for human review.*

adamwill force-pushed eln-advisory-boot from d390f62567 to c09193aae8 2026-05-20 01:17:29 +00:00 Compare

adamwill force-pushed eln-advisory-boot from c09193aae8 to ca23741c80 2026-05-20 01:17:43 +00:00 Compare

adamwill force-pushed eln-advisory-boot from ca23741c80 to 854cc205b0 2026-05-20 01:19:55 +00:00 Compare

adamwill referenced this pull request 2026-05-20 01:25:59 +00:00

ELN coverage: run at least one BIOS test on composes, run advisory_boot on updates #538

adamwill merged commit 854cc205b0 into main 2026-05-20 01:28:04 +00:00

adamwill deleted branch eln-advisory-boot 2026-05-20 01:28:05 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Closed As

Duplicate

Closed with the reason of Duplicate

  

Closed As

Fixed

Closed with the reason of Fixed

  

Closed As

Invalid

Closed with the reason of Invalid

  

easyfix

  

freeipa

issues or enhancement requests related to FreeIPA in some way

  

improvetest

some kind of improvement (but not bug fix) to an existing test

  

iot

issues relating to test enablement on Fedora IoT

  

newtest

requests for new tests

  

silverblue

issues relating to test enablement on Fedora Silverblue

  

tracker

tracker issue, only exists to track a set of related issues

  

ai-review-please

Request AI review for a pull request

  

Backlog Status

Needs Review

Work items that have been created or updated but need review, refinement, or approval before they can be considered ready for sprint planning.

  

Backlog Status

Ready

Work items that have been reviewed, refined, and are ready to be committed to a sprint. These items have clear requirements and can be worked on immediately when capacity is available.

  

chore

Work that needs to be done but doesn't add new functionality or fix bugs. Maintenance tasks that keep the system running smoothly and the codebase clean.

  

documentation

Work focused on creating, updating, or improving documentation for users, developers, or system administrators.

  

points

01

A task that is simple, small, and has very little uncertainty. It should be easy enough for any team member to pick up and complete quickly, without a lot of discussion or research.

  

points

02

This is a task that is slightly more complex or larger than a "1." It might involve two or three simple steps, but the outcome is still very clear and there's little uncertainty.

  

points

03

Medium-sized task with some noticeable complexity. It might require a bit more thought or collaboration. The steps are well-defined, but it's not a trivial change.

  

points

05

A significant piece of work. It has more complexity and a higher degree of uncertainty than smaller tasks. It might require some research, a design discussion, or collaboration across multiple teams.

  

points

08

Complex task with a lot of uncertainty. It's often the largest size that a team will consider for a single sprint. It likely requires a detailed breakdown and multiple team members to complete.

  

points

13

Any task that feels like it's a "13" or more is considered an Epic. These are too large and uncertain to be worked on in a single sprint and should be broken down.

  

Priority

Critical

This is for work that is urgent and of critical importance and so and must be addressed immediately with a higher priority than all other work, even if not originally planned for the current sprint.

  

Priority

High

This is for work that is critical and needs to be addressed in the next sprint. It's often for urgent bugs, important features, or a major piece of technical debt that is blocking other work.

  

Priority

Low

This is for work that is good to do but not urgent. It's a candidate for being worked on when there's extra time or when it rises in importance. It can stay in the backlog for a longer period.

  

Priority

Medium

This is for important work that should be done soon, but isn't as urgent as a high-priority item. It will likely be considered for the next 1-2 sprints.

  

Sprint Status

Blocked

Work items that cannot progress due to external dependencies, blockers, or issues that need resolution.

  

Sprint Status

Done

Work items that have been completed, reviewed, and integrated. No further work is needed within the current sprint.

  

Sprint Status

In Progress

Work items currently being worked on by a team member. Active development, research, or implementation is happening.

  

Sprint Status

Review

Work items that are complete but need review, testing, or approval before being marked as done.

  

Sprint Status

To Do

Work items that are committed to the sprint but haven't been started yet. These items are ready to be picked up by team members.

  

Technical Debt

Work that addresses shortcuts, workarounds, or suboptimal implementations that were done previously to meet deadlines. These items improve code quality, maintainability, or performance without adding new features.

  

Work Item

Bug

Issues where the system is not working as intended or designed. Bugs represent deviations from expected behavior.

  

Work Item

Epic

Large initiatives that are broken down into multiple smaller work items (user stories, tasks, bugs). Epics represent significant features or projects that span multiple sprints.

  

Work Item

Spike

Time-boxed research, investigation, or proof-of-concept work to reduce uncertainty or explore solutions. Spikes help inform future development decisions.

  

Work Item

Task

Used to break down larger user stories into smaller, manageable implementation pieces. They focus on the specific technical steps needed to deliver the user story's value.

  

Work Item

User Story

User-facing features or functionality that can be framed from a user perspective, describing what someone wants to accomplish and why.

No labels

Closed As

Duplicate

Closed As

Fixed

Closed As

Invalid

easyfix

freeipa

improvetest

iot

newtest

silverblue

tracker

ai-review-please

Backlog Status

Needs Review

Backlog Status

Ready

chore

documentation

points

01

points

02

points

03

points

05

points

08

points

13

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Sprint Status

Blocked

Sprint Status

Done

Sprint Status

In Progress

Sprint Status

Review

Sprint Status

To Do

Technical Debt

Work Item

Bug

Work Item

Epic

Work Item

Spike

Work Item

Task

Work Item

User Story

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

quality/os-autoinst-distri-fedora!556

No description provided.