quality/rmdepcheck
5
0
Fork 1
Code Issues 10 Pull requests 1 Projects Releases Packages Activity Actions

Add optional support for testing build dependencies #10

New issue
Closed
opened 2026-03-09 15:49:05 +00:00 by adamwill · 2 comments
adamwill commented 2026-03-09 15:49:05 +00:00
Owner
Copy link

Per discussion in #8 , @lbalhar would find it useful for rmdepcheck to have the ability to check build dependencies - that is, report when the tested package set would break the build dependencies of another package.

The design needs to be carefully considered here as we likely do not want to report this as a 'failure', and possibly not even run it, on Bodhi updates. It's envisaged to be mainly of use for running on pull requests, not so much as a "test" but more as information to the maintainer. As a first thought, we probably want to:

  • Make it configurable whether this check runs at all
  • Clearly separate its results from the run-time dependency results
  • Make it configurable whether this check 'failing' results in a non-zero exit code
Per discussion in https://forge.fedoraproject.org/quality/rmdepcheck/issues/8 , @lbalhar would find it useful for rmdepcheck to have the ability to check build dependencies - that is, report when the tested package set would break the build dependencies of another package. The design needs to be carefully considered here as we likely do not want to report this as a 'failure', and possibly not even run it, on Bodhi updates. It's envisaged to be mainly of use for running on pull requests, not so much as a "test" but more as information to the maintainer. As a first thought, we probably want to: * Make it configurable whether this check runs at all * Clearly separate its results from the run-time dependency results * Make it configurable whether this check 'failing' results in a non-zero exit code
lbalhar commented 2026-03-10 08:54:21 +00:00
Contributor
Copy link

Thanks for this. I'd really like to see both runtime and buildtime deps check in PRs. From my point of view, making another package FTBFS is not as bad as making it FTI, but it's also an unpleasant surprise for other maintainers I'd like to avoid and this tool can help me achieve this.

Thanks for this. I'd really like to see both runtime and buildtime deps check in PRs. From my point of view, making another package FTBFS is not as bad as making it FTI, but it's also an unpleasant surprise for other maintainers I'd like to avoid and this tool can help me achieve this.
adamwill commented 2026-03-17 19:06:35 +00:00
Author
Owner
Copy link

So, #12 is kinda all we need on the rmdepcheck side for this, I think. Anything else turns out to be on the test harness side. To detect build dependency failures, just include the appropriate source repository as one of the baserepos.

If you don't want to detect build dep failures, just don't do that. If you want to detect them but not fail on them, I guess you can run twice - once for binary-only, once for binary+src - and only fail if the binary-only run fails (treat the binary+src run as informational). Or you can use the JSON output and parse it a bit - you can just read the package names and check whether they have ".src" in them. If all the errors have ".src" in their package names, you only have build dependency failures...

So, https://forge.fedoraproject.org/quality/rmdepcheck/pulls/12 is kinda all we need on the rmdepcheck side for this, I think. Anything else turns out to be on the test harness side. To detect build dependency failures, just include the appropriate source repository as one of the baserepos. If you don't want to detect build dep failures, just don't do that. If you want to detect them but not fail on them, I guess you can run twice - once for binary-only, once for binary+src - and only fail if the binary-only run fails (treat the binary+src run as informational). Or you can use the JSON output and parse it a bit - you can just read the package names and check whether they have ".src" in them. If all the errors have ".src" in their package names, you only have build dependency failures...
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
long-arg-debug
eln-wrapper
alternate-base
nonchecked-base
el9-fix-adam
el9-fix-cursor
ai-code-review-test
binary-test
verbose
1.1.0
1.0.2
1.0.1
1.0.0
Labels
Clear labels
  
ai-review-please
Request AI review for a pull request

  
Backlog Status
Needs Review
 Work items that have been created or updated but need review, refinement, or approval before they can be considered ready for sprint planning.

  
Backlog Status
Ready
 Work items that have been reviewed, refined, and are ready to be committed to a sprint. These items have clear requirements and can be worked on immediately when capacity is available.

  
chore
Work that needs to be done but doesn't add new functionality or fix bugs. Maintenance tasks that keep the system running smoothly and the codebase clean.

  
documentation
Work focused on creating, updating, or improving documentation for users, developers, or system administrators.

  
points
01
 A task that is simple, small, and has very little uncertainty. It should be easy enough for any team member to pick up and complete quickly, without a lot of discussion or research.

  
points
02
 This is a task that is slightly more complex or larger than a "1." It might involve two or three simple steps, but the outcome is still very clear and there's little uncertainty.

  
points
03
 Medium-sized task with some noticeable complexity. It might require a bit more thought or collaboration. The steps are well-defined, but it's not a trivial change.

  
points
05
 A significant piece of work. It has more complexity and a higher degree of uncertainty than smaller tasks. It might require some research, a design discussion, or collaboration across multiple teams.

  
points
08
 Complex task with a lot of uncertainty. It's often the largest size that a team will consider for a single sprint. It likely requires a detailed breakdown and multiple team members to complete.

  
points
13
 Any task that feels like it's a "13" or more is considered an Epic. These are too large and uncertain to be worked on in a single sprint and should be broken down.

  
pr2jira
Sync this pull request to Jira for Agility tracking. Only use for PRs without a corresponding ticket.

  
Priority
Critical
 This is for work that is urgent and of critical importance and so and must be addressed immediately with a higher priority than all other work, even if not originally planned for the current sprint.

  
Priority
High
 This is for work that is critical and needs to be addressed in the next sprint. It's often for urgent bugs, important features, or a major piece of technical debt that is blocking other work.

  
Priority
Low
 This is for work that is good to do but not urgent. It's a candidate for being worked on when there's extra time or when it rises in importance. It can stay in the backlog for a longer period.

  
Priority
Medium
 This is for important work that should be done soon, but isn't as urgent as a high-priority item. It will likely be considered for the next 1-2 sprints.

  
Sprint Status
Blocked
 Work items that cannot progress due to external dependencies, blockers, or issues that need resolution.

  
Sprint Status
Done
 Work items that have been completed, reviewed, and integrated. No further work is needed within the current sprint.

  
Sprint Status
In Progress
 Work items currently being worked on by a team member. Active development, research, or implementation is happening.

  
Sprint Status
Review
 Work items that are complete but need review, testing, or approval before being marked as done.

  
Sprint Status
To Do
 Work items that are committed to the sprint but haven't been started yet. These items are ready to be picked up by team members.

  
Technical Debt
Work that addresses shortcuts, workarounds, or suboptimal implementations that were done previously to meet deadlines. These items improve code quality, maintainability, or performance without adding new features.

  
Work Item
Bug
 Issues where the system is not working as intended or designed. Bugs represent deviations from expected behavior.

  
Work Item
Epic
 Large initiatives that are broken down into multiple smaller work items (user stories, tasks, bugs). Epics represent significant features or projects that span multiple sprints.

  
Work Item
Spike
 Time-boxed research, investigation, or proof-of-concept work to reduce uncertainty or explore solutions. Spikes help inform future development decisions.

  
Work Item
Task
 Used to break down larger user stories into smaller, manageable implementation pieces. They focus on the specific technical steps needed to deliver the user story's value.

  
Work Item
User Story
 User-facing features or functionality that can be framed from a user perspective, describing what someone wants to accomplish and why.

No labels
ai-review-please
Backlog Status
Needs Review
Backlog Status
Ready
chore
documentation
points
01
points
02
points
03
points
05
points
08
points
13
pr2jira
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Sprint Status
Blocked
Sprint Status
Done
Sprint Status
In Progress
Sprint Status
Review
Sprint Status
To Do
Technical Debt
Work Item
Bug
Work Item
Epic
Work Item
Spike
Work Item
Task
Work Item
User Story
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
adamwill
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
quality/rmdepcheck#10
No description provided.