quality/rmdepcheck
5
0
Fork 1
Code Issues 10 Pull requests 1 Projects Releases Packages Activity Actions

parse_repoclosure: skip empty lines #41

Merged
adamwill merged 1 commit from pr-skip-empty-line into main 2026-05-13 01:42:18 +00:00
Conversation 3 Commits 1 Files changed 2 +3
adamwill commented 2026-05-13 01:26:19 +00:00
Owner
Copy link

Looks like we can get empty lines in the dnf repoclosure output
sometimes (not sure why). They break things, so we'll skip them.

Signed-off-by: Adam Williamson awilliam@redhat.com

Looks like we can get empty lines in the `dnf repoclosure` output sometimes (not sure why). They break things, so we'll skip them. Signed-off-by: Adam Williamson <awilliam@redhat.com>
parse_repoclosure: skip empty lines
Some checks failed
CI via Tox / tox (pull_request) Failing after 1m26s
Details
58055e1b8d 
Looks like we can get empty lines in the `dnf repoclosure` output
sometimes (not sure why). They break things, so we'll skip them.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
adamwill commented 2026-05-13 01:28:19 +00:00
Author
Owner
Copy link

Embarrassing admission: I do not actually understand why this causes bad results in parse_repoclosure, but somehow it does. I suspect handle_preexisting winds up doing something unexpected. I should maybe robustify that a bit.

Embarrassing admission: I do not actually understand *why* this causes bad results in `parse_repoclosure`, but somehow it does. I suspect `handle_preexisting` winds up doing something unexpected. I should maybe robustify that a bit.
adamwill force-pushed pr-skip-empty-line from 58055e1b8d
Some checks failed
CI via Tox / tox (pull_request) Failing after 1m26s
Details
to 0c8c61e741
All checks were successful
CI via Tox / tox (pull_request) Successful in 1m23s
Details
AI Code Review / ai-review (pull_request_target) Successful in 17s
Details
2026-05-13 01:33:22 +00:00 Compare
forgejo-actions commented 2026-05-13 01:36:42 +00:00
Copy link

AI Code Review

📋 MR Summary

This PR updates the parse_repoclosure function to skip empty lines in the dnf repoclosure output.

  • Key Changes:
    • Added a check to skip empty lines during the parsing of dnf repoclosure output in rmdepcheck.py.
    • Added an empty line to the test data file tests/testdata/test_parse_repoclosure.txt to verify the fix.
  • Impact: rmdepcheck.py, tests/testdata/test_parse_repoclosure.txt
  • Risk Level: 🟢 Low - The change simply skips empty lines during parsing, which is a common and safe practice when processing shell command output. It is backed by a test data addition.

Detailed Code Review

The change correctly addresses the issue of unexpected empty lines in the dnf repoclosure output by filtering them out early in the processing loop. This is a robust and straightforward approach to handling potential malformed input in a line-by-line parser. The inclusion of an empty line in the test data ensures this behavior is covered.

📂 File Reviews

📄 `rmdepcheck.py` - Updated `parse_repoclosure` to ignore empty or whitespace-only lines.
  • Minor [Logic]: The logic simply skips empty lines, which prevents subsequent matching logic from failing or behaving unpredictably. This correctly handles the blank lines.

✅ Summary

  • Overall Assessment: The changes introduce a simple and effective fix for empty lines in the parser input, with corresponding test data updates. No critical issues were identified.

🤖 AI Code Review | Generated with ai-code-review | Model: gemini-3.1-pro-preview

⚠️ AI-generated suggestions may be incorrect. Verify before applying. Not a replacement for human review.

## AI Code Review ### 📋 MR Summary This PR updates the `parse_repoclosure` function to skip empty lines in the `dnf repoclosure` output. - **Key Changes:** - Added a check to skip empty lines during the parsing of `dnf repoclosure` output in `rmdepcheck.py`. - Added an empty line to the test data file `tests/testdata/test_parse_repoclosure.txt` to verify the fix. - **Impact:** rmdepcheck.py, tests/testdata/test_parse_repoclosure.txt - **Risk Level:** 🟢 Low - The change simply skips empty lines during parsing, which is a common and safe practice when processing shell command output. It is backed by a test data addition. ### Detailed Code Review The change correctly addresses the issue of unexpected empty lines in the `dnf repoclosure` output by filtering them out early in the processing loop. This is a robust and straightforward approach to handling potential malformed input in a line-by-line parser. The inclusion of an empty line in the test data ensures this behavior is covered. #### 📂 File Reviews <details> <summary><strong>📄 `rmdepcheck.py`</strong> - Updated `parse_repoclosure` to ignore empty or whitespace-only lines.</summary> - **Minor** [Logic]: The logic simply skips empty lines, which prevents subsequent matching logic from failing or behaving unpredictably. This correctly handles the blank lines. </details> ### ✅ Summary - **Overall Assessment:** The changes introduce a simple and effective fix for empty lines in the parser input, with corresponding test data updates. No critical issues were identified. --- 🤖 **AI Code Review** | Generated with [ai-code-review](https://gitlab.com/redhat/edge/ci-cd/ai-code-review) | **Model:** `gemini-3.1-pro-preview` ⚠️ *AI-generated suggestions may be incorrect. Verify before applying. Not a replacement for human review.*
adamwill commented 2026-05-13 01:42:02 +00:00
Author
Owner
Copy link

Oh, wait, yeah, obviously I see why it causes problems: the empty line(s) are treated as a dependency issue. It/they won't get dropped out by handle_preexisting unless there's exactly one empty line in each raw output, I think. So in any other case we'll wind up printing something like:

New dependency problems in the tested packages themselves:
package: rust-cargo-vendor-filterer-devel-0.5.18-5.eln156.noarch from /var/tmp/rdcelnrepoi_l_nn_x/Extras

where each blank line is essentially "passed through" from a blank line in the raw output.

Oh, wait, yeah, obviously I see why it causes problems: the empty line(s) are treated as a dependency issue. It/they won't get dropped out by `handle_preexisting` unless there's exactly one empty line in each raw output, I think. So in any other case we'll wind up printing something like: ``` New dependency problems in the tested packages themselves: package: rust-cargo-vendor-filterer-devel-0.5.18-5.eln156.noarch from /var/tmp/rdcelnrepoi_l_nn_x/Extras ``` where each blank line is essentially "passed through" from a blank line in the raw output.
adamwill deleted branch pr-skip-empty-line 2026-05-13 01:42:18 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
  
ai-review-please
Request AI review for a pull request

  
Backlog Status
Needs Review
 Work items that have been created or updated but need review, refinement, or approval before they can be considered ready for sprint planning.

  
Backlog Status
Ready
 Work items that have been reviewed, refined, and are ready to be committed to a sprint. These items have clear requirements and can be worked on immediately when capacity is available.

  
chore
Work that needs to be done but doesn't add new functionality or fix bugs. Maintenance tasks that keep the system running smoothly and the codebase clean.

  
documentation
Work focused on creating, updating, or improving documentation for users, developers, or system administrators.

  
points
01
 A task that is simple, small, and has very little uncertainty. It should be easy enough for any team member to pick up and complete quickly, without a lot of discussion or research.

  
points
02
 This is a task that is slightly more complex or larger than a "1." It might involve two or three simple steps, but the outcome is still very clear and there's little uncertainty.

  
points
03
 Medium-sized task with some noticeable complexity. It might require a bit more thought or collaboration. The steps are well-defined, but it's not a trivial change.

  
points
05
 A significant piece of work. It has more complexity and a higher degree of uncertainty than smaller tasks. It might require some research, a design discussion, or collaboration across multiple teams.

  
points
08
 Complex task with a lot of uncertainty. It's often the largest size that a team will consider for a single sprint. It likely requires a detailed breakdown and multiple team members to complete.

  
points
13
 Any task that feels like it's a "13" or more is considered an Epic. These are too large and uncertain to be worked on in a single sprint and should be broken down.

  
Priority
Critical
 This is for work that is urgent and of critical importance and so and must be addressed immediately with a higher priority than all other work, even if not originally planned for the current sprint.

  
Priority
High
 This is for work that is critical and needs to be addressed in the next sprint. It's often for urgent bugs, important features, or a major piece of technical debt that is blocking other work.

  
Priority
Low
 This is for work that is good to do but not urgent. It's a candidate for being worked on when there's extra time or when it rises in importance. It can stay in the backlog for a longer period.

  
Priority
Medium
 This is for important work that should be done soon, but isn't as urgent as a high-priority item. It will likely be considered for the next 1-2 sprints.

  
Sprint Status
Blocked
 Work items that cannot progress due to external dependencies, blockers, or issues that need resolution.

  
Sprint Status
Done
 Work items that have been completed, reviewed, and integrated. No further work is needed within the current sprint.

  
Sprint Status
In Progress
 Work items currently being worked on by a team member. Active development, research, or implementation is happening.

  
Sprint Status
Review
 Work items that are complete but need review, testing, or approval before being marked as done.

  
Sprint Status
To Do
 Work items that are committed to the sprint but haven't been started yet. These items are ready to be picked up by team members.

  
Technical Debt
Work that addresses shortcuts, workarounds, or suboptimal implementations that were done previously to meet deadlines. These items improve code quality, maintainability, or performance without adding new features.

  
Work Item
Bug
 Issues where the system is not working as intended or designed. Bugs represent deviations from expected behavior.

  
Work Item
Epic
 Large initiatives that are broken down into multiple smaller work items (user stories, tasks, bugs). Epics represent significant features or projects that span multiple sprints.

  
Work Item
Spike
 Time-boxed research, investigation, or proof-of-concept work to reduce uncertainty or explore solutions. Spikes help inform future development decisions.

  
Work Item
Task
 Used to break down larger user stories into smaller, manageable implementation pieces. They focus on the specific technical steps needed to deliver the user story's value.

  
Work Item
User Story
 User-facing features or functionality that can be framed from a user perspective, describing what someone wants to accomplish and why.

No labels
ai-review-please
Backlog Status
Needs Review
Backlog Status
Ready
chore
documentation
points
01
points
02
points
03
points
05
points
08
points
13
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Sprint Status
Blocked
Sprint Status
Done
Sprint Status
In Progress
Sprint Status
Review
Sprint Status
To Do
Technical Debt
Work Item
Bug
Work Item
Epic
Work Item
Spike
Work Item
Task
Work Item
User Story
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
quality/rmdepcheck!41
No description provided.