quality/testdays-web
9
0
Fork 0
Code Issues 12 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Test Results for External Link (NOT WIKI TC) is not submitted #38

New issue
Closed
opened 2024-04-08 14:04:34 +00:00 by sumantrom · 7 comments
sumantrom commented 2024-04-08 14:04:34 +00:00
Copy link

When you have a test case which point to test case which is not a QA:Test Case, but a Doc or any external link, the app wont show the submitted result.

Ex: https://testdays.fedoraproject.org/events/179 --> Add results for "tutorials" --> The results gets submited but it doesnt show up.

When you have a test case which point to test case which is not a QA:Test Case, but a Doc or any external link, the app wont show the submitted result. Ex: https://testdays.fedoraproject.org/events/179 --> Add results for "tutorials" --> The results gets submited but it doesnt show up.
sumantrom commented 2024-04-10 01:55:11 +00:00
Author
Copy link

This was a supported feature till https://testdays.fedoraproject.org/events/169. Watch out for the AWS column.

This was a supported feature till https://testdays.fedoraproject.org/events/169. Watch out for the AWS column.
sumantrom commented 2024-06-08 02:39:15 +00:00
Author
Copy link

@frantisekz @jskladan ^^ please can this be fixed?

This is a regression and we are about to start Test Day season soon... it will be awesome to have this fixed!!

@frantisekz @jskladan ^^ please can this be fixed? This is a regression and we are about to start Test Day season soon... it will be awesome to have this fixed!!
kparal commented 2024-06-10 11:10:40 +00:00
Owner
Copy link

I agree this should be fixed, but at the same time I don't think this has Critical priority, because it can be very easily worked around by creating a wiki page which points to the external document. Sure, not ideal, but very simple.

I agree this should be fixed, but at the same time I don't think this has Critical priority, because it can be very easily worked around by creating a wiki page which points to the external document. Sure, not ideal, but very simple.
jskladan commented 2024-10-28 13:15:57 +00:00
Contributor
Copy link

@sumantrom I've finally had time to look into this. Nothing changed between the events, so the "external testcase urls" are supported still the same as before - which can be checked by submitting a result in the /169 AWS column (which gets successfully submitted and shown).

I tested this in here: https://testdays.fedoraproject.org/events/2 adding the "working" AWS test and the "now" not working Tutorials url (see metadata at: https://fedoraproject.org/w/index.php?title=User:Jskladan/Sandbox:TestdayAppMockTestday&oldid=723590 ) Once again, the AWS works.

Testdays was not implemented with external urls in mind (way back when we only used Wiki), so it is basically an accident (read - oversight/bug in the original code :D) that some work.

The "not working" testcase is caused by the trailing slash in the url - there is some weird interaction between testdays and resultsdb, that ends up eating the data (I don't have access to the resutlsdb instance in question, so can't really debut).

Changing the url to not have trailing slashes makes the external url "work".

I've pushed a rudimentary "hotfix": https://pagure.io/fedora-qa/testdays-web/c/a88f16b1ac301882ba4e865e16352e26fbb3f3b4

Tested with this metadata: https://fedoraproject.org/wiki/User:Jskladan/Sandbox:TestdayAppMockTestday (see "external 4") and the result submission works as expected. So this should be OK for any new Test Days.

@sumantrom I've finally had time to look into this. Nothing changed between the events, so the "external testcase urls" are supported still the same as before - which can be checked by submitting a result in the `/169` AWS column (which gets successfully submitted and shown). I tested this in here: https://testdays.fedoraproject.org/events/2 adding the "working" AWS test and the "now" not working Tutorials url (see metadata at: https://fedoraproject.org/w/index.php?title=User:Jskladan/Sandbox:TestdayAppMockTestday&oldid=723590 ) Once again, the AWS works. Testdays was not implemented with external urls in mind (way back when we only used Wiki), so it is basically an accident (read - oversight/bug in the original code :D) that some work. The "not working" testcase is caused by the trailing slash in the url - there is some weird interaction between testdays and resultsdb, that ends up eating the data (I don't have access to the resutlsdb instance in question, so can't really debut). Changing the url to not have trailing slashes makes the external url "work". I've pushed a rudimentary "hotfix": https://pagure.io/fedora-qa/testdays-web/c/a88f16b1ac301882ba4e865e16352e26fbb3f3b4 Tested with this metadata: https://fedoraproject.org/wiki/User:Jskladan/Sandbox:TestdayAppMockTestday (see "external 4") and the result submission works as expected. So this should be OK for any new Test Days.
jskladan commented 2024-10-28 13:16:04 +00:00
Contributor
Copy link

Metadata Update from @jskladan:

  • Issue assigned to jskladan
**Metadata Update from @jskladan**: - Issue assigned to jskladan
jskladan commented 2024-10-28 13:16:11 +00:00
Contributor
Copy link

Metadata Update from @jskladan:

  • Custom field story_points adjusted to 1
**Metadata Update from @jskladan**: - Custom field story_points adjusted to 1
jskladan commented 2024-10-28 13:36:22 +00:00
Contributor
Copy link

Metadata Update from @jskladan:

  • Issue close_status updated to: Fixed
  • Issue status updated to: Closed (was: Open)
**Metadata Update from @jskladan**: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
develop
feature/84-implement-markup-comments
staging
master
feature/fasusername
feature/faslogin_as_db_username
v1.1
v1.0
0.0.4
Labels
Clear labels   
ai-review-please

Request AI Review

  
Closed As
Duplicate
Closed with the reason of Duplicate

  
Closed As
Fixed
Closed with the reason of Fixed

  
Closed As
Invalid
Closed with the reason of Invalid

  
easyfix

   
enhancement
  
Backlog Status
Needs Review
Work items that have been created or updated but need review, refinement, or approval before they can be considered ready for sprint planning.

  
Backlog Status
Ready
Work items that have been reviewed, refined, and are ready to be committed to a sprint. These items have clear requirements and can be worked on immediately when capacity is available.

  
chore

Work that needs to be done but doesn't add new functionality or fix bugs. Maintenance tasks that keep the system running smoothly and the codebase clean.

  
documentation

Work focused on creating, updating, or improving documentation for users, developers, or system administrators.

  
points
01
A task that is simple, small, and has very little uncertainty. It should be easy enough for any team member to pick up and complete quickly, without a lot of discussion or research.

  
points
02
This is a task that is slightly more complex or larger than a "1." It might involve two or three simple steps, but the outcome is still very clear and there's little uncertainty.

  
points
03
Medium-sized task with some noticeable complexity. It might require a bit more thought or collaboration. The steps are well-defined, but it's not a trivial change.

  
points
05
A significant piece of work. It has more complexity and a higher degree of uncertainty than smaller tasks. It might require some research, a design discussion, or collaboration across multiple teams.

  
points
08
Complex task with a lot of uncertainty. It's often the largest size that a team will consider for a single sprint. It likely requires a detailed breakdown and multiple team members to complete.

  
points
13
Any task that feels like it's a "13" or more is considered an Epic. These are too large and uncertain to be worked on in a single sprint and should be broken down.

  
Priority
Critical
This is for work that is urgent and of critical importance and so and must be addressed immediately with a higher priority than all other work, even if not originally planned for the current sprint.

  
Priority
High
This is for work that is critical and needs to be addressed in the next sprint. It's often for urgent bugs, important features, or a major piece of technical debt that is blocking other work.

  
Priority
Low
This is for work that is good to do but not urgent. It's a candidate for being worked on when there's extra time or when it rises in importance. It can stay in the backlog for a longer period.

  
Priority
Medium
This is for important work that should be done soon, but isn't as urgent as a high-priority item. It will likely be considered for the next 1-2 sprints.

  
Sprint Status
Blocked
Work items that cannot progress due to external dependencies, blockers, or issues that need resolution.

  
Sprint Status
Done
Work items that have been completed, reviewed, and integrated. No further work is needed within the current sprint.

  
Sprint Status
In Progress
Work items currently being worked on by a team member. Active development, research, or implementation is happening.

  
Sprint Status
Review
Work items that are complete but need review, testing, or approval before being marked as done.

  
Sprint Status
To Do
Work items that are committed to the sprint but haven't been started yet. These items are ready to be picked up by team members.

  
Technical Debt

Work that addresses shortcuts, workarounds, or suboptimal implementations that were done previously to meet deadlines. These items improve code quality, maintainability, or performance without adding new features.

  
Work Item
Bug
Issues where the system is not working as intended or designed. Bugs represent deviations from expected behavior.

  
Work Item
Epic
Large initiatives that are broken down into multiple smaller work items (user stories, tasks, bugs). Epics represent significant features or projects that span multiple sprints.

  
Work Item
Spike
Time-boxed research, investigation, or proof-of-concept work to reduce uncertainty or explore solutions. Spikes help inform future development decisions.

  
Work Item
Task
Used to break down larger user stories into smaller, manageable implementation pieces. They focus on the specific technical steps needed to deliver the user story's value.

  
Work Item
User Story
User-facing features or functionality that can be framed from a user perspective, describing what someone wants to accomplish and why.

No labels
ai-review-please
Closed As
Duplicate
Closed As
Fixed
Closed As
Invalid
easyfix
enhancement
Backlog Status
Needs Review
Backlog Status
Ready
chore
documentation
points
01
points
02
points
03
points
05
points
08
points
13
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Sprint Status
Blocked
Sprint Status
Done
Sprint Status
In Progress
Sprint Status
Review
Sprint Status
To Do
Technical Debt
Work Item
Bug
Work Item
Epic
Work Item
Spike
Work Item
Task
Work Item
User Story
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
jskladan
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
quality/testdays-web#38
No description provided.