quality/testdays-web
6
0
Fork 0
Code Issues 11 Pull requests 2 Projects Releases Packages Wiki Activity Actions

Add banner to draft and upcoming testdays #128

Merged
jgroman merged 1 commit from feature/56-draft-event-banner into develop 2026-07-03 12:05:37 +00:00
Conversation 7 Commits 1 Files changed 3 +125 -1
jgroman commented 2026-06-30 13:44:14 +00:00
Owner
Copy link
  • Add banner to warn user when event is in draft state or not-yet-started
  • Add tests covering this feature

Fixes #56

Assisted-by: Claude Code

- Add banner to warn user when event is in draft state or not-yet-started - Add tests covering this feature Fixes #56 Assisted-by: Claude Code
jgroman self-assigned this 2026-06-30 13:44:14 +00:00
Add banner to draft and upcoming testdays
All checks were successful
Run tests / test (pull_request) Successful in 32s
Details
AI Code Review / ai-review (pull_request_target) Successful in 25s
Details
7cbdfc7601 
- Add banner to warn user when event is in draft state or not-yet-started
- Add tests covering this feature

Fixes #56

Assisted-by: Claude Code
jgroman changed title from WIP: Add banner to draft and upcoming testdays to Add banner to draft and upcoming testdays 2026-06-30 14:02:02 +00:00
forgejo-actions commented 2026-06-30 14:02:33 +00:00
Copy link

AI Code Review

📋 MR Summary

Adds warning banners to test day pages for events that are in 'draft' or 'upcoming' states.

  • Key Changes:
    • Added logic in testdays/controllers/main.py to calculate the event_state (draft, upcoming, live) based on the test day's draft status and start date.
    • Updated testdays/components/Testday.jinja to display Bulma-style message banners depending on the calculated event_state.
    • Added functional tests in tests/functional/test_main.py to ensure proper behavior across all event states.
  • Impact: testdays/controllers/main.py, testdays/components/Testday.jinja, tests/functional/test_main.py
  • Risk Level: 🟢 Low - The changes are primarily UI-focused (adding banners) and the accompanying logic is non-destructive and isolated. Test coverage is robust.

Detailed Code Review

The implementation correctly identifies the event's lifecycle state and adds clear, user-friendly banners to warn against premature test submissions. The functional tests are well-structured and cover the expected edge cases (draft, upcoming, live, and past).

One potential issue to verify is whether ZoneInfo is properly imported in testdays/controllers/main.py, as it was added to the module's logic without a corresponding import visible in the diff. If it's missing, it will cause a NameError at runtime.

📂 File Reviews

📄 `testdays/controllers/main.py` - Calculates `event_state` to be passed into the template.
  • Major [Bug]: The ZoneInfo class is used to fetch the timezone, but it is not imported in the visible diff. If ZoneInfo is not already imported at the top of the file, this will throw a NameError when triggered.
    • Suggestion: Ensure that ZoneInfo is imported from the zoneinfo module.
from zoneinfo import ZoneInfo

✅ Summary

  • Overall Assessment: The logic and functionality are sound and well-tested, but ensure the ZoneInfo module is imported to avoid runtime crashes.
  • Priority Issues:
    • Verify and potentially add the missing from zoneinfo import ZoneInfo import in testdays/controllers/main.py.
  • Minor Suggestions:
    • If the 'Etc/GMT+12' timezone logic is used in multiple places, consider extracting it to a constant or utility function to avoid duplication and maintain consistency.

🤖 AI Code Review | Generated with ai-code-review | Model: gemini-3.1-pro-preview

⚠️ AI-generated suggestions may be incorrect. Verify before applying. Not a replacement for human review.

## AI Code Review ### 📋 MR Summary Adds warning banners to test day pages for events that are in 'draft' or 'upcoming' states. - **Key Changes:** - Added logic in `testdays/controllers/main.py` to calculate the `event_state` (draft, upcoming, live) based on the test day's draft status and start date. - Updated `testdays/components/Testday.jinja` to display Bulma-style message banners depending on the calculated `event_state`. - Added functional tests in `tests/functional/test_main.py` to ensure proper behavior across all event states. - **Impact:** testdays/controllers/main.py, testdays/components/Testday.jinja, tests/functional/test_main.py - **Risk Level:** 🟢 Low - The changes are primarily UI-focused (adding banners) and the accompanying logic is non-destructive and isolated. Test coverage is robust. ### Detailed Code Review The implementation correctly identifies the event's lifecycle state and adds clear, user-friendly banners to warn against premature test submissions. The functional tests are well-structured and cover the expected edge cases (draft, upcoming, live, and past). One potential issue to verify is whether `ZoneInfo` is properly imported in `testdays/controllers/main.py`, as it was added to the module's logic without a corresponding import visible in the diff. If it's missing, it will cause a `NameError` at runtime. #### 📂 File Reviews <details> <summary><strong>📄 `testdays/controllers/main.py`</strong> - Calculates `event_state` to be passed into the template.</summary> - **Major** [Bug]: The `ZoneInfo` class is used to fetch the timezone, but it is not imported in the visible diff. If `ZoneInfo` is not already imported at the top of the file, this will throw a `NameError` when triggered. - *Suggestion:* Ensure that `ZoneInfo` is imported from the `zoneinfo` module. ```` from zoneinfo import ZoneInfo ```` </details> ### ✅ Summary - **Overall Assessment:** The logic and functionality are sound and well-tested, but ensure the `ZoneInfo` module is imported to avoid runtime crashes. - **Priority Issues:** - Verify and potentially add the missing `from zoneinfo import ZoneInfo` import in `testdays/controllers/main.py`. - **Minor Suggestions:** - If the 'Etc/GMT+12' timezone logic is used in multiple places, consider extracting it to a constant or utility function to avoid duplication and maintain consistency. --- 🤖 **AI Code Review** | Generated with [ai-code-review](https://gitlab.com/redhat/edge/ci-cd/ai-code-review) | **Model:** `gemini-3.1-pro-preview` ⚠️ *AI-generated suggestions may be incorrect. Verify before applying. Not a replacement for human review.*
jgroman changed title from Add banner to draft and upcoming testdays to WIP: Add banner to draft and upcoming testdays 2026-06-30 14:05:52 +00:00
jgroman commented 2026-07-01 12:33:25 +00:00
Author
Owner
Copy link
No description provided.
banner_draft.png
81 KiB
banner_draft.png
jgroman commented 2026-07-01 12:33:48 +00:00
Author
Owner
Copy link
No description provided.
banner_notlive.png
79 KiB
banner_notlive.png
jgroman changed title from WIP: Add banner to draft and upcoming testdays to Add banner to draft and upcoming testdays 2026-07-02 11:00:03 +00:00
jgroman requested review from kparal 2026-07-02 11:00:09 +00:00
adamwill commented 2026-07-02 19:13:40 +00:00
Owner
Copy link

LGTM 👍

LGTM 👍
jgroman merged commit 7cbdfc7601 into develop 2026-07-03 12:05:37 +00:00
jgroman deleted branch feature/56-draft-event-banner 2026-07-03 12:05:37 +00:00
kparal commented 2026-07-13 12:09:13 +00:00
Owner
Copy link

This is great, thanks a lot!

My only nitpick is that "This Test Day Is Not Live Yet" is hard for me to read with all the words capitalized 🙂️ But English-native users are probably more used to this.

This is great, thanks a lot! My only nitpick is that "This Test Day Is Not Live Yet" is hard for me to read with all the words capitalized 🙂️ But English-native users are probably more used to this.
adamwill commented 2026-07-13 14:59:08 +00:00
Owner
Copy link

No, I agree, it's weird to a native speaker too. Please use regular sentence capitalization.

No, I agree, it's weird to a native speaker too. Please use regular sentence capitalization.
kparal referenced this pull request from a commit 2026-07-14 08:14:59 +00:00
Make warning banners easier to read
kparal commented 2026-07-14 08:15:20 +00:00
Owner
Copy link

Pushed 60dfa4066c to address it.

Pushed 60dfa4066cd95dc8ba53752ce06bab0f3dfac51b to address it.
👍 1
Sign in to join this conversation.
Reviewers
No reviewers
kparal
Labels
Clear labels   
Closed As
Duplicate
 Closed with the reason of Duplicate

  
Closed As
Fixed
 Closed with the reason of Fixed

  
Closed As
Invalid
 Closed with the reason of Invalid

  
easyfix

   
enhancement
  
ai-review-please
Request AI review for a pull request

  
Backlog Status
Needs Review
 Work items that have been created or updated but need review, refinement, or approval before they can be considered ready for sprint planning.

  
Backlog Status
Ready
 Work items that have been reviewed, refined, and are ready to be committed to a sprint. These items have clear requirements and can be worked on immediately when capacity is available.

  
chore
Work that needs to be done but doesn't add new functionality or fix bugs. Maintenance tasks that keep the system running smoothly and the codebase clean.

  
documentation
Work focused on creating, updating, or improving documentation for users, developers, or system administrators.

  
points
01
 A task that is simple, small, and has very little uncertainty. It should be easy enough for any team member to pick up and complete quickly, without a lot of discussion or research.

  
points
02
 This is a task that is slightly more complex or larger than a "1." It might involve two or three simple steps, but the outcome is still very clear and there's little uncertainty.

  
points
03
 Medium-sized task with some noticeable complexity. It might require a bit more thought or collaboration. The steps are well-defined, but it's not a trivial change.

  
points
05
 A significant piece of work. It has more complexity and a higher degree of uncertainty than smaller tasks. It might require some research, a design discussion, or collaboration across multiple teams.

  
points
08
 Complex task with a lot of uncertainty. It's often the largest size that a team will consider for a single sprint. It likely requires a detailed breakdown and multiple team members to complete.

  
points
13
 Any task that feels like it's a "13" or more is considered an Epic. These are too large and uncertain to be worked on in a single sprint and should be broken down.

  
pr2jira
Sync this pull request to Jira for Agility tracking. Only use for PRs without a corresponding ticket.

  
Priority
Critical
 This is for work that is urgent and of critical importance and so and must be addressed immediately with a higher priority than all other work, even if not originally planned for the current sprint.

  
Priority
High
 This is for work that is critical and needs to be addressed in the next sprint. It's often for urgent bugs, important features, or a major piece of technical debt that is blocking other work.

  
Priority
Low
 This is for work that is good to do but not urgent. It's a candidate for being worked on when there's extra time or when it rises in importance. It can stay in the backlog for a longer period.

  
Priority
Medium
 This is for important work that should be done soon, but isn't as urgent as a high-priority item. It will likely be considered for the next 1-2 sprints.

  
Sprint Status
Blocked
 Work items that cannot progress due to external dependencies, blockers, or issues that need resolution.

  
Sprint Status
Done
 Work items that have been completed, reviewed, and integrated. No further work is needed within the current sprint.

  
Sprint Status
In Progress
 Work items currently being worked on by a team member. Active development, research, or implementation is happening.

  
Sprint Status
Review
 Work items that are complete but need review, testing, or approval before being marked as done.

  
Sprint Status
To Do
 Work items that are committed to the sprint but haven't been started yet. These items are ready to be picked up by team members.

  
Technical Debt
Work that addresses shortcuts, workarounds, or suboptimal implementations that were done previously to meet deadlines. These items improve code quality, maintainability, or performance without adding new features.

  
Work Item
Bug
 Issues where the system is not working as intended or designed. Bugs represent deviations from expected behavior.

  
Work Item
Epic
 Large initiatives that are broken down into multiple smaller work items (user stories, tasks, bugs). Epics represent significant features or projects that span multiple sprints.

  
Work Item
Spike
 Time-boxed research, investigation, or proof-of-concept work to reduce uncertainty or explore solutions. Spikes help inform future development decisions.

  
Work Item
Task
 Used to break down larger user stories into smaller, manageable implementation pieces. They focus on the specific technical steps needed to deliver the user story's value.

  
Work Item
User Story
 User-facing features or functionality that can be framed from a user perspective, describing what someone wants to accomplish and why.

No labels
Closed As
Duplicate
Closed As
Fixed
Closed As
Invalid
easyfix
enhancement
ai-review-please
Backlog Status
Needs Review
Backlog Status
Ready
chore
documentation
points
01
points
02
points
03
points
05
points
08
points
13
pr2jira
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Sprint Status
Blocked
Sprint Status
Done
Sprint Status
In Progress
Sprint Status
Review
Sprint Status
To Do
Technical Debt
Work Item
Bug
Work Item
Epic
Work Item
Spike
Work Item
Task
Work Item
User Story
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
jgroman
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
quality/testdays-web!128
No description provided.