Update local execution developer documentation #136

Merged
jgroman merged 1 commit from docs/123-update-local-execution-info into develop 2026-08-06 08:51:50 +00:00
Owner

Developer documentation is updated to reflect current recommended way to setup local development environment.
Added check for required tools in Makefile.

Fixes #123

Assisted-by: Claude Code

Developer documentation is updated to reflect current recommended way to setup local development environment. Added check for required tools in Makefile. Fixes #123 Assisted-by: Claude Code
jgroman self-assigned this 2026-07-31 11:06:07 +00:00
Update developer documentation
All checks were successful
Run tests / test (pull_request) Successful in 32s
e563f21b8e
Developer documentation is updated to reflect current recommended way to setup local development environment.
Added check for required tools in Makefile.

Fixes #123

Assisted-by: Claude Code
jgroman requested review from kparal 2026-07-31 11:09:36 +00:00
Author
Owner

Ready for review

Ready for review
Makefile Outdated
@ -40,0 +40,4 @@
# Skipped inside devcontainers where the DB is managed by compose directly.
_check_deps:
ifndef IS_DEVCONTAINER
@command -v $(firstword $(PODMAN_CMD)) >/dev/null 2>&1 \
Owner

what is going on here? what's the @command for? why are we calling firstword on PODMAN_CMD? won't that just check that flatpak-spawn runs, but not that it can run podman, if we're in a toolbox?

what is going on here? what's the `@command` for? why are we calling `firstword` on `PODMAN_CMD`? won't that just check that `flatpak-spawn` runs, but not that it can run podman, if we're in a toolbox?
Author
Owner

This is a good point! One could argue that inside toolbox podman is very likely available but yeah - this check was broken regardless. Fixed.

This is a good point! One could argue that inside toolbox podman is very likely available but yeah - this check was broken regardless. Fixed.
jgroman marked this conversation as resolved
adamwill left a comment

Don't have time to go through the rest and check it's accurate RN, sorry...if kparal doesn't I will later.

Don't have time to go through the rest and check it's accurate RN, sorry...if kparal doesn't I will later.
Fix review finding: podman detection inside toolbox
All checks were successful
Run tests / test (pull_request) Successful in 57s
f7395be6b7
adamwill approved these changes 2026-08-05 15:25:02 +00:00
adamwill left a comment

OK, this looks good to me. Thanks.

OK, this looks good to me. Thanks.
jgroman force-pushed docs/123-update-local-execution-info from f7395be6b7
All checks were successful
Run tests / test (pull_request) Successful in 57s
to 753e2d8000
All checks were successful
Run tests / test (pull_request) Successful in 33s
2026-08-06 08:32:46 +00:00
Compare
jgroman force-pushed docs/123-update-local-execution-info from 753e2d8000
All checks were successful
Run tests / test (pull_request) Successful in 33s
to 9aa326cb70
All checks were successful
Run tests / test (pull_request) Successful in 33s
2026-08-06 08:48:22 +00:00
Compare
jgroman merged commit 9aa326cb70 into develop 2026-08-06 08:51:50 +00:00
jgroman deleted branch docs/123-update-local-execution-info 2026-08-06 08:51:50 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
quality/testdays-web!136
No description provided.