in most of our repos, ci.yml fetches all git history #928
Labels
No labels
agile
anacondawebui
arm
blockerfe
Closed As
Duplicate
Closed As
Fixed
Closed As
Invalid
Closed As
Wontfix
Closed As
Worksforme
coreos
criteria
defect
easyfix
enhancement
iot
meeting
meta
onboarding call
proventesters
retrospective
silverblue
sponsor
test cases
test days
wiki
ai-review-please
Backlog Status
Needs Review
Backlog Status
Ready
chore
documentation
points
01
points
02
points
03
points
05
points
08
points
13
pr2jira
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Sprint Status
Blocked
Sprint Status
Done
Sprint Status
In Progress
Sprint Status
Review
Sprint Status
To Do
Technical Debt
Work Item
Bug
Work Item
Epic
Work Item
Spike
Work Item
Task
Work Item
User Story
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
quality/tickets#928
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
ci.ymlusually contains:That seems to mean Fetch all history for all tags and branches. For CI testing, only the last commit is necessary (it certainly works here). I believe the whole
can be dropped.
Affected repos:
Must fetch all history because of
diff-quality/diff-cover:os-autoinst-distri-fedorarmdepcheckfedora_openqa (multiple times)python-wikitcmsfedfindrelvalconsumerresultsdb_conventionsreleasestreampython-ci_messagesrelvalresultsdb_api@adamwill @jgroman Do you agree with the assessment? Should we start fixing the repos?
(It might also be good to bump it all to
uses: actions/checkout@v7while we edit the files).For repos where I designed the CI, at least, I believe I did this because it's unfortunately necessary for diff-quality to work (possibly also diff-cover). It needs both the PR branch and the main/master branch to be present. I could not find any other setting that ensures those two branches are present, unfortunately.
Oh, interesting. One would think there should be a configuration that fetches the main and the PR branch up to the common ancestor. But the checkout docs don't list that use case.
Ok, I crossed out repos which use
diff-quality/diff-cover. I'll update the rest, to make the checkout a little more efficient.All the PRs have been submitted and are ready, closing this.