releng/tickets
15
3
Fork 2
Code Issues 108 Pull requests Projects Releases Packages Wiki Activity Actions

find_unblocked_orphans.py generates false positive orphaned packages (due to 'or java-1.8.0-headless') #11460

New issue
Open
opened 2023-06-07 10:13:05 +00:00 by dwrobel · 10 comments
dwrobel commented 2023-06-07 10:13:05 +00:00
Copy link
  • Describe the issue

https://churchyard.fedorapeople.org/orphans-2023-06-07.txt contains false positive information that jssc is orphaned because it requires java-1.8.0:

jssc (maintained by: dwrobel)
jssc-2.8.0-26.fc39.x86_64 requires java-1.8.0-headless = 1:1.8.0.362.b09-2.fc38

The jssc was successfully re-compiled for rawhide (f39 against java-17:

$ curl -s https://kojipkgs.fedoraproject.org//packages/jssc/2.8.0/26.fc39/data/logs/x86_64/root.log  | grep openjdk
DEBUG util.py:445:   java-17-openjdk-devel      x86_64  1:17.0.7.0.7-5.fc39            build  4.7 M
DEBUG util.py:445:   java-17-openjdk            x86_64  1:17.0.7.0.7-5.fc39            build  440 k
DEBUG util.py:445:   java-17-openjdk-headless   x86_64  1:17.0.7.0.7-5.fc39            build   45 M
DEBUG util.py:445:    java-17-openjdk-1:17.0.7.0.7-5.fc39.x86_64                                    
DEBUG util.py:445:    java-17-openjdk-devel-1:17.0.7.0.7-5.fc39.x86_64                              
DEBUG util.py:445:    java-17-openjdk-headless-1:17.0.7.0.7-5.fc39.x86_64

See the Requires:

$ curl -s https://kojipkgs.fedoraproject.org//packages/jssc/2.8.0/26.fc39/data/logs/x86_64/build.log | grep -e '^Requires:' 
Requires: (java-headless or java-17-headless or java-11-headless or java-1.8.0-headless) javapackages-filesystem libc.so.6()(64bit) libc.so.6(GLIBC_2.15)(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.4)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) rtld(GNU_HASH)

Based on above 'Requires' the script https://pagure.io/releng/blob/main/f/scripts/find_unblocked_orphans.py should filter it out.

  • If we cannot complete your request, what is the impact?
$ curl -s https://churchyard.fedorapeople.org/orphans-2023-06-07.txt | grep 'requires java-1.8.0-headless' | wc -l
604

Pessimistically (assuming that all packages falls into the same category as jssc) 604 will be innocently orphaned. If above assumption is wrong (I checked it only for jssc), then at least jssc will be orphaned while it shouldn't.

* Describe the issue https://churchyard.fedorapeople.org/orphans-2023-06-07.txt contains false positive information that jssc is orphaned because it requires java-1.8.0: > jssc (maintained by: dwrobel) > jssc-2.8.0-26.fc39.x86_64 requires java-1.8.0-headless = 1:1.8.0.362.b09-2.fc38 The jssc was successfully re-compiled for rawhide (f39 against java-17: ``` $ curl -s https://kojipkgs.fedoraproject.org//packages/jssc/2.8.0/26.fc39/data/logs/x86_64/root.log | grep openjdk DEBUG util.py:445: java-17-openjdk-devel x86_64 1:17.0.7.0.7-5.fc39 build 4.7 M DEBUG util.py:445: java-17-openjdk x86_64 1:17.0.7.0.7-5.fc39 build 440 k DEBUG util.py:445: java-17-openjdk-headless x86_64 1:17.0.7.0.7-5.fc39 build 45 M DEBUG util.py:445: java-17-openjdk-1:17.0.7.0.7-5.fc39.x86_64 DEBUG util.py:445: java-17-openjdk-devel-1:17.0.7.0.7-5.fc39.x86_64 DEBUG util.py:445: java-17-openjdk-headless-1:17.0.7.0.7-5.fc39.x86_64 ``` See the Requires: ``` $ curl -s https://kojipkgs.fedoraproject.org//packages/jssc/2.8.0/26.fc39/data/logs/x86_64/build.log | grep -e '^Requires:' Requires: (java-headless or java-17-headless or java-11-headless or java-1.8.0-headless) javapackages-filesystem libc.so.6()(64bit) libc.so.6(GLIBC_2.15)(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.4)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) rtld(GNU_HASH) ``` Based on above 'Requires' the script https://pagure.io/releng/blob/main/f/scripts/find_unblocked_orphans.py should filter it out. * If we cannot complete your request, what is the impact? ``` $ curl -s https://churchyard.fedorapeople.org/orphans-2023-06-07.txt | grep 'requires java-1.8.0-headless' | wc -l 604 ``` Pessimistically (assuming that all packages falls into the same category as jssc) 604 will be innocently orphaned. If above assumption is wrong (I checked it only for jssc), then at least jssc will be orphaned while it shouldn't.
churchyard commented 2023-06-07 10:21:31 +00:00
Contributor
Copy link

Note that no listed package will actually be orphaned just because it is included in this output. Only packages that actually fail to install will get a bugzilla once that happens and will be orphaned weeks later if the bugzilla is ignored.

Note that no listed package will actually be orphaned just because it is included in this output. Only packages that actually fail to install will get a bugzilla once that happens and will be orphaned weeks later if the bugzilla is ignored.
dwrobel commented 2023-06-07 10:43:01 +00:00
Author
Copy link

@churchyard , thanks for the clarification.

We could, at least, spare the log analysis for the people who are curious why their package is included in this list.

@churchyard , thanks for the clarification. We could, at least, spare the log analysis for the people who are curious why their package is included in this list.
phsmoura commented 2023-06-07 18:05:14 +00:00
Copy link

Metadata Update from @phsmoura:

  • Issue tagged with: low-gain, low-trouble, ops
**Metadata Update from @phsmoura**: - Issue tagged with: low-gain, low-trouble, ops
churchyard commented 2023-06-08 06:39:01 +00:00
Contributor
Copy link

Yes. However, the script is very old and I am unsure if it is possible to simply fix this without rewriting it from scratch.

Definitively not a low-trouble task.

Yes. However, the script is very old and I am unsure if it is possible to simply fix this without rewriting it from scratch. Definitively not a low-trouble task.
humaton commented 2023-06-28 12:06:46 +00:00
Owner
Copy link

Metadata Update from @humaton:

  • Issue untagged with: low-gain, low-trouble
  • Issue tagged with: dev, high-trouble, medium-gain
**Metadata Update from @humaton**: - Issue **un**tagged with: low-gain, low-trouble - Issue tagged with: dev, high-trouble, medium-gain
amedvede commented 2025-11-10 16:39:16 +00:00
Owner
Copy link

Metadata Update from @amedvede:

  • Issue tagged with: review
**Metadata Update from @amedvede**: - Issue tagged with: review
jnsamyak added this to the Backlog project 2026-03-19 11:59:16 +00:00
jnsamyak commented 2026-03-19 12:23:51 +00:00
Owner
Copy link

the newer place for the script is changed, and can be found here: https://forge.fedoraproject.org/releng/tooling/src/branch/main/packages/orphaned/find_unblocked_orphans.py

the newer place for the script is changed, and can be found here: https://forge.fedoraproject.org/releng/tooling/src/branch/main/packages/orphaned/find_unblocked_orphans.py
humaton commented 2026-03-19 12:29:38 +00:00
Owner
Copy link

This is the new home for the culprint we discussed it on todays refinement meeting, it will land in one of next sprints.

This is the new home for the [culprint ](https://forge.fedoraproject.org/releng/tooling/src/branch/main/packages/orphaned/find_unblocked_orphans.py) we discussed it on todays refinement meeting, it will land in one of next sprints.
amedvede removed their assignment 2026-04-16 22:00:10 +00:00
amedvede added this to the Backlog project 2026-04-16 22:00:17 +00:00
jnsamyak commented 2026-04-21 09:54:51 +00:00
Owner
Copy link

@churchyard I looked into this last week and I think we can fix it without a full rewrite.

I think we would be able to solve this by adding two helper methods that use DNF's existing filter(provides=...) to check if requirements can be satisfied by other packages first one checks if a specific provide has alternatives available, second one verifies if a dependent package's full requirement set can be met without the orphaneed packages. This handles both simple alternative providers and rich dependencies.

No changes to the scripts interface or how it outputs results keeps everything backward compateible. We can look into log analysis if required as part 2? What do you think? Does this approach make sense or am I missing something?

@churchyard I looked into this last week and I think we can fix it without a full rewrite. I think we would be able to solve this by adding two helper methods that use DNF's existing filter(provides=...) to check if requirements can be satisfied by other packages first one checks if a specific provide has alternatives available, second one verifies if a dependent package's full requirement set can be met without the orphaneed packages. This handles both simple alternative providers and rich dependencies. No changes to the scripts interface or how it outputs results keeps everything backward compateible. We can look into log analysis if required as part 2? What do you think? Does this approach make sense or am I missing something?
churchyard commented 2026-04-21 10:36:59 +00:00
Contributor
Copy link

It's worth trying 👍

It's worth trying 👍
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
modular-tags-at-branchtime
product-release
createrepoc
bz-epel
branch-eol-sop
multiline-sop
weird-loop
container-branching
unretire
blocking-for-f27
json-json-json
orphan-management
find-failures-owners
cvsadmin
twoweek-stable
rawhide-stable
Labels
Clear labels   
after freeze

   
automation

   
backlog

Tasks that will take longer then ~4 hours to do

  
blocked

   
change-ack

Changes that have releng work and are accepted

  
change-nak

Changes that have releng work and have been rejected

  
change-noreleng

Changes that do not have any releng work

  
changes
  
Closed As
Can't Fix
Closed with the reason of Can't Fix

  
Closed As
Duplicate
Closed with the reason of Duplicate

  
Closed As
Fixed
Closed with the reason of Fixed

  
Closed As
Fixed with Explanation
Closed with the reason of Fixed with Explanation

  
Closed As
Get back later
Closed with the reason of Get back later

  
Closed As
Grooming
Closed with the reason of Grooming

  
Closed As
Insufficient data
Closed with the reason of Insufficient data

  
Closed As
Invalid
Closed with the reason of Invalid

  
Closed As
It's all good
Closed with the reason of It's all good

  
Closed As
taiga
Closed with the reason of taiga

  
Closed As
upstream
Closed with the reason of upstream

  
day-to-day

These are small, self-contained tasks that are part of normal operations but are async from sprint planning.

  
dev

   
docs

   
easyfix

   
epel

   
f26

   
f27

Fedora 27

  
f28

Fedora 28

  
f29

Fedora 29

  
f30

   
f31

   
f32

   
f33

Fedora 33

  
f34

   
f35

Fedora 35

  
f36

   
f37

   
f38

   
f39

Fedora 39

  
f40

   
f41

Fedora 41

  
f42

Fedora 42

  
f43

Fedora 43

  
f44

Fedora 44

  
f45

Fedora 45

  
fedora

   
groomed

   
high-gain

   
high-trouble

   
in-progress

   
in-review

   
investigation

   
legal

   
low-gain

   
low-trouble

   
mass rebuild

   
medium-gain

   
medium-trouble

   
meeting

   
mini-initiative

   
new_artifact

New artifact for fedora release

  
ops

   
pdc_retirement

   
rawhide

   
RCA

Root cause analysis

  
review

   
script

   
sidetarget

   
sprint-0

   
sprint-1

Releng Sprint 1 Tracker

  
sprint-2

Sprint 2

  
sprint-3

Releng Sprint 3 Tracker

  
sprint-4

RelEng Spring 4 Tracker

  
sprint-5

RelEng Sprint Tracker 5 (Nov 18 - Dec 02)

  
unfrozen

Revisit after freeze

  
waiting on external
  
Backlog Status
Needs Review
Needs to go through refinement

  
Backlog Status
Ready
Ready for sprint

  
chore

   
documentation
  
points
01
A task that is simple, small, and has very little uncertainty. It should be easy enough for any team member to pick up and complete quickly, without a lot of discussion or research.

  
points
02
This is a task that is slightly more complex or larger than a "1." It might involve two or three simple steps, but the outcome is still very clear and there's little uncertainty.

  
points
03
Medium-sized task with some noticeable complexity. It might require a bit more thought or collaboration. The steps are well-defined, but it's not a trivial change.

  
points
05
A significant piece of work. It has more complexity and a higher degree of uncertainty than smaller tasks. It might require some research, a design discussion, or collaboration across multiple teams.

  
points
08
Complex task with a lot of uncertainty. It's often the largest size that a team will consider for a single sprint. It likely requires a detailed breakdown and multiple team members to complete.

  
points
13
Any task that feels like it's a "13" or more is considered an Epic. These are too large and uncertain to be worked on in a single sprint and should be broken down.

  
Priority
High
This is for work that is critical and needs to be addressed in the next sprint. It's often for urgent bugs, important features, or a major piece of technical debt that is blocking other work.

  
Priority
Low
This is for work that is good to do but not urgent. It's a candidate for being worked on when there's extra time or when it rises in importance. It can stay in the backlog for a longer period.

  
Priority
Medium
This is for important work that should be done soon, but isn't as urgent as a high-priority item. It will likely be considered for the next 1-2 sprints.

  
Sprint Status
Blocked
Work items that cannot progress due to external dependencies, blockers, or issues that need resolution.

  
Sprint Status
Done
Work items that have been completed, reviewed, and integrated. No further work is needed within the current sprint.

  
Sprint Status
In Progress
Work items currently being worked on by a team member. Active development, research, or implementation is happening.

  
Sprint Status
Review
Work items that are complete but need review, testing, or approval before being marked as done.

  
Sprint Status
To Do
Work items that are committed to the sprint but haven't been started yet. These items are ready to be picked up by team members.

  
Technical Debt

Work that addresses shortcuts, workarounds, or suboptimal implementations that were done previously to meet deadlines. These items improve code quality, maintainability, or performance without adding new features.

  
Work Item
Bug
Issues where the system is not working as intended or designed. Bugs represent deviations from expected behavior.

  
Work Item
Epic
Large initiatives that are broken down into multiple smaller work items (user stories, tasks, bugs). Epics represent significant features or projects that span multiple sprints.

  
Work Item
Spike
Time-boxed research, investigation, or proof-of-concept work to reduce uncertainty or explore solutions. Spikes help inform future development decisions.

  
Work Item
Task
Used to break down larger user stories into smaller, manageable implementation pieces. They focus on the specific technical steps needed to deliver the user story's value.

  
Work Item
User Story
User-facing features or functionality that can be framed from a user perspective, describing what someone wants to accomplish and why.

No labels
after freeze
automation
backlog
blocked
change-ack
change-nak
change-noreleng
changes
Closed As
Can't Fix
Closed As
Duplicate
Closed As
Fixed
Closed As
Fixed with Explanation
Closed As
Get back later
Closed As
Grooming
Closed As
Insufficient data
Closed As
Invalid
Closed As
It's all good
Closed As
taiga
Closed As
upstream
day-to-day
dev
docs
easyfix
epel
f26
f27
f28
f29
f30
f31
f32
f33
f34
f35
f36
f37
f38
f39
f40
f41
f42
f43
f44
f45
fedora
groomed
high-gain
high-trouble
in-progress
in-review
investigation
legal
low-gain
low-trouble
mass rebuild
medium-gain
medium-trouble
meeting
mini-initiative
new_artifact
ops
pdc_retirement
rawhide
RCA
review
script
sidetarget
sprint-0
sprint-1
sprint-2
sprint-3
sprint-4
sprint-5
unfrozen
waiting on external
Backlog Status
Needs Review
Backlog Status
Ready
chore
documentation
points
01
points
02
points
03
points
05
points
08
points
13
Priority
High
Priority
Low
Priority
Medium
Sprint Status
Blocked
Sprint Status
Done
Sprint Status
In Progress
Sprint Status
Review
Sprint Status
To Do
Technical Debt
Work Item
Bug
Work Item
Epic
Work Item
Spike
Work Item
Task
Work Item
User Story
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Current Sprint ( 2026-05-04 to 2026-05-17 )
Assignees
Clear assignees
No assignees
jnsamyak
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
releng/tickets#11460
No description provided.