Fix Koji owner sync for unretirements (update package key to repo and separate branch handling) #13364
Labels
No labels
after freeze
automation
backlog
blocked
change-ack
change-nak
change-noreleng
changes
Closed As
Can't Fix
Closed As
Duplicate
Closed As
Fixed
Closed As
Fixed with Explanation
Closed As
Get back later
Closed As
Grooming
Closed As
Insufficient data
Closed As
Invalid
Closed As
It's all good
Closed As
taiga
Closed As
upstream
day-to-day
dev
docs
easyfix
epel
f26
f27
f28
f29
f30
f31
f32
f33
f34
f35
f36
f37
f38
f39
f40
f41
f42
f43
f44
f45
fedora
groomed
high-gain
high-trouble
in-progress
in-review
investigation
legal
low-gain
low-trouble
mass rebuild
medium-gain
medium-trouble
meeting
mini-initiative
new_artifact
ops
pdc_retirement
rawhide
RCA
review
script
sidetarget
sprint-0
sprint-1
sprint-2
sprint-3
sprint-4
sprint-5
unfrozen
waiting on external
Backlog Status
Needs Review
Backlog Status
Ready
chore
documentation
points
01
points
02
points
03
points
05
points
08
points
13
Priority
High
Priority
Low
Priority
Medium
Sprint Status
Blocked
Sprint Status
Done
Sprint Status
In Progress
Sprint Status
Review
Sprint Status
To Do
Technical Debt
Work Item
Bug
Work Item
Epic
Work Item
Spike
Work Item
Task
Work Item
User Story
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
releng/tickets#13364
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Following up on the issue identified in #13270. The post-close automation script in fedora-scm-requests currently fails to sync the package owner with Koji when an unretirement ticket is closed.
The Problem:
Key Mismatch: The script currently expects the package name value under the
namekey, but the correct key in the payload isrepo.Branch Processing: The script currently conflates dist-git branches with Koji tags, which causes processing errors during the ublocking tags.
Proposed Solution:
Update the script to fetch the package name using the
repokey instead ofname.Refactor the branch handling logic to cleanly divide and process Koji tags and dist-git branches separately to ensure the correct values are passed to the Koji API.
I changed the key for unretirement request, and separated branches on fedpkg side: PR https://pagure.io/fedpkg/pull-request/626#
also adjusted toddlers functionality to process new keys: PR apps/toddlers#428 (comment)
toddlerschanges are merged and ready;fedpkgchanges are also merged, waiting for a new patch offedpkgwith recent changes@amedvede left a comment at toddler PR, please take a look, and let me know what is blocking and left. Toddlers changes are not seemed to be merged, seems like a open PR.