Consolidate mass rebuild script configuration #13425

Open
opened 2026-07-12 09:12:47 +00:00 by patrikp · 3 comments
Member

While doing prep work for the F45 mass rebuild, I noticed that an improvement to the process could perhaps be made.

Currently the mass rebuild scripts [1] have inconsistent configuration approaches:

  • mass_rebuild.py imports from mass_rebuilds_info.py (centralized)
  • find_failures.py and need_rebuild.py have hardcoded variables at the top
  • mass_tag.py uses command line arguments (no changes necessarily needed)

This means updating variables in 3 places each cycle instead of 1.

Proposal: Refactor the other two (three?) scripts to also import from mass_rebuilds_info.py, similar to how mass_rebuild.py does it.

Benefits:

  • Single source of truth for buildtag, epoch, targets
  • Fewer places to update each cycle
  • Reduced risk of inconsistency between scripts

Complexity: Low — the scripts already share the same variable names.

This is not urgent; documenting for future discussion.

[1] https://forge.fedoraproject.org/releng/tooling/src/branch/main/release-process/mass-rebuilds

While doing prep work for the F45 mass rebuild, I noticed that an improvement to the process could perhaps be made. Currently the mass rebuild scripts [1] have inconsistent configuration approaches: - `mass_rebuild.py` imports from `mass_rebuilds_info.py` (centralized) - `find_failures.py` and `need_rebuild.py` have hardcoded variables at the top - `mass_tag.py` uses command line arguments (no changes necessarily needed) This means updating variables in 3 places each cycle instead of 1. **Proposal:** Refactor the other two (three?) scripts to also import from `mass_rebuilds_info.py`, similar to how `mass_rebuild.py` does it. **Benefits:** - Single source of truth for buildtag, epoch, targets - Fewer places to update each cycle - Reduced risk of inconsistency between scripts **Complexity:** Low — the scripts already share the same variable names. This is not urgent; documenting for future discussion. [1] https://forge.fedoraproject.org/releng/tooling/src/branch/main/release-process/mass-rebuilds
patrikp added this to the Backlog project 2026-07-12 09:12:48 +00:00

Hi! I'm a new collaborator, may I pick up this ticket?

Hi! I'm a new collaborator, may I pick up this ticket?

Opened a PR with a proposed fix releng/tooling#13045 let me know if there's anything to improve, thanks!

Opened a PR with a proposed fix https://forge.fedoraproject.org/releng/tooling/pulls/13045 let me know if there's anything to improve, thanks!
Owner

Okay, I did review it. Thanks for working on it. PTAL the feedback, address them, and then we can merge those up.

Okay, I did review it. Thanks for working on it. PTAL the feedback, address them, and then we can merge those up.
Sign in to join this conversation.
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
releng/tickets#13425
No description provided.