openh264 for fedora-46 (new rawhide) #13466
Labels
No labels
after freeze
automation
backlog
blocked
change-ack
change-nak
change-noreleng
changes
Closed As
Can't Fix
Closed As
Duplicate
Closed As
Fixed
Closed As
Fixed with Explanation
Closed As
Get back later
Closed As
Grooming
Closed As
Insufficient data
Closed As
Invalid
Closed As
It's all good
Closed As
taiga
Closed As
upstream
day-to-day
dev
docs
easyfix
epel
f26
f27
f28
f29
f30
f31
f32
f33
f34
f35
f36
f37
f38
f39
f40
f41
f42
f43
f44
f45
fedora
groomed
high-gain
high-trouble
in-progress
in-review
investigation
legal
low-gain
low-trouble
mass rebuild
medium-gain
medium-trouble
meeting
mini-initiative
new_artifact
ops
pdc_retirement
rawhide
RCA
review
script
sidetarget
sprint-0
sprint-1
sprint-2
sprint-3
sprint-4
sprint-5
unfrozen
waiting on external
Backlog Status
Needs Review
Backlog Status
Ready
chore
documentation
points
01
points
02
points
03
points
05
points
08
points
13
Priority
High
Priority
Low
Priority
Medium
release-process
Sprint Status
Blocked
Sprint Status
Done
Sprint Status
In Progress
Sprint Status
Review
Sprint Status
To Do
Technical Debt
Work Item
Bug
Work Item
Epic
Work Item
Spike
Work Item
Task
Work Item
User Story
No milestone
No project
No assignees
8 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
releng/tickets#13466
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
We need to do https://docs.fedoraproject.org/en-US/infra/releng_misc_guide/sop_openh264/ for fedora-46 (new rawhide) openh264.
I've done a build and it's in the f46-openh264 tag and should be signed by the f46 key, so it should be ready for that sop.
Also, note, we should try and fix: #12473
as part of this. that means we need to run the koji dist-repo with '--multilib=CONFIG' but I am not sure what CONFIG is, so we may need to test this in staging. We want mozilla-openh264-2.6.0-4.fc46.i686.rpm and openh264-2.6.0-4.fc46.i686.rpm to be in the x86_64 repo it makes.
Also remember to update mirrormanager afterwards so that fedora-cisco-openh264-rawhide points to https://codecs.fedoraproject.org/openh264/46 , I guess.
@adamwill, the mirror manager redirects should be set to it already; we just need to have these created.
I manually changed the openh264 redirect to use the f45 repo.
update repository_redirect set to_repo = 'fedora-cisco-openh264-45' where from_repo = 'fedora-cisco-openh264-rawhide';
With the idea that having a repo that resolves, but is not signed correctly is better than a repo that doesn't exist.
Once that repo does exist we will need to change it to the 46 one.
Here is how things stand. I created the F46 RPMs using
koji dist-repo(albeit for now not the 32 version). I have the tarball containing the RPMs ready. I sent an email to Cisco requesting an upload link, waiting for a reply./srv/web/codecs.fedoraproject.org/openh264/46directory also now exists on sundries, empty for now, but possibly the redirects can be set now. Or is anything else required for the redirects?@patrikp wrote in #13466 (comment):
I thought we could use the existing link they gave us before over? can you try uploading with that?
(If you don't have it I can try and find it)
Well, it's all down to which is better:
a) the repo points to something that doesn't exist yet and the client gets a 404 error
or
b) the repo points to the older one that exists fine, but has packages signed by the old key and the client may get a key error
I am not sure which is better in the end. ;( Perhaps @adamwill could weigh in? which is less bad for openqa?
You are correct. We already have the link and the workflow should be:
Upload the things, THEN send an email to Cisco to let them know.
The SOP is slightly outdated so I'll update it to reflect this.
I was able to find the link, used it to upload the tarball and list, and sent a reply to the original email I sent to let them know.
Thanks. (Note that I am not on that list, so do let me/us know what they say).
@kevin wrote in #13466 (comment):
they're equally bad, I think. anything that is going to lead to an error is bad. an empty repo would be fine for openqa but maybe not other cases?
@kevin Just to let you know, I received an email from Benzheng Zhang saying he has the RPMs and will upload them "later". I'll make a mental note to CC you in such communication, my oversight, sorry.
I believe the command with which we can verify would be:
$ curl -I http://ciscobinary.openh264.org/openh264-2.6.0-4.fc46.x86_64.rpmWhich should return:
HTTP/1.1 200 OKBut as of right now returns:
HTTP/1.1 403 ForbiddenOr is there a better way?
Yep. That sounds right. Or a note back from them that the packages are there.
Thinking about it more, I think at branching we should make a new empty repo for this. It would mean that things that try and install specifically openh264 wouldn't work, but the empty repo would mean there wouldn't be any 404 errors and without any packages there the signatures wouldn't be wrong.
So far nothing. I'll wait until tomorrow morning my time and if the RPMs are not published I'll send a gentle reminder email asking them to please let us know once they are published.
In the meanwhile, here's a slight touch-up of the SOP so that it now mentions that the upload link is in Bitwarden, where Samyak kindly uploaded it:
infra/docs#540
I sent the gentle reminder email. 👍
Unfortunately no answer as of yet, still waiting on Cisco.
Can we do this now for F46 until Cisco sets things up? I was trying to branch the builds.sr.ht Fedora image, but the build is failing because
dnf upgradeis broken by this (https://builds.sr.ht/~gotmax23/job/1866991#task-sanity-check-117).Yeah, I was sure hoping it would be up by now... but I guess if it's still not we can just move to the empty repo.
Yeah, no response as of yet. Another reminder email sent, hopefully the RPMs will be published soon...
I agree with this approach, historically it has also taken a while to get them published. It can be assumed it'll continue being like that.
yeah, so can you setup an empty repo? or would you like me to?
After the repo exists we need to repoint the mirrormanager alias to it.
The repo already exists I believe, I created it weeks ago:
To double check, is manually creating the directory all that is required?
As for mirrormanager, I would love to do it but I don't think I have the necessary permissions for it. Would you mind doing that part? And ideally also posting the steps so that I may add it to the SOP? (I don't see it there)
An empty directory isn't an empty repo. You have to run
createrepo .in it, to produce repo metadata that says 'this is an empty repo'. :DYeah, it needs:
46/{aarch64|ppc64le|s390x|src|x86_64}/
all created and then 'createrepo_c .' run in each one to create repodata/ that tells things that it has nothing.
We probibly should generate this and then keep a copy around so we can just sync/copy it in place.
BTW, I note the branching SOP actually expressly states to create empty repos for the new rawhide:
...so I don't know why that was missed this time and we made an ad hoc decision to point to the f45 repo instead.
To cross-link back to bugzilla, this is hopefully tracking a fix for https://bugzilla.redhat.com/show_bug.cgi?id=2344545.
OK, I created the relevant subdirectories and ran createrepo_c in each. On
sundries01:Now we should be able to point mirrormanager at it, but as I said previously, unfortunately I don't have the necessary permissions to do that.
Human error. Oversight on my part, as this is part of the preparation that I was responsible for, and I suppose nobody else caught my mistake. This hopefully shouldn't be an issue in the future, I've made updates to the SOP.
Two things left:
Will we ever get openh264 back? My workflows that test my code on rawhide are broken until then.
Could we make the keys from Cisco Fedora 45 repository available on rawhide perhaps?
Rawhide should now be pointed at the empty fedora-46 repo.
We will update it as soon as we are able.
Good news everyone. I just received word from Cisco, the RPMs have been uploaded on their CDN. I went ahead and published the repodata on our side.
Is publishing repodata the last step, or is anything else needed? I am currently getting
@adelton It usually takes mirrormanager a while to pick up the changes (1x a day). However, it's possible to manually force a cronjob run. This was done around half an hour ago. Could you try again and report here if you're still experiencing issues, please?
I rerun the same
podman runcommand, still getting the same error.So, it doesn't seem to be updating in mirrormanager.
The only theory I have is that we had a newer empty set of repos there, so when we put the one from the dist-repo from 3 weeks ago in place it didn't update because it was older? But not sure that is really the case.
@abompard @adrian
Could you all take a look?
The database didn't have the right checksums and the usual trick to set the ctime of the directories didn't help. What is interesting is that the wrong (probably dummy) checksums was newer than the correct checksum. I haven't verified it but it seems that adding an older repomd.xml is not supported. I have delete all the repomd.xml information for codecs/46 and now the correct information should be in the database. In about 20 minutes it should be fixed. I will check it once more in 20 minutes.
I confirm that
now passes for me, finding and installing
openh264-0:2.6.0-4.fc46.x86_64.Yeah, we created the dist-repo first, then later created the empty repo. ;(
We should probibly make an empty repo in advance...
Thanks adrian!
Excellent, and the docs PR is merged as well now. Thanks everyone for your help.