Update, refactor and improve critpath.py: drop yum and Python 2 support, lint cleanups, simplifications, various improvements #11000

Merged
jnsamyak merged 23 commits from critpath-revise-2022 into main 2026-06-08 03:11:05 +00:00
Member

There's a lot here! Best to look at the commit messages.

There's a lot here! Best to look at the commit messages.
Owner

Could we add a comment block here explaining this should be 12 (when we started doing critpath) to 37 (current branched (if exists) or most recent stable)?
And thinking about it, we are never going to change eol releases, so should we just make this current + branched? ie, 35, 37, 1?

Could we add a comment block here explaining this should be 12 (when we started doing critpath) to 37 (current branched (if exists) or most recent stable)? And thinking about it, we are never going to change eol releases, so should we just make this current + branched? ie, 35, 37, 1?
Owner

nitpick: for loading into bodhi ?

nitpick: for loading into bodhi ?
Author
Member

Could we add a comment block here explaining this should be 12 (when we started doing critpath) to 37 (current branched (if exists) or most recent stable)?
And thinking about it, we are never going to change eol releases, so should we just make this current + branched? ie, 35, 37, 1?

It's actually 12 to current branched minus 1 - python ranges exclude the top limit. So it's basically "all stable releases since 12". What we could do to be whizzy is figure this out Live with fedfind, which can tell you what current stable releases and current Branched number are. But I thought that might be too fancy.

> Could we add a comment block here explaining this should be 12 (when we started doing critpath) to 37 (current branched (if exists) or most recent stable)? > And thinking about it, we are never going to change eol releases, so should we just make this current + branched? ie, 35, 37, 1? It's actually 12 to current branched minus 1 - python ranges exclude the top limit. So it's basically "all stable releases since 12". What we could do to be whizzy is figure this out Live with fedfind, which can tell you what current stable releases and current Branched number are. But I thought that might be too fancy.
Author
Member

1 new commit added

  • Add a couple of comments suggested in review (thanks nirik)
**1 new commit added** * ``Add a couple of comments suggested in review (thanks nirik)``
Owner

Thanks!

Thanks!
Owner

Pull-Request has been merged by kevin

Pull-Request has been merged by kevin
Contributor

Thank you!

Thank you!
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
releng/tickets!11000
No description provided.