releng/tickets

Fork 2

orphaned-packages: sync Maxwell's latest changes and add additional scripts #11931

Merged

jnsamyak merged 18 commits from unblocked-orphans2 into main

2026-06-08 03:10:45 +00:00

gotmax23 commented

2024-02-05 04:58:26 +00:00

Member

No description provided.

churchyard commented

2024-02-05 16:35:37 +00:00

Contributor

Should get_people be renamed to get_people_and_email?

churchyard commented

2024-02-05 16:37:28 +00:00

Contributor

...in the left...

churchyard commented

2024-02-05 16:42:33 +00:00

Contributor

I suppose it might be easier to call all_addresses.discard(...) here instead of with-suppress-remove.

churchyard commented

2024-02-05 16:44:09 +00:00

Contributor

The individual commits make sense. I don't know if we should keep the script here or not when it grows this way: what do relengs think?

churchyard commented

2024-02-05 16:44:57 +00:00

Contributor

The retire.py script could probably gain some SPDX-License-Identifier similarily to the original one.

gotmax23 commented

2024-02-05 16:56:03 +00:00

Author

Member

Thanks for the feedback!

Should get_people be renamed to get_people_and_email?

Yeah, I think that makes sense.

...in the left...

Good catch!

I suppose it might be easier to call all_addresses.discard(...) here instead of with-suppress-remove.

Ah, I didn't know about the discard set method. Thanks!

The individual commits make sense. I don't know if we should keep the script here or not when it grows this way: what do relengs think?

I'm fine with moving it to my own scripts repository if that's preferred. I already have some stuff in https://git.sr.ht/~gotmax23/fedora-scripts/tree/main/item/releng/orphaned_packages_process.

The retire.py script could probably gain some SPDX-License-Identifier similarily to the original one.

I'll add one.

Thanks for the feedback! > Should get_people be renamed to get_people_and_email? Yeah, I think that makes sense. > ...in the left... Good catch! > I suppose it might be easier to call all_addresses.discard(...) here instead of with-suppress-remove. Ah, I didn't know about the discard set method. Thanks! > The individual commits make sense. I don't know if we should keep the script here or not when it grows this way: what do relengs think? I'm fine with moving it to my own scripts repository if that's preferred. I already have some stuff in https://git.sr.ht/~gotmax23/fedora-scripts/tree/main/item/releng/orphaned_packages_process. > The retire.py script could probably gain some SPDX-License-Identifier similarily to the original one. I'll add one.

gotmax23 commented

2024-02-06 00:29:16 +00:00

Author

Member

4 new commits added

orphaned_packages_process: add license headers to retire.py
find_unblocked_orphans: rename PagureInfo.get_people method
fixup! unblocked_orphans: don't send emails to the orphan user
fixup! unblocked_orphans: add additional info to email header

**4 new commits added** * ``orphaned_packages_process: add license headers to retire.py`` * ``find_unblocked_orphans: rename PagureInfo.get_people method`` * ``fixup! unblocked_orphans: don't send emails to the orphan user`` * ``fixup! unblocked_orphans: add additional info to email header``

gotmax23 commented

2024-02-06 01:06:28 +00:00

Author

Member

Pushed the changes. Please take another look.

gotmax23 commented

2024-02-06 01:06:37 +00:00

Author

Member

Pushed the changes. Please take another look.

churchyard commented

2024-02-06 10:51:40 +00:00

Contributor

The new commits look good, feel free to autosquash fixups.

I'd probably squash the SPDX identifier to the commit that introduced the script, but not important.

The new commits look good, feel free to autosquash fixups. I'd probably squash the SPDX identifier to the commit that introduced the script, but not important.

gotmax23 commented

2024-02-06 16:48:42 +00:00

Author

Member

18 new commits added

find_unblocked_orphans: rename PagureInfo.get_people method
orphaned_packages_process retire: add --log-file flag
unblocked_orphans: don't send emails to the orphan user
find_unblocked_orphans: allow redirecting report to a file
orphaned_packages_process: add requirements.txt
orphaned_packages_process: add tox env for linters
orphaned_packages_process: add retire.py script
find_unblocked_orphans: add a couple type annotations
orphaned_packages_process: add Dockerfile
find_unblocked_orphans: auto-format code
find_unblocked_orphans: add black and isort config
find_unblocked_orphans: add additional info to JSON output
find_unblocked_orphans: remove deprecated utcnow() usage
unblocked_orphans: add additional info to email header
unblocked_orphans: remove duplicate header definition
find_unblocked_orphans: fix cache directory handling
find_unblocked_orphans: add addresses to the JSON blob
find_unblocked_orphans: better handle group maintainers

**18 new commits added** * ``find_unblocked_orphans: rename PagureInfo.get_people method`` * ``orphaned_packages_process retire: add --log-file flag`` * ``unblocked_orphans: don't send emails to the orphan user`` * ``find_unblocked_orphans: allow redirecting report to a file`` * ``orphaned_packages_process: add requirements.txt`` * ``orphaned_packages_process: add tox env for linters`` * ``orphaned_packages_process: add retire.py script`` * ``find_unblocked_orphans: add a couple type annotations`` * ``orphaned_packages_process: add Dockerfile`` * ``find_unblocked_orphans: auto-format code`` * ``find_unblocked_orphans: add black and isort config`` * ``find_unblocked_orphans: add additional info to JSON output`` * ``find_unblocked_orphans: remove deprecated utcnow() usage`` * ``unblocked_orphans: add additional info to email header`` * ``unblocked_orphans: remove duplicate header definition`` * ``find_unblocked_orphans: fix cache directory handling`` * ``find_unblocked_orphans: add addresses to the JSON blob`` * ``find_unblocked_orphans: better handle group maintainers``

gotmax23 commented

2024-02-06 16:48:45 +00:00

Author

Member

Done!