after this PR merged you got more 2 commits on https://pagure.io/releng/pull-request/12524 , now with some development that allow us to split the find_unblocked_orphans.py into 3 or 4 files

sergiomb commented

2025-01-26 19:12:44 +00:00

Author

Contributor

rebased onto b658e128eb

rebased onto b658e128ebd0dee1c3303b1b9b9f3baa8237889f

sergiomb commented

2025-01-26 19:21:18 +00:00

Author

Contributor

I think we can merge these commits , That are all tested by me . This is first 4 of 12 more or less commits .
This PR doesn't change the result, just simplified the logic and separate functions,
next batch of commits in https://pagure.io/releng/pull-request/12524 already have new features ...

I think we can merge these commits , That are all tested by me . This is first 4 of 12 more or less commits . This PR doesn't change the result, just simplified the logic and separate functions, next batch of commits in https://pagure.io/releng/pull-request/12524 already have new features ...

sergiomb commented

2025-01-27 18:38:01 +00:00

Author

Contributor

4 new commits added

Declare self.dep_chain at the beginning of the class
Replace RAWHIDE_RELEASE by RELEASES["rawhide"]
make SRPM function independent of the class
Simplify the code logic

**4 new commits added** * ``Declare self.dep_chain at the beginning of the class`` * ``Replace RAWHIDE_RELEASE by RELEASES["rawhide"]`` * ``make SRPM function independent of the class`` * ``Simplify the code logic``

kevin commented

2025-01-28 18:22:33 +00:00

Owner

ok, since no one else is answering...

kevin commented

2025-01-28 18:22:43 +00:00

Owner

Pull-Request has been merged by kevin

gotmax23 commented

2025-02-10 23:54:04 +00:00

Member

Apologies for missing this! Thanks for the improvements, @sergiomb, and thanks, @kevin, for reviewing. Feel free to ping me on Matrix if you need a quick review. Also, please remember to run tox to apply formatters and linters before making changes to these files.

Apologies for missing this! Thanks for the improvements, @sergiomb, and thanks, @kevin, for reviewing. Feel free to ping me on Matrix if you need a quick review. Also, please remember to run `tox` to apply formatters and linters before making changes to these files.

sergiomb commented

2025-02-11 13:48:15 +00:00

Author

Contributor

@gotmax23 I'm against this tox rule, can we configure tox to change this rule ?

-def setup_dnf(repo=RELEASES["rawhide"]["repo"], source_repo=RELEASES["rawhide"]["source_repo"]):
+def setup_dnf(
+    repo=RELEASES["rawhide"]["repo"], source_repo=RELEASES["rawhide"]["source_repo"]
+):

-    packages, tagID=RELEASES["rawhide"]["koji_tag"], kojihub=RELEASES["rawhide"]["koji_hub"]
+    packages,
+    tagID=RELEASES["rawhide"]["koji_tag"],
+    kojihub=RELEASES["rawhide"]["koji_hub"],

@gotmax23 I'm against this tox rule, can we configure tox to change this rule ? ``` -def setup_dnf(repo=RELEASES["rawhide"]["repo"], source_repo=RELEASES["rawhide"]["source_repo"]): +def setup_dnf( + repo=RELEASES["rawhide"]["repo"], source_repo=RELEASES["rawhide"]["source_repo"] +): ``` ``` - packages, tagID=RELEASES["rawhide"]["koji_tag"], kojihub=RELEASES["rawhide"]["koji_hub"] + packages, + tagID=RELEASES["rawhide"]["koji_tag"], + kojihub=RELEASES["rawhide"]["koji_hub"], ```

gotmax23 commented

2025-02-11 15:38:37 +00:00

Member

That's the way black works. If the line is more than the max line length, it gets wrapped for readability purposes.

That's the way [black](https://black.readthedocs.io/en/stable/) works. If the line is more than the max line length, it gets wrapped for readability purposes.

sergiomb commented

2025-02-22 04:11:14 +00:00

Author

Contributor

@gotmax23 Now, we got ready more 3 commits to review and merge, on https://pagure.io/releng/pull-request/12524 , with some development that allow us to split find_unblocked_orphans.py in multiple files .