releng/tickets

add ability to mark false negative builds as successful #52

Merged

jnsamyak merged 2 commits from two-week-atomic into master

2026-06-08 03:12:57 +00:00

maxamillion commented

2015-12-01 21:53:12 +00:00

Contributor

No description provided.

maxamillion commented

2015-12-01 21:53:45 +00:00

Author

Contributor

Tested and it works :)

https://apps.fedoraproject.org/datagrepper/id?id=2015-18a1d161-9573-42c8-a880-13456d590e76&is_raw=true&size=extra-large

Tested and it works :) https://apps.fedoraproject.org/datagrepper/id?id=2015-18a1d161-9573-42c8-a880-13456d590e76&is_raw=true&size=extra-large

ralph commented

2015-12-01 22:17:42 +00:00

Contributor

Some stylistic comments:

Imo, it is better to keep things on one line if they're only just barely over the 80 char PEP8 limit rather than break them onto two lines. I'm thinking here of the if gbuild == \ lines. PEP8 is for readability, so break with PEP8 rules if it helps readability.
The humongo if int(atomic_vagrant_vbox[u'msg'][u'image_url'].split('/')[-1].split('.')[0].split('-')[-1]) < int(gbuild.split('.')[0].split('-')[-1]): lines would be more readable if they were broken out into several lines -- mostly so that we can give the pieces names.

Like this:

# Define some helpers
url2image = lambda s: s.split('/')[-1]
image2release = lambda s: int(s.split('.')[0].split('-')[-1]))
# Now use them
candidate = url2image(atomic_vagrant_vbox[u'msg'][u'image_url'])
if image2release(candidate) < image2release(gbuild): # blah blah

Also, -1 to using var names like 'cbuild' and 'gbuild'. I'm not sure what they mean. Do they mean 'check' and 'good'? I'd be cool with just using 'check' and 'good' as names. 'check_build' and 'good_build' are more explicit, but can be tedious to type.

Some stylistic comments: - Imo, it is better to keep things on one line if they're only just barely over the 80 char PEP8 limit rather than break them onto two lines. I'm thinking here of the ``if gbuild == \`` lines. PEP8 is for readability, so break with PEP8 rules if it helps readability. - The humongo ``if int(atomic_vagrant_vbox[u'msg'][u'image_url'].split('/')[-1].split('.')[0].split('-')[-1]) < int(gbuild.split('.')[0].split('-')[-1]):`` lines would be more readable if they were broken out into several lines -- mostly so that we can give the pieces names. Like this: # Define some helpers url2image = lambda s: s.split('/')[-1] image2release = lambda s: int(s.split('.')[0].split('-')[-1])) # Now use them candidate = url2image(atomic_vagrant_vbox[u'msg'][u'image_url']) if image2release(candidate) < image2release(gbuild): # blah blah - Also, -1 to using var names like 'cbuild' and 'gbuild'. I'm not sure what they mean. Do they mean 'check' and 'good'? I'd be cool with just using 'check' and 'good' as names. 'check_build' and 'good_build' are more explicit, but can be tedious to type.

ralph commented

2015-12-01 22:17:56 +00:00

Contributor

👍 to the content of the change, though!

:+1: to the content of the change, though!

Sign in to join this conversation.

No reviewers

No labels

change-noreleng

Fixed with Explanation

Insufficient data

mini-initiative

waiting on external

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

releng/tickets!52

No description provided.