releng/tickets

Fork 2

Fix the URL and method used to remove someone's ACL in dist-git #9635

Merged

jnsamyak merged 4 commits from master into master

2026-06-08 03:11:32 +00:00

pingou commented

2020-07-28 12:31:56 +00:00

Contributor

This should have been fixed in the original PR but apparently it
was merged before my push took effect

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

This should have been fixed in the original PR but apparently it was merged before my push took effect Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>

pingou commented

2020-07-28 12:33:01 +00:00

Author

Contributor

This should fix the error that @churchyard was seeing in the original PR.

I've since found an small oddity which I'm investigating, so feel free to merge this PR but don't be surprised if another one shows up :)

This should fix the error that @churchyard was seeing in the original PR. I've since found an small oddity which I'm investigating, so feel free to merge this PR but don't be surprised if another one shows up :)

pingou commented

2020-07-28 13:02:13 +00:00

Author

Contributor

1 new commit added

When querying the list of packages maintained by people, also query dist-git itself

**1 new commit added** * ``When querying the list of packages maintained by people, also query dist-git itself``

pingou commented

2020-07-28 13:03:11 +00:00

Author

Contributor

There is now a second commit in this PR that fixes the oddity I had found. Basically if someone had "unwatch" a package, we were not taking it into account (since that wouldn't be synced to bugzilla).

This will make the script a little slower, but more reliable.

pingou commented

2020-07-28 13:05:54 +00:00

Author

Contributor

1 new commit added

Small optimization: do not query dist-git if we're only interested in packages watched

**1 new commit added** * ``Small optimization: do not query dist-git if we're only interested in packages watched``

churchyard commented

2020-07-28 13:36:55 +00:00

Contributor

I plan to test this and report back.

churchyard commented

2020-07-28 13:47:16 +00:00

Contributor

This fixes the problem I had before.

Is seems that the bugzilla json is generated cron-ish-ly, so subsequent runs with --retire still report that the users are watching things. I can recheck again once the json is renewed (when is that?).

As a matter of completeness I think the script could also remove the user from bugzilla assignee overrides.

This fixes the problem I had before. Is seems that the bugzilla json is generated cron-ish-ly, so subsequent runs with `--retire` still report that the users are watching things. I can recheck again once the json is renewed (when is that?). As a matter of completeness I think the script could also remove the user from bugzilla assignee overrides.

pingou commented

2020-07-28 13:51:29 +00:00

Author

Contributor

Is seems that the bugzilla json is generated cron-ish-ly, so subsequent runs with --retire still report that the users are watching things. I can recheck again once the json is renewed (when is that?).

That is correct (it's in the description in the --help), the cron runs hourly.

As a matter of completeness I think the script could also remove the user from bugzilla assignee overrides.

Good idea, I'll see to that

> Is seems that the bugzilla json is generated cron-ish-ly, so subsequent runs with --retire still report that the users are watching things. I can recheck again once the json is renewed (when is that?). That is correct (it's in the description in the ``--help``), the cron runs hourly. > As a matter of completeness I think the script could also remove the user from bugzilla assignee overrides. Good idea, I'll see to that

churchyard commented

2020-07-28 14:00:21 +00:00

Contributor

Waiting for at least an hour to see the results.

pingou commented

2020-07-28 14:17:00 +00:00

Author

Contributor

1 new commit added

Check if the packager has a bugzilla overrides and if so, reset it

**1 new commit added** * ``Check if the packager has a bugzilla overrides and if so, reset it``

pingou commented

2020-07-28 14:18:07 +00:00

Author

Contributor

Support for bugzilla overrides added, but we should double-check that it changes only the override of interest, leaving the other one as is (e.i: check that if we retire user "bar" on Fedora, we don't change the override to "foo" on Fedora EPEL)

churchyard commented

2020-07-28 15:01:42 +00:00

Contributor

This return seem bogus. The variable is not defined.

churchyard commented

2020-07-28 15:04:15 +00:00

Contributor

This docstring needs updating.

churchyard commented

2020-07-28 15:41:42 +00:00

Contributor

Waiting for at least an hour to see the results.

Works.

> Waiting for at least an hour to see the results. Works.

pingou commented

2020-07-28 15:53:34 +00:00

Author

Contributor

Sigh, I shouldn't rename variables before pushing...

pingou commented

2020-07-28 15:53:36 +00:00

Author

Contributor

4 new commits added

Check if the packager has a bugzilla overrides and if so, reset it
Small optimization: do not query dist-git if we're only interested in packages watched
When querying the list of packages maintained by people, also query dist-git itself
Fix the URL and method used to remove someone's ACL in dist-git

**4 new commits added** * ``Check if the packager has a bugzilla overrides and if so, reset it`` * ``Small optimization: do not query dist-git if we're only interested in packages watched`` * ``When querying the list of packages maintained by people, also query dist-git itself`` * ``Fix the URL and method used to remove someone's ACL in dist-git``

pingou commented

2020-07-28 15:54:30 +00:00

Author

Contributor

@churchyard comments fixed (and hopefully code as well :))