releng/tooling

Fork 14

orphaned: point out critpath packges in report #13049

Open

gotmax23 wants to merge 3 commits from gotmax23/releng-tooling:orphans-critpath into main

gotmax23 commented

2026-07-26 01:59:12 +00:00

Member

This creates a list of all critical path affected packages at the end of
the report and also lists which critpath groups each package in the
reverse dependency report is a member of.

Example result: https://a.gtmx.me/orphans/tests/orphans-critpath/orphans.txt (you can ctrl+f for "critpath" to find the new parts)

@adamwill pointed out that Bodhi has an API to get critical path packages, and I've wanted to include this in the report for a while, hence this PR. Also tracked in packaging/orphansv2#13 for the v2 script. We can make the v2 script's implementation fancier, but I just want something relatively simple here for the existing script.

This currently tracks critpath affected packages. Do we want to switch this to compare against CCPs (compose critical packages, ref #13039) instead once https://github.com/fedora-infra/bodhi/pull/6142 is merged? Or is there a utility in reporting both?
get_critpath_components() does not make any attempts to retry the Bodhi API call on failure. Using the requests Retry session boilerplate or falling back to returning nothing would be better.

This creates a list of all critical path affected packages at the end of the report and also lists which critpath groups each package in the reverse dependency report is a member of. --- Example result: https://a.gtmx.me/orphans/tests/orphans-critpath/orphans.txt (you can ctrl+f for "critpath" to find the new parts) @adamwill pointed out that Bodhi has an API to get critical path packages, and I've wanted to include this in the report for a while, hence this PR. Also tracked in https://forge.fedoraproject.org/packaging/orphansv2/issues/13 for the v2 script. We can make the v2 script's implementation fancier, but I just want something relatively simple here for the existing script. - [ ] This currently tracks critpath affected packages. Do we want to switch this to compare against CCPs (compose critical packages, ref https://forge.fedoraproject.org/releng/tooling/pulls/13039) instead once https://github.com/fedora-infra/bodhi/pull/6142 is merged? Or is there a utility in reporting both? - [x] `get_critpath_components()` does not make any attempts to retry the Bodhi API call on failure. Using the requests Retry session boilerplate or falling back to returning nothing would be better.

gotmax23 added 1 commit

2026-07-26 01:59:12 +00:00

orphaned: point out critpath packges in report

Orphaned CI / Run Tox Checks for Orphaned tools (pull_request) Failing after 1m25s

Details

714cf5e4f7

This creates a list of all critical path affected packages at the end of
the report and also lists of which critpath groups each package in the
reverse dependency report is a member.

gotmax23 added 1 commit

2026-07-26 02:03:28 +00:00

lint: orphans: restore previous ruff default rules

Orphaned CI / Run Tox Checks for Orphaned tools (pull_request) Successful in 1m22s

Details

6f7ea4f66e

adamwill commented

2026-07-26 06:04:22 +00:00

Member

I would say doing both critpath and ccp is probably good to start with at least. Once I get the PR to pass tests, anyway.

gotmax23 referenced this pull request

2026-08-10 14:43:53 +00:00

F45 Mass Branching: Update relevant scripts #13050

gotmax23 force-pushed orphans-critpath from 6f7ea4f66e

Orphaned CI / Run Tox Checks for Orphaned tools (pull_request) Successful in 1m22s

Details

to b387c4db66

Orphaned CI / Run Tox Checks for Orphaned tools (pull_request) Successful in 1m19s

Details

2026-08-10 18:08:18 +00:00

Compare

gotmax23 changed title from ~~WIP: orphaned: point out critpath packges in report~~ to orphaned: point out critpath packges in report

2026-08-10 18:08:38 +00:00

gotmax23 requested review from Owners

2026-08-10 18:08:38 +00:00

kevin commented

2026-08-10 21:40:28 +00:00

Owner

yes, I think both have value.

Also, perhaps they should appear at the top? it's hard to want to scroll down to the end of these reports sometimes...

yes, I think both have value. Also, perhaps they should appear at the top? it's hard to want to scroll down to the end of these reports sometimes...

Orphaned CI / Run Tox Checks for Orphaned tools (pull_request) Successful in 1m19s

Details

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u orphans-critpath:gotmax23-orphans-critpath

git switch gotmax23-orphans-critpath

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main

git merge --no-ff gotmax23-orphans-critpath

git switch gotmax23-orphans-critpath

git rebase main

git switch main

git merge --ff-only gotmax23-orphans-critpath

git switch gotmax23-orphans-critpath

git rebase main

git switch main

git merge --no-ff gotmax23-orphans-critpath

git switch main

git merge --squash gotmax23-orphans-critpath