server/user-documentation

Fork 9

WIP: stg My edits to the NFS server setup docs #175

Closed

korora wants to merge 7 commits from korora/user-documentation:stg into main

korora commented

2025-10-31 02:34:48 +00:00

Member

I have taken care of #170 and #174 in these edits.

korora added 7 commits

2025-10-31 02:34:49 +00:00

First step to synchronize the stg branch to the main banch. See ticket #174 8aba0dac9b

Updated SBC doc according to #168 a5d0ee7223

Part 2 of the update 00e57d9be3

Fixed installation menu entry label. 55bd0c3ba0

Starting a branch for nfs installation update. 9efc7a7abc

Merged NFS guide to discuss update. cdf61e86bb

fixed some typos in nfs filesharing docs and brought versions in line for FC43 7e59aa8222

korora added 1 commit

2025-10-31 02:54:23 +00:00

Removed trailing whitespace from nav.adoc 7eea232a89

korora commented

2025-10-31 03:04:26 +00:00

Author

Member

This looks like it hsa more in it than it should

eseyman requested review from eseyman

2025-10-31 07:09:52 +00:00

copperi commented

2025-10-31 20:05:18 +00:00

Contributor

Looks ok to me.

korora commented

2025-11-04 05:10:15 +00:00

Author

Member

@copperi wrote in #175 (comment):

Looks ok to me.

It should have only been the updates to the NFS guide (the removing trailing whitespace was me testing something else...)

@copperi wrote in https://forge.fedoraproject.org/server/user-documentation/pulls/175#issuecomment-146920: > Looks ok to me. It should have only been the updates to the NFS guide (the removing trailing whitespace was me testing something else...)

pboy approved these changes

2025-11-07 08:10:26 +00:00

pboy left a comment

Seems OK to me. Although, I wonder why the many changes I made are included in the PR.

What I don't understand is why you removed the line about installing a generic disk image from the navigation. But that doesn't matter right now. (file ROOT/nav.adoc)

Seems OK to me. Although, I wonder why the many changes I made are included in the PR. What I don't understand is why you removed the line about installing a generic disk image from the navigation. But that doesn't matter right now. (file ROOT/nav.adoc)

pboy commented

2025-11-07 10:29:06 +00:00

Owner

Undo everything! I just realized that this is the wrong workflow. The PR says: “korora wants to merge 8 commits from korora/user-documentation:stg to main.” I explain how the workflow should have been in the Contributor's Guide in our team documentation.

What I have done now: Cherry-pick corora's changes in the file filesharing-nfs-installation.adoc to branch nfs-upd in main repository and then merge nfs-upd to stg branch (in main repositopry).

Once the documentation is rebuilt, the changes should be visible there.

**Undo everything!** I just realized that this is the wrong workflow. The PR says: “korora wants to merge 8 commits from korora/user-documentation:stg to main.” I explain how the workflow should have been in the Contributor's Guide in our team documentation. What I have done now: Cherry-pick corora's changes in the file filesharing-nfs-installation.adoc to branch nfs-upd in main repository and then merge nfs-upd to stg branch (in main repositopry). Once the documentation is rebuilt, the changes should be visible there.

korora commented

2025-11-07 15:03:08 +00:00

Author

Member

When I created the PR, I only wanted my changes to be part of it, and... Forge had other ideas